Closed
Bug 999750
Opened 10 years ago
Closed 10 years ago
Recycle MotionEvents
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(1 file)
6.02 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
It seems like we missed a few. The one in TabsTray will be taken care of in bug 958889. Note that I didn't think surrounding the MotionEvents with try/finally in the non-test code was necessary because if we throw in there, I believe we're losing the whole process anyway.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8410607 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Comment 2•10 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=174e1962cbcc
Comment 3•10 years ago
|
||
Comment on attachment 8410607 [details] [diff] [review] Recycle MotionEvents. Review of attachment 8410607 [details] [diff] [review]: ----------------------------------------------------------------- For all of these, please set event = null after you recycle it, to avoid adding a use-after-recycle footgun. r=me with that.
Attachment #8410607 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 4•10 years ago
|
||
w/ nits: https://hg.mozilla.org/integration/fx-team/rev/c2cd82f2d911
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c2cd82f2d911
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•