Closed Bug 999750 Opened 6 years ago Closed 6 years ago

Recycle MotionEvents

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: mcomella, Assigned: mcomella)

Details

Attachments

(1 file)

It seems like we missed a few. The one in TabsTray will be taken care of in bug 958889. Note that I didn't think surrounding the MotionEvents with try/finally in the non-test code was necessary because if we throw in there, I believe we're losing the whole process anyway.
Attachment #8410607 - Flags: review?(bugmail.mozilla)
Comment on attachment 8410607 [details] [diff] [review]
Recycle MotionEvents.

Review of attachment 8410607 [details] [diff] [review]:
-----------------------------------------------------------------

For all of these, please set event = null after you recycle it, to avoid adding a use-after-recycle footgun. r=me with that.
Attachment #8410607 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/c2cd82f2d911
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
You need to log in before you can comment on or make changes to this bug.