999760 - Images in article items are mis-aligned

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[:Margaret Leibovic]

Attachment: 2014-04-22 23.06.15.png

Follow-up to bug 993749.

See the screenshot, I think we should make sure the images have the same padding as the text.

Comment 1

[:Margaret Leibovic]

Attachment: Apply padding to entire article item view

This patch is an improvement on bug 993749 and probably what I should have done originally. Instead of setting padding on the text container, this sets padding on the entire item.

Comment 2

[:Margaret Leibovic]

Attachment: with patch applied

I updated my hub kitchen sink add-on to also use images: https://github.com/leibovic/hub-kitchen-sink/

Comment 3

[:Margaret Leibovic]

Attachment: Apply padding to entire article item view

Oops, uploaded wrong patch.

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8410696 [details] [diff] [review]
Apply padding to entire article item view

Review of attachment 8410696 [details] [diff] [review]:
-----------------------------------------------------------------

I like that you stuck the value in dimens.xml!

::: mobile/android/base/resources/layout/panel_article_item.xml
@@ -21,3 @@
>                    android:paddingLeft="10dip"
>                    android:paddingRight="10dip"
> -                  android:minHeight="@dimen/page_row_height"

Do we want to get rid of minHeight? I guess we'd always have some content in there...

Comment 5

[:Margaret Leibovic]

(In reply to Chenxia Liu [:liuche] from comment #4)

> ::: mobile/android/base/resources/layout/panel_article_item.xml
> @@ -21,3 @@
> >                    android:paddingLeft="10dip"
> >                    android:paddingRight="10dip"
> > -                  android:minHeight="@dimen/page_row_height"
> 
> Do we want to get rid of minHeight? I guess we'd always have some content in
> there...

I got rid of the minHeight because that was something lucasr suggested in bug 993749 comment 6. As he mentions there, these items can have variable height anyway, so I think it's better to just ensure consistent top/bottom padding.

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/a3df9c0ee15f

Comment 7

[:Margaret Leibovic]

Comment on attachment 8410696 [details] [diff] [review]
Apply padding to entire article item view

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 993749 (and new hub APIs for fx30)
User impact if declined: item padding can look inconsistent on hub panels
Testing completed (on m-c, etc.): just landed on fx-team, tested locally with kitchen sink add-on
Risk to taking this patch (and alternatives if risky): low-risk padding tweaks
String or IDL/UUID changes made by this patch: none

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a3df9c0ee15f

Comment 9

[:Margaret Leibovic]

Comment on attachment 8410696 [details] [diff] [review]
Apply padding to entire article item view

Lukas and I discussed this on IRC - I missed uplifting this for the merge, which isn't a big deal, but I will need to land it on beta after the merge is finished.

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-beta/rev/d9336eebf796

Comment 11

[Flaviu Cos]

Verified as fixed in builds:
- 32.0a1 (2014-05-05);
- 31.0a2 (2014-05-05);
Device: Google Nexus 5 (Android 4.4.2).

Will mark the bug as verified after retesting it on the next beta.

Comment 12

[Flaviu Cos]

Verified as fixed in build 30 beta 2;
Device: Motorola Razr (Android 4.0.4).

Comment 13

[:Margaret Leibovic]

I realized I messed up this uplift. Fixed: https://hg.mozilla.org/releases/mozilla-beta/rev/ea7fa7d12c15

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/ea7fa7d12c15