Closed Bug 999851 Opened 6 years ago Closed 6 years ago

remove topN support from search service

Categories

(Firefox :: Search, defect)

x86_64
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 32

People

(Reporter: mconnor, Assigned: mconnor)

References

Details

Attachments

(1 file)

Attached patch topNBackoutSplinter Review
This isn't (wasn't?) a needed feature (see discussion in bug 983723).  We're already actively updating engines to not use it, but since the principle behind it was flawed, just removing the feature seems like the right next step.

Attached patch removes the relevant code, and adds some logging to dump if we hit a MozParam that tries to use this (or any other unknown condition).
Attachment #8410687 - Flags: review?(gavin.sharp)
Comment on attachment 8410687 [details] [diff] [review]
topNBackout

thanks
Attachment #8410687 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/mozilla-central/rev/06449d964ed3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
You need to log in before you can comment on or make changes to this bug.