999965 - enable DSDS tests via manifest with the Flame device name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

test_settings_sim_manager is run only on dsds devices.

Ahead of putting the flame to the MV grid we need to update the manifest to include flame.

the flame's name is "msm8610" 

run-if = device == "sp7710gaplus_gonk" || device == "msm8610"

Comment 1

[Zac C (:zac)]

Alison, also can you do this for your pending pull requests?

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Is there a way to detect DSDS (perhaps through a WebAPI) and then simply skip the test if the target is not supported?

Comment 3

[Zac C (:zac)]

Probably, but the API could be something that regresses and causes the test to be skipped. I'd rather be explicit about it like we are about other hardware on the device.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Zac C (:zac) from comment #3)
> Probably, but the API could be something that regresses and causes the test
> to be skipped. I'd rather be explicit about it like we are about other
> hardware on the device.

What about a small unit test for the code to detect DSDS? I'm just thinking that's more maintainable and less prone to human error.

Comment 5

[Zac C (:zac)]

Then you've a unit test to maintain! I'm not mad on the manifest files either but I'd rather just continue the current style for ease; we've got bigger issues to focus on at the moment.

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This isn't the right place to discuss the merits of unit tests. Feel free to ignore my suggestion, it was just a suggestion. :)

Comment 7

[Alison Shiue]

Attachment: PR 18624

Zac, I've added this PR to update manifest for test_settings_sim_manager, and I also updated my previous 3 PRs for the manifest. Please check them, thank you!

Comment 8

[Zac C (:zac)]

Comment on attachment 8411655 [details] [review]
PR 18624

r+!

Comment 9

[Zac C (:zac)]

Thanks Alison!

Merged:
https://github.com/mozilla-b2g/gaia/commit/8e601db342f13804ae759a09893baba99603e4c8