102093 - parameter named "arguments" is not accessible in JavaScript method

Status: RESOLVED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Phil Schwartau]

This is the Rhino version of bug 94506 in SpiderMonkey, reported by 
[e-mail]:

The following code does not do what is expected:

function f(arguments)
{ 
  return arguments;
} 
f(5);


Actual Results:    [object Arguments]
Expected Results:  5


There is a testcase for this in the JS testsuite:

        mozilla/js/tests/ecma_3/Function/regress-94506.js


See bug 94506 for considerable discussion -

Comment 1

[Igor Bukanov]

Attachment: Fix and optimization

The patch adds to NativeCall constructor checks to ensure that arguments object
is only initialized if there is no function parameter with the same name.

I also split NativeCall that inherited from IdScriptable into NativeCall that
extends ScriptableObject and NativeCallPrototype that extends to make instances
of NativeCall smaller and to allow for faster property access since get/put/has
would not go throw an additional indirection level in IdScriptable.

Comment 2

[Igor Bukanov]

I committed the fix

Comment 3

[Igor Bukanov]

Attachment: rhino-n.tests update to remove skipping of ecma_3/Function/regress-94506.js

Due to the bug fix Rhino passing now ecma_3/Function/regress-94506.js so there
is no point to skip it. 

Phil, could you apply this?

Comment 4

[Igor Bukanov]

Targeting as resolved against 1.5R5