106114 - shouldn't assume ftp dates are in GMT

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, defect, P3)

Description

[Leston Buell]

I'm putting these all in one bug on the assumption that they appeared
simultaneously. Several major bugs have suddenly appear in the directory viewer.
I'm using Linux 2001-10-22-10-trunk.

BUG #1

Open the mozilla ftp nightly directory an note the modification times listed for
a couple of directories. Then open the same directory in another browser such as
Netscape 4 or Konqueror. The times do not match. Some examples:

2001-10-22-17-trunk
   moz: 10/22/2001 07:26:00 AM
   ns:  Mon Oct 22 14:26:00 2001

2001-10-20-11-0.9.4
   moz: 10/20/2001 05:39:00 AM
   ns:  Sat Oct 20 12:39:00 2001

The times seem to all be off by seven hours.

BUG #2

Note that all of the August directories (2001-08...) are missing. Note that
they're not missing in another viewer.

BUG #3

The link to the parent directory has disappeared.

BUG #4

It seems to be taking *much* longer to open an ftp directory than usual.

Comment 1

[sairuh (rarely reading bugmail)]

->bradley

bug #3 is a dup of bug 103737.

Comment 2

[Bradley Baetz (:bbaetz)]

Bug 1 - ns4 just displays the time as given by the server. We assume that the
server's time is in GMT, and convert it.

Bug 2 - ns4 doesn't show the Auguest stuff, and neither does a packettrace. INVALID.

Bug 3 - Dupe of bug 103737

Bug 4 - comapred to what? Is there an example url?

Morphing to match bug 1.

This is a regression, caused my me trying to match the time on my
(misconfigured) ftp server. We can't assume that the server time is in GMT.
Although there is an extention to the ftp protocol to do so, I've never seen it
used. Patch coming

Comment 3

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 4

[Darin Fisher]

Comment on attachment 54587 [details] [diff] [review]
patch

sr=darin

Comment 5

[Bradley Baetz (:bbaetz)]

Checked in 

reporter, if you have otehr issues, please open a separate bug for those.

Comment 6

[benc]

leston: can you give us an update, perhaps with a Mozilla 1.0 or RCx build?

Comment 7

[Leston Buell]

The one relevant part of this bug was the hour being off. I have opened the URL
in Mozilla 1.0 2002-05-06-15 and in Netscape 4.7 and there is no longer a
discrepancy between the times displayed. So, i guess this is really fixed.

Comment 8

[benc]

VERIFIED: per reporter.