107214 - moving mail from inbox to folders causes 2-minute-system-block or complete crash of mozilla Trunk [@ nsFileTransport::Process]

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[tabit]

I use Mozilla since 0.93 (eng.), the first one able to import my 450 MBytes of 
Netscape-4.x-Email without major errors. The application is more or less stable 
but there are some severe bugs in the mail-subsystem that have not been fixed 
till the 0.95 (german) version I am using now.

Two bug seems to be described by someone else, as they are: loosing whole 
paragraphs in the email-editor when selecting and deleting single letters or 
digits & big parts of the text seemingly dissappear, and can only be recovered 
by saving and closing the message and then reopening it from the drafts-folder.

The new one is: If I sort my email and move it to other places in the folder-
tree:

1. The selection-feature does not always work (using shift+arrow-keys), 
2. If I move email with drag&drop (single or groupwise), Mozilla sometimes 
blocks the whole System for about two miniutes or even crashes completely. It 
happens now about two to three times a day while I am sorting email five to 
seven times a day. 

###context###

I am using Netscape for Email since version 4.x appeared in 1997 because the 
screenlayout of Eudora I used before did not satisfy my requirements anymore. I 
used to like it, but I wanted to try an improvement. As long as reliability is 
concerned Mozilla seems to me a step backwards up to now. Also comfort if it 
comes to move loads of Email to another Volume than C:\ is not  given. Many 
forms even ion mozilla.org do not work with mozilla, this is why I am using 
Internet Explorer 6 to write this. There is a long long way to go to reach 1.0. 
Thank you anyway for your work.

Comment 1

[Matthias Versen [:Matti]]

Reporter:
Thanks for your bug report but please file one bug for every problem
(after you searched at bugzilla)

This bug is now only for the crash while moving !
Please use a talkback enabled build and if you crash and talkback submitted the
crash run install-dir\components\talkback.exe and poste the talkback ID in this bug.

Form submission:
This is a ugly bug that you can see only with the de-at-build(see bug 104684).
Kairo updated the builds on www.kairo.at/mozilla.
Please download a new german build from there (but not a german from
ftp.mozilla.org) or download the english mozilla version (from ftp.mozilla.org)
and install the de-at.xpi.

Comment 2

[tabit]

I downloaded and installed the "fixed"-de/at-builds from kairos site (version of
28/10/2001) which still shows the reported behavior on my machine & I downloaded
a "nightly build/en" from mozilla.org, which does not show the behavior anymore
but has very smooth selection and moving.

Comment 3

[tabit]

today I could reproduce the Bug as described with a talkback-enabled nightly 
build from 02 November 2001. Talkbackdata was sent and can additionally be 
obtained by anyone interested. Just Email me.

Comment 4

[Matthias Versen [:Matti]]

tabit: 
Please run install-dir\mozilla\bin\components\talkback.exe and poste the
Talkback ID in this bug !

Thanks !

Comment 5

[tabit]

Matti asked me to poste the 

Incident ID | TB37709113X
captured at | 07.11.2001 22:36
tape | Program Crash

Comment 6

[Matthias Versen [:Matti]]

CC Stephend for a non sucking talkback stack trace. (TB37709113X)

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

Incident ID 37709113
Stack Signature ntdll.dll + 0x4b9b1 (0x778cb9b1) fafd8c81
Bug ID
Trigger Time 2001-11-07 13:31:25
Email Address [e-mail]
URL visited mail/news mving as described in my Bug-Report 107214
User Comments for more information see:
http://bugzilla.mozilla.org/show_bug.cgi?id=107214 Mozilla/5.0 (Windows; U;
Windows NT 5.0; en-US; rv:0.9.5+) Gecko/20011102
Build ID 2001110212
Product ID MozillaTrunk
Platform ID Win32
Trigger Reason Access violation
Stack Trace
ntdll.dll + 0x4b9b1 (0x778cb9b1)
ntdll.dll + 0x4b733 (0x778cb733)
MSVCRT.DLL + 0x1d92 (0x78001d92) 

Comment 8

[tabit]

1. I think it should be clear from the context, that we are talking about a 
case with multiple POP3-mailboxes and a big mail-archive of about 500 MByte on 
the local harddrive.

2. Last time I saw the crash, i.e. the time when I sent talkback data, shortly 
afterwards there was a crash of Macafee's 5.21 vshield-component that I set up 
to scan anything that happens on the computer while working.

Comment 9

[tabit]

could reproduce again, this time with nightly build 07 November 2001

Talkback Data at TB37765524W
captured 09.11.2001 01:30
program crash

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Incident ID 37765524 
Stack Signature ntdll.dll + 0x4b9b1 (0x778cb9b1) 1657620d  
Bug ID  
Trigger Time  2001-11-08 16:26:10  
Email Address  [e-mail]  
URL visited  mail-moving crash reproduced with nightly build 07112001  
User Comments  ..as described in Bug-report at: 
http://bugzilla.mozilla.org/show_bug.cgi?id=107214  
Build ID 2001110709  
Product ID MozillaTrunk  
Platform ID Win32  
Trigger Reason Access violation  
Stack Trace  
ntdll.dll + 0x4b9b1 (0x778cb9b1) 
ntdll.dll + 0x4b733 (0x778cb733) 
MSVCRT.DLL + 0x1d92 (0x78001d92) 
PR_Free [../../../../pr/src/malloc/prmem.c, line 84] 
nsMemoryImpl::Free [d:\builds\seamonkey\mozilla\xpcom\base\nsMemoryImpl.cpp, 
line 343] 
nsMemory::Free [d:\builds\seamonkey\mozilla\xpcom\base\nsMemoryImpl.cpp, line 
575] 
nsElementMap::ReleaseContentList 
[d:\builds\seamonkey\mozilla\content\xul\document\src\nsElementMap.cpp, line 
153] 
nsElementMap::~nsElementMap 
[d:\builds\seamonkey\mozilla\content\xul\document\src\nsElementMap.cpp, line 
134] 
nsXULDocument::~nsXULDocument 
[d:\builds\seamonkey\mozilla\content\xul\document\src\nsXULDocument.cpp

Comment 11

[Matthias Versen [:Matti]]

-> XPCOM (?)

Comment 12

[Anders Åge Larsen]

Since this bug was reported, a newer version of Mozilla (1.0 RC1) has been
released. Reporter, please can you check to see whether this bug is still 
present in a recent build (Moz1-RC1 or a new nightly build). If
this bug does not occur please can you resolve the bugreport?

Comment 13

[tabit]

Attachment: talkback-data for 18042002-crashes

Actually I am using nightly build (12042002) to write this, which is a stable
version. RC1 (18042002) is unstable: 

It crashes on exit (see my earlier bugreport on this topic)
It crashes suddenly out of no reason and
It crashes on pressing the reply-button in an Email-Window

but, to answer frankly, I did not experience a crash on moving Email in ages
and
I use to switch builds every few days.

regards

tabit

Comment 14

[Michael Gabriel]

what about rc3 (nightlies)? if its fine close this bug and reopen if it happens
again ?

Comment 15

[tabit]

to be honest: I haven't seen this bug in month, so for me it is OK to close for
the time being

Comment 16

[Michael Gabriel]

its yours, resolve it as works for me yourself ;)

Comment 17

[tabit]

Here it is again:
Mozilla 1.0.0+ Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.0+)
Gecko/20020601

See attachments for talkback-data. The lateast builds 29052002 and 01062002 seem
to be buggy as hell, crashing all the time on no purpose, but also on moving
enmail from inbox to folders

regards

tabit

Comment 18

[tabit]

Attachment: talkbackcodes for 29052002 and 01062002

talkbackcodes

Comment 19

[tabit]

and: TB 69 11 858 W

Comment 20

[tabit]

Attachment: talkbackcodes (updated)

talkbackcodes (updated)

Comment 21

[[e-mail] (gone - use [e-mail] instead)]

nsFileTransport::Process [nsFileTransport.cpp, line 753] 

Comment 22

[tabit]

I switched bach to nightly 18042002, because the very new builds habe the 

"move-email-crash-issue" in a massive version: I can not move any email from any
folder to any other folder without immediate crash (see last GIF-attachment of
23:38).

The difference from the old move-mail-crash is, that there is no 2 minute
waiting anymore, the crash occurs instantaneously.

regards

tabit

Comment 23

[Doug Turner (:dougt)]

dup

*** This bug has been marked as a duplicate of 113949 ***

Comment 24

[Michael Gabriel]

how can he reproduce it april 2002 when it was fixed  dec 2001 ?

Comment 25

[Doug Turner (:dougt)]

d'oh!

Comment 26

[tabit]

Attachment: talkbackcodes for built 02062002

I can in fact move single messages, but if I move more (say: three and up)
mozilla dies immediately

Comment 27

[Doug Turner (:dougt)]

Looks like mListener which is stored in ecx is null and we do something like this

mov     edx,[ecx].

Looking at the source, in a debug build we should see an assertion if the
listener|observer object passed into AsyncRead is null.  

A solution is to protect against null listener|observers.  

Comment 28

[Doug Turner (:dougt)]

Attachment: propsed patch v.1

should fix the crash.  Not certain about the "2-minute-system-block".

Note that the socket transport does a similar check on
nsSocket(Read|Write)Request.

Comment 29

[Doug Turner (:dougt)]

Attachment: patch v.2

errors out if AyncRead|Write encounter a null listener|provider

Comment 30

[Darin Fisher]

Comment on attachment 86115 [details] [diff] [review]
patch v.2

sr=darin

Comment 31

[Doug Turner (:dougt)]

Comment on attachment 86115 [details] [diff] [review]
patch v.2

r=pavlov

Comment 32

[Doug Turner (:dougt)]

Checked into trunk:

Checking in nsFileTransport.cpp;
/cvsroot/mozilla/netwerk/base/src/nsFileTransport.cpp,v  <--  nsFileTransport.cpp
new revision: 1.128; previous revision: 1.127
done
Checking in nsSocketTransport.cpp;
/cvsroot/mozilla/netwerk/base/src/nsSocketTransport.cpp,v  <-- 
nsSocketTransport.cpp
new revision: 1.241; previous revision: 1.240
done

Comment 33

[greer]

This is the #1 topcrasher in the Trunk data currently (before the checkin).
Adding topcrash keyword and signature in the summary. Talkback should be able to
help verify this one when we have a few days of post checkin data.

Comment 34

[tabit]

I suggest to REOPEN, as there seems to be an issue with the fix (possibly a
dependency). The fix works in 20020603, but reoccurs in 20020605 in a different
form:

OLD BUG: you could move single messages, but mozilla crashed on moving two or more

NEW BUG: you can move single messages, but mozilla shows no reaction on moving
two or more (= you can not move these messages)

I guess there is an unresolved dependency between the fix of the old bug and the
new bug.

If you do not REOPEN, then please file a new bug on that issue

regards

tabit

Comment 35

[Doug Turner (:dougt)]

file a new bug if you are seeing this problem.  Please include detailed steps on
reproducing the bug.  

Comment 36

[Jay Patel [:jay]]

v.fixed per Talkback data.  This crash last occurred with MozillaTrunk builds
from 6/3.

Comment 37

[Navin Gupta]

*** Bug 149345 has been marked as a duplicate of this bug. ***

Comment 38

[Navin Gupta]

*** Bug 149128 has been marked as a duplicate of this bug. ***

Comment 39

[Steffen Motzer]

*** Bug 149330 has been marked as a duplicate of this bug. ***

Comment 40

[tabit]

Posted bug 149906 on possible error in the fix for bug 107214 as recommended
earlier here

Comment 41

[David A. Cobb]

Using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1a) Gecko/20020607
Build ID 2002060704

I've just filed a comment on Bug#133996, "Compact folders don't work", detailing
a new pathology in compacting folders that seems likely related to fixing this one.

Comment 42

[Jim Salter]

Shouldn't the code in the patch have "status = mProvider->OnDataWritable(this,..."?

+        if (mProvider)
+            mProvider->OnDataWritable(this, 
+                                      mContext,
+                                      mSinkWrapper,
+                                      mOffset, 
+                                      transferAmt);

Comment 43

[Doug Turner (:dougt)]

wow.

good catch.  see http://bugzilla.mozilla.org/show_bug.cgi?id=153414