112252 - Clicking on any part of a component in installer selects/deselects it

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Francisco León]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.6+) Gecko/20011126
BuildID:    2001112308

Linux only
[x] Component
If you click on any part of the line, the component selects/deselects. It should
only do so when clicking inside the [ ]
Windows installer works as desired.

Reproducible: Always
Steps to Reproduce:
1.Click on any part of the component line
2.
3.

Actual Results:  Selection/Deselection when not expected

Expected Results:  Windows-alike behaviour

Comment 1

[TT]

I see this too on Linux.  You don't even need to click on the item - using the
cursor keys to move the highlight up and down will also toggle the checkbox
state.  This bug is problematic because the only way to view the description of
each component is to highlight it, but if you highlight it in any way, you
toggle the checkbox!

FYI, this occurs on the dialog box that's labelled "Please select the components
you wish to install."

Comment 2

[Andrew Schultz]

Attachment: patch

this sets the component description text for clicking on the component text,
but doesn't toggle it.

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 144393 [details] [diff] [review]
patch

r=dveditz

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 144393 [details] [diff] [review]
patch

For integer values (not pointers or booleans) I tend to prefer writing:

if (aColumn != 0)

It looks like that might be the style used elsewhere in this code as well. 
sr=bryner with that changed.

Comment 5

[Andrew Schultz]

Attachment: patch for checkin

this addresses bryner's review comment

Comment 6

[Andrew Schultz]

checked in by bz

Comment 7

[Andrew Schultz]

Comment on attachment 145980 [details] [diff] [review]
patch for checkin

this needs to go on the branch with the one from bug 240212

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 145980 [details] [diff] [review]
patch for checkin

a=asa (on behalf of drivers) for checkin to 1.7

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in on 1.7 branch