Closed
Bug 240212
Opened 21 years ago
Closed 21 years ago
Custom install "Please select.." keyboard commands do not update Description
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.8alpha1
People
(Reporter: benc, Assigned: ajschult784)
References
Details
(Keywords: access, verified1.7)
Attachments
(1 file)
|
929 bytes,
patch
|
dveditz
:
review+
bryner
:
superreview+
asa
:
approval1.7+
|
Details | Diff | Splinter Review |
STEPS:
Mozilla 1.6, Linux
Run installer, select "custom"
Looking at the custom installs, you can select a component by keyboard (up/down
arrows) or by mouse.
OBSERVED:
If you hilight a component, the description does not update unless you hit space
bar (which toggles the checkbox for installation).
|
Assignee | |
Comment 1•21 years ago
|
||
this is trivial to fix once bug 112252 lands
(although I'm not sure which trivial fix is best)
we can stop dropping keyboard events in RowSelected, or handle this case in
KeyPressed. RowSelected seems better, but I'm not sure if other types of events
might trigger the case that gets dropped.
==> me
|
|
Assignee | |
Comment 2•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #146249 -
Flags: review?(dveditz+bmo)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 146249 [details] [diff] [review]
patch
r=dveditz
Attachment #146249 -
Flags: review?(dveditz) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #146249 -
Flags: superreview?(bryner)
|
||
Updated•21 years ago
|
Attachment #146249 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Comment 4•21 years ago
|
||
fixed
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•21 years ago
|
||
the patch here would need to go on the branch along with the one from 112252.
Neither have caused known regressions. If you think this is sufficiently
important, request approval for the patch
This doesn't have to block 1.7, but an eventual branch fix would be very nice.
Flags: blocking1.7?
|
||
Comment 9•21 years ago
|
||
Comment on attachment 146249 [details] [diff] [review]
patch
a=asa (on behalf of drivers) for checkin to 1.7
Attachment #146249 -
Flags: approval1.7+
|
|
||
Comment 10•21 years ago
|
||
has this landed on the 1.7 branch yet? I don't see any checkins referencing this
bug.
Flags: blocking1.7? → blocking1.7-
|
Reporter | |
Comment 12•21 years ago
|
||
I got email from a branch user saying this is fixed.
Keywords: fixed1.7 → verified1.7
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•