114583 - script compile/decompile bug

Status: VERIFIED FIXED

(Rhino Graveyard :: Compiler, defect)

Description

[Th]

the following code :

>	    	Context cx = Context.enter();
>		Scriptable scope = cx.initStandardObjects( null );
>
>	        cx.setGeneratingDebug( true );
>	        cx.setGeneratingSource( true );
>
>		String src = " var x = 5; var y = 10; "; 
>		StringReader sr = new StringReader( src ); 
>		Script script = null;
>		
>		try {
>			script = cx.compileReader( scope, sr, "Test", 1, null );
>		} catch ( Exception e ) {
>		}
>		System.out.println( cx.decompileScript( script, scope, 4 ) );
>		System.exit( 1 );
		
gives :

	function () {
		[native code]
	}

whereas the following :

>	    	Context cx = Context.enter();
>		Scriptable scope = cx.initStandardObjects( null );
>
>	        cx.setGeneratingDebug( true );
>	        cx.setGeneratingSource( true );
>
>		String src = " var x = 5; var y = 10; "; 
>		StringReader sr = new StringReader( src ); 
>		Script script = null;
>		
>		try {
>			script = cx.compileReader( scope, sr, "Test", 1, null );
>			script.exec(cx, scope);
>		} catch ( Exception e ) {
>		}
>		System.out.println( cx.decompileScript( script, scope, 4 ) );
>		System.exit( 1 );


behaves as expected (by printing the decompiled script). 
( there is a added exec() call to "script" )

Comment 1

[Igor Bukanov]

This is fixed as a byproduct of recent changes in decompilation support, for
test see the following java source.

Comment 2

[Igor Bukanov]

Attachment: Full program for test case

Comment 3

[Phil Schwartau]

Marking FIXED.

I successfully compiled and ran Igor's test "Y.java".
I got this output:

[//c/WinNT/profiles/pschwartau/Desktop]
$ java -classpath "D:\JS_trunk\mozilla\js\rhino\build\rhino1_5R4pre\js.jar;." Y
function () {
        [native code, arity=0]
}

Comment 4

[Phil Schwartau]

Marking Verified -

Comment 5

[Phil Schwartau]

*** Bug 61579 has been marked as a duplicate of this bug. ***

Comment 6

[Phil Schwartau]

Just to double-check with Igor: was my output above correct?

function () {
        [native code, arity=0]
}

Comment 7

[Phil Schwartau]

OOPS!!! I had my directories mixed up, and was using an old Rhino tree.
The bug is indeed fixed. Now that I've updated the correct tree, we can
compare rhino1_5R3pre vs. rhino1_5R4pre:


[//c/WinNT/profiles/pschwartau/Desktop]
$ java -classpath "D:\JS_TRUNK\mozilla\js\rhino\build\rhino1_5R3pre\js.jar; ." Y
function () {
        [native code]
}


[//c/WinNT/profiles/pschwartau/Desktop]
$ java -classpath "D:\JS_TRUNK\mozilla\js\rhino\build\rhino1_5R4pre\js.jar; ." Y

    var x = 5;
    var y = 10;


And this shows the effect of the bug fix -

Comment 8

[Igor Bukanov]

Targeting as resolved against 1.5R4