1175550 - Add support for shared and service workers to the worker debugger.

Status: RESOLVED DUPLICATE of bug 1536902

(DevTools :: Debugger, defect, P2)

Description

[Eddy Bruel [:ejpbruel]]

Once bug 1171967 lands, we should have a prototype to debug dedicated workers for a tab. However, this prototype does not yet include support for shared workers. This bug will be about adding that functionality.

Comment 1

[Eddy Bruel [:ejpbruel]]

Attachment: Rename browser_dbg_listworkers.js to browser_dbg_TabActor.listWorkers.js.

First some ductwork. I'm planning to add some new tests, so I'm going to rename browser_dbg_listworker.js in order to fit those in.

Comment 2

[Eddy Bruel [:ejpbruel]]

Attachment: Implement RootActor.listWorkers

Extend the debugger protocol with a RootActor.listWorkers request. Unlike TabActor.listWorkers, which lists all dedicated workers associated with the corresponding tab, RootActor.listWorkers lists all workers that are not associated with any particular tab, including shared and service workers.

Comment 3

[Eddy Bruel [:ejpbruel]]

Attachment: Implement DebuggerView.SharedWorkers

This patch extends the workers panel in the debugger UI with a tab for shared workers. I've tried to reuse as much of the existing worker code as I could.

Comment 4

[Eddy Bruel [:ejpbruel]]

Marking this as P2. We can already debug service workers via about:debugging, and shared workers are arguably less important. That said, being able to debug the currently active service worker for a page from a toolbox will probably convenient.

Comment 5

[Jan Keromnes [:janx]]

(In reply to Eddy Bruel [:ejpbruel] from comment #4)
> Marking this as P2. We can already debug service workers via
> about:debugging, and shared workers are arguably less important. That said,
> being able to debug the currently active service worker for a page from a
> toolbox will probably convenient.

Agreed.

Also, I'm unblocking the meta-bug for Push DevTools for Dev. Edition 47, since this is more of a follow-up / general improvement.

Comment 6

[:Harald Kirschner :digitarald]

Continued in bug 1536902, as we have a new worker debugging panel in Debugger.