Closed Bug 118086 Opened 23 years ago Closed 23 years ago

Crash when calling printer properties - Trunk [@ ntdll.dll - nsPrinterEnumeratorWin::DisplayPropertiesDlg]

Categories

(Core :: Printing: Output, defect)

Product:
Core
Component:
Printing: Output
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.9

People

(Reporter: erik.fornoff, Assigned: rods)

References

Details

(Keywords: crash, topcrash)

Crash Data

Attachments

(3 files, 2 obsolete files)

purify stack info for an ABW in GlobalPrinters::GetDefaultPrinterName
2.62 KB, text/plain
Details
better patch
4.40 KB, patch
dcone
: review+
waterson
: superreview+
shaver
: approval+
Details | Diff | Splinter Review
Stack, buildID and incidentID for comment #37
3.67 KB, text/plain
Details 
Environment:
==============
OS: Win NT 4.0 SP-6
Mozilla BuildID:    2002010103



Summary:
=========
Mozilla crashes after return from printer properties dialog.

Reproducible: always


Steps to Reproduce:
====================

1) Start Mozilla

2) Click 'File' -> 'Print'

3) in dialog {Print} select 'Print to: Printer'

4) choose 'Properties' right next to your printer name

5) the configuration screen of your printer appears

6) modify some settings and close this dialog with [Ok] 



Actual Results:  
================
Mozilla crashes!



Expected Results:  
==================
Program executaion returns to Mozilla's {Print}-screen  without crash


Additional Information:
========================
- with Netscape 4.51 no crash occurs

- used printer: Ricoh Aficio270 PCL 5e (currently no driver version available)

- when calling printer properties from within composer I get an access violation
in NTDLL.DLL ( Talkback-ID: TB1220662Z )

- when calling printer properties from within browser I get an access violation
in WINSPOOL.DRV ( Talkback-ID: TB1220715Q )
Key: +crash   Sev: maj -> cri
Severity: major → critical
Keywords: crash
Asa, can you reproduce this? I cannot on 1/4 commercial trunk build on Win 98...

Reporter, please try again on latest build...thanks...
No crash with 2002010403 mozilla trunk build on win 2K
Erik, we cannot reprroduce the crash on mozilla or commercial build.

Please reinstall a newer build and try again...


Hi there,

I just installed 2002010608 and mozilla still crashes! 
Please note, that this is no local printer - it's a network-printer - perhaps
the problem deals with this fact?

Any other tips what I can try?
Build 2002010103, 2002010203 crash always too, but mozilla in ns6.2.1 (20011128)
won't crash on file->print->printer properties->ok. Platform: win2k. Printer:
network printer, hp.
Just tried another thing: selected both Acrobat Destiller and Acrobat PDF Writer
(which are installed as printers in our working environment) as printer and
clicked on properties -> [Ok] and I get _no_ crash - everything worked fine.
So it really seems somehow to deal with the network.

Unfortunately I cannot install a local printer here at work...
from Erik's talkback:
ntdll.dll + 0x1d66e (0x77f7d66e)
ntdll.dll + 0x4e17 (0x77f64e17)
MSVCRT.dll + 0x1434 (0x78001434)
nsPrinterEnumeratorWin::DisplayPropertiesDlg
[d:\builds\seamonkey\mozilla\gfx\src\windows\nsDeviceContextSpecWin.cpp, line 1330]
nsPrintOptions::DisplayJobProperties
[d:\builds\seamonkey\mozilla\gfx\src\nsPrintOptionsImpl.cpp, line 739]
XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp,
line 106]
XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp, line 2011]
XPC_WN_CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp,
line 1267]
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 834]
js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2799]
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 850]
js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 925]
JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3407]
nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line 1014]
nsJSEventListener::HandleEvent
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line 182]
nsEventListenerManager::HandleEventSubType
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line
1206]
nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line
2198]
nsXULElement::HandleDOMEvent
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3449]
PresShell::HandleDOMEventWithTarget
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 6110]
nsButtonBoxFrame::MouseClicked
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp, line 195]
nsButtonBoxFrame::HandleEvent
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp, line 142]
PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 6079]
PresShell::HandleEventWithTarget
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 6032]
nsEventStateManager::CheckForAndDispatchClick
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp, line 2465]
nsEventStateManager::PostHandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp, line 1548]
PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 6083]
PresShell::HandleEvent
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5987]
nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 387]
nsViewManager::DispatchEvent
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 1930]
HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 83]
nsWindow::DispatchEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 850]
nsWindow::DispatchWindowEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 867]
nsWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4443]
ChildWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4693]
nsWindow::ProcessMessage
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 3402]
nsWindow::WindowProc
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1112]
USER32.dll + 0x124c (0x77e7124c)

and

WINSPOOL.DRV + 0xdd7f (0x77c0dd7f)
WINSPOOL.DRV + 0x7a03 (0x77c07a03)
0x00740074 



Adding topcrash keyword and Trunk [@ ntdll.dll -
nsPrinterEnumeratorWin::DisplayPropertiesDlg] to summary...this is a topcrasher
with recent MozillaTrunk builds: 

Count   Offset    Real Signature
[ 8   ntdll.dll + 0x4b892 (0x77fcb892) 5d73d8b8 -
nsPrinterEnumeratorWin::DisplayPropertiesDlg ]
[ 2   ntdll.dll + 0x4b892 (0x784ab892) eb8d8f8a -
nsPrinterEnumeratorWin::DisplayPropertiesDlg ]
 
     Crash date range: 2002-01-02 to 2002-01-08
     Min/Max Seconds since last crash: 110 - 61456
     Min/Max Runtime: 320 - 106593
     Keyword List : print(4),  
     Count   Platform List 
     10   Windows NT 5.0 build 2195
 
     Count   Build Id List 
     4   2002010611
     2   2002010409
     2   2002010110
     1   2002010709
     1   2002010209
 
     No of Unique Users         8
 
 Stack trace(Frame) 

	 ntdll.dll + 0x4b892 (0x77fcb892)  
	 ntdll.dll + 0x4b733 (0x77fcb733)  
	 MSVCRT.DLL + 0x1d92 (0x78001d92)  
	 nsPrinterEnumeratorWin::DisplayPropertiesDlg
[d:\builds\seamonkey\mozilla\gfx\src\windows\nsDeviceContextSpecWin.cpp  line 1330] 
	 nsPrintOptions::DisplayJobProperties
[d:\builds\seamonkey\mozilla\gfx\src\nsPrintOptionsImpl.cpp  line 739] 
	 XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp 
line 106] 
	 XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp  line 2011] 
	 XPC_WN_CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp 
line 1267] 
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 834] 
	 js_Interpret
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 2799] 
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 850] 
	 js_InternalInvoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 925] 
	 JS_CallFunctionValue
[d:\builds\seamonkey\mozilla\js\src\jsapi.c  line 3407] 
	 nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp  line 1014] 
	 nsJSEventListener::HandleEvent
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp  line 182] 
	 nsEventListenerManager::HandleEventSubType
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
1206] 
	 nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
2198] 
	 nsXULElement::HandleDOMEvent
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp  line 3449] 
	 PresShell::HandleDOMEventWithTarget
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6110] 
	 nsButtonBoxFrame::MouseClicked
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp  line 195] 
	 nsButtonBoxFrame::HandleEvent
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp  line 142] 
	 PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6079] 
	 PresShell::HandleEventWithTarget
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6032] 
	 nsEventStateManager::CheckForAndDispatchClick
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp  line 2463] 
	 nsEventStateManager::PostHandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp  line 1546] 
	 PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6083] 
	 PresShell::HandleEvent
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 5987] 
	 nsView::HandleEvent
[d:\builds\seamonkey\mozilla\view\src\nsView.cpp  line 387] 
	 nsViewManager::DispatchEvent
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp  line 1930] 
	 HandleEvent
[d:\builds\seamonkey\mozilla\view\src\nsView.cpp  line 83] 
	 nsWindow::DispatchEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 851] 
	 nsWindow::DispatchWindowEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 868] 
	 nsWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 4480] 
	 ChildWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 4730] 
	 nsWindow::ProcessMessage
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 3404] 
	 nsWindow::WindowProc
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp  line 1113] 
	 USER32.DLL + 0x2e98 (0x77e12e98)  
	 USER32.DLL + 0x30e0 (0x77e130e0)  
	 USER32.DLL + 0x5824 (0x77e15824)  
	 nsWebShellWindow::ShowModal
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsWebShellWindow.cpp  line 1097] 
	 nsContentTreeOwner::ShowAsModal
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsContentTreeOwner.cpp  line 432] 
	 nsWindowWatcher::OpenWindowJS
[d:\builds\seamonkey\mozilla\embedding\components\windowwatcher\src\nsWindowWatcher.cpp
 line 700] 
	 nsWindowWatcher::OpenWindow
[d:\builds\seamonkey\mozilla\embedding\components\windowwatcher\src\nsWindowWatcher.cpp
 line 452] 
	 nsDeviceContextSpecWin::ShowXPPrintDialog
[d:\builds\seamonkey\mozilla\gfx\src\windows\nsDeviceContextSpecWin.cpp  line 1114] 
	 nsDeviceContextSpecWin::Init
[d:\builds\seamonkey\mozilla\gfx\src\windows\nsDeviceContextSpecWin.cpp  line 370] 
	 nsDeviceContextSpecFactoryWin::CreateDeviceContextSpec
[d:\builds\seamonkey\mozilla\gfx\src\windows\nsDeviceContextSpecFactoryW.cpp 
line 81] 
	 DocumentViewerImpl::Print
[d:\builds\seamonkey\mozilla\content\base\src\nsDocumentViewer.cpp  line 5249] 
	 GlobalWindowImpl::DoPrint
[d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp  line 1966] 
	 GlobalWindowImpl::Print
[d:\builds\seamonkey\mozilla\dom\src\base\nsGlobalWindow.cpp  line 1974] 
	 XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp 
line 106] 
	 XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp  line 2011] 
	 XPC_WN_CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp 
line 1267] 
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 834] 
	 js_Interpret
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 2799] 
	 js_Invoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 850] 
	 js_InternalInvoke
[d:\builds\seamonkey\mozilla\js\src\jsinterp.c  line 925] 
	 JS_CallFunctionValue
[d:\builds\seamonkey\mozilla\js\src\jsapi.c  line 3407] 
	 nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp  line 1014] 
	 nsJSEventListener::HandleEvent
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp  line 182] 
	 nsEventListenerManager::HandleEventSubType
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
1206] 
	 nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp  line
2198] 
	 nsXULElement::HandleDOMEvent
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp  line 3449] 
	 PresShell::HandleDOMEventWithTarget
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp  line 6110] 
	 nsMenuFrame::Execute
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuFrame.cpp  line 1624]  
 
     (1394061)	URL: www.nytimes.com
     (1394061)	Comments: attempting to print landscape
     (1393932)	URL: www.nytimes.com
     (1393932)	Comments: Attempting to set printer to landscape mode
     (1330814)	URL: www.corriere.it/gallerie
     (1330610)	URL: www.corriere.it/gallerie
     (1177377)	Comments: wanted to print  changed the printer's properties to 2-pages-on-1
and pressed OKinstead of returning to Mozilla's printing dialog  it crashed... :-(
     (1141829)	URL: http://t-online.t-online.de
     (1141829)	Comments: printing
Keywords: topcrash
Summary: Crash when calling printer properties → Crash when calling printer properties - Trunk [@ ntdll.dll - nsPrinterEnumeratorWin::DisplayPropertiesDlg]
On build 2002011103 on Win2k, it crashes for me.  If it helps, I am using a HP
932C printer that is hooked up via USB.

Also, very interesting also is that the Print Properties' settings are the
drivers defaults - not the defaults I set in the Printer Control Panel.
This bug might be related to bug 120440.
Confirming bug to New.  Here are some more user comments from Talkback:

(1923099)
Comments: printing 2 pages / sheet
     (1832826)	Comments: printing driving directions from mapquest.com  pressed ok after
changing the printer to double sided.
     (1650857)	Comments: closing out of the Print Properties
     (1611447)	Comments: I was in the printer dialogue box
(1855310)
URL: http://www.lemonde.fr
     (1855310)	Comments: I try to print !I do file/print/I modififie printer propertie then
click ok and then click on print of printer dialog box of mozillaThen Mozilla
crashIt is impossible to print with mozilla !!!
     (1785620)	Comments: I try to print !This pb arrive when I modifie printer
configuration before printing.
(1774685)
Comments: I was setting some printer properties while in a print dialog


There are A LOT of these crashes with recent MozillaTrunk builds....and bug
120440 does look like a dup.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I don't want to step on anyone's toes here, but I want to nominate this bug for
0.9.8. Adding mozilla0.9.8 keyword.

I think this bug is limited to Windows builds.
Keywords: mozilla0.9.8
I second that motion...this is a major topcrasher right now with MozillaTrunk
builds...and a fix would greatly improve the stability of M098.
Blocks: 115520
I am unable to reproduce the crash.

For 0.9.8 we can always turn the native print dialog back on and this would 
probably eliminate the crash.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
Attached patch patch (obsolete) — — Splinter Review 
THis fixes a free memory read and also turns on an ifdef that makes sure the
DEVMODE pointer has enough space for the new DEVMODE.
*** Bug 120440 has been marked as a duplicate of this bug. ***
I did a current build without debug and I set MOZ_PROFILE so I could get stack
trace and symbol info, but I can't get it to crash.
*** Bug 121372 has been marked as a duplicate of this bug. ***
In trying to reproduce the bug, not all print drivers are affected.

Using Windows 98SE, 0.9.7, Build ID: 2002012103, with two printers installed: a
"Lexmark Optra Ep" on LPT1, and a "Lexmark Optra R Plus Series PS" on FILE. When
I enter print properties on the Ep, I get no crash. When I enter print
properties on the R Plus Series PS, Mozilla crashes. See also bug 120440, a
duplicate of this bug.

My latest Talkback ID is TB2020714Y.

rods and asa:  I took a look at the Talkback data and ALL of these crashes were
reported on "Windows NT 5.0 build 2195", which is really Windows 2000.  So it
looks like a Win2K specific crash.
OS: Windows NT → Windows 2000
sorry but I disagree - the original bug appeared on Windows NT 4.0 SP-6 (see my
bug report above - I don't know why my talkback data seem to report Windows 2000
as operating system, but it is Windows NT 4 ;o)  ), so it seem not to be
restricted to Windows 2000... Additionally Andrew Hagen reported this on Win98 SE!

Further more (at least from the comments here in the bug report) the problem
seem only to occur on printers not connected directly to lpt1 - or did I miss a
thing? If so, then sorry for spamming...

unable to repro this with a MOZ_PROFILE build pulled from around Jan 17, running
on winnt 4.0 sp5.
My win2k Lexmark OptraR is directly connected to the parallel port, and crashes.

My crashes are all at Bugtoaster.com...
Sorry about that, I didn't look deep enough...Erik is correct.  The latest
Talkback data shows this crash happening with:

Windows NT  5.0 build 2195 (Windows 2000)
Windows NT  5.1 build 2600 (Windows XP, I believe)
Windows NT  4.0 build 1381

Those are just the OS versions for the "ntdll.dll" stack signature.

Andrew's Windows 98 incident shows a different stack signature (same crash though):
Incident ID 2020714   
Stack Signature  MapPaperSizeToNativeEnum 8ce0b1f6
Trigger Time 2002-01-23 10:38:50
Email Address xah@myrealbox.com
URL visited http://myhome.prodigy.net
User Comments Trying to enter print properties on Lexmark Optra R Plus Series
PS, Windows 98
Build ID 2002012109
Product ID MozillaTrunk
Platform
Operating System Win32
Module
Trigger Reason Access violation
Stack Trace
MapPaperSizeToNativeEnum
[d:\builds\seamonkey\mozilla\gfx\src\windows\nsDeviceContextSpecWin.cpp, line 234]
SetupDevModeFromSettings
[d:\builds\seamonkey\mozilla\gfx\src\windows\nsDeviceContextSpecWin.cpp, line 291]
nsPrinterEnumeratorWin::DisplayPropertiesDlg
[d:\builds\seamonkey\mozilla\gfx\src\windows\nsDeviceContextSpecWin.cpp, line 1324]
nsPrintOptions::DisplayJobProperties
[d:\builds\seamonkey\mozilla\gfx\src\nsPrintOptionsImpl.cpp, line 741]
XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp,
line 106]
XPCWrappedNative::CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp, line 2000]
XPC_WN_CallMethod
[d:\builds\seamonkey\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp,
line 1267]
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 834]
js_Interpret [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 2799]
js_Invoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 850]
js_InternalInvoke [d:\builds\seamonkey\mozilla\js\src\jsinterp.c, line 925]
JS_CallFunctionValue [d:\builds\seamonkey\mozilla\js\src\jsapi.c, line 3407]
nsJSContext::CallEventHandler
[d:\builds\seamonkey\mozilla\dom\src\base\nsJSEnvironment.cpp, line 1014]
nsJSEventListener::HandleEvent
[d:\builds\seamonkey\mozilla\dom\src\events\nsJSEventListener.cpp, line 182]
nsEventListenerManager::HandleEventSubType
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line
1206]
nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line
2198]
nsXULElement::HandleDOMEvent
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3359]
PresShell::HandleDOMEventWithTarget
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 6036]
nsButtonBoxFrame::MouseClicked
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp, line 195]
nsButtonBoxFrame::HandleEvent
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsButtonBoxFrame.cpp, line 142]
PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 6005]
PresShell::HandleEventWithTarget
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5956]
nsEventStateManager::CheckForAndDispatchClick
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp, line 2463]
nsEventStateManager::PostHandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventStateManager.cpp, line 1546]
PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 6009]
PresShell::HandleEvent
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5911]
nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 387]
nsViewManager::DispatchEvent
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 1909]
HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 83]
nsWindow::DispatchEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 854]
nsWindow::DispatchWindowEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 871]
nsWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4529]
ChildWindow::DispatchMouseEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 4779]
nsWindow::ProcessMessage
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 3453]
nsWindow::WindowProc
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1116]
KERNEL32.DLL + 0x363b (0xbff7363b)
KERNEL32.DLL + 0x24407 (0xbff94407)
0x006486da 
I ran Purify with a build pulled from trunk at 2am Jan23 (this morning). 
I get two occurences of an Array Bounds Write (ABW) when I do 'File->Print...'
filed bug 121524 for a related ABW doing Print Preview.
Here is what I know so far:

1) It happens a lot on network prints but also can occur on local printers 
   both parallel and USB printers
2) It happens on Win NT based machines and on Win98
3) Print Properties' settings are the drivers defaults,
   not the defaults set in the Printer Control Panel

I can't draw any conclusions yet.

Another interesting data point is that in nsDeviceContextSpecWin I have an ifdef
for calling AdvancedDocumentProperties or DocumentProperties. Currently the code
is calling DocumentProperties because when it call AdvancedDocumentProperties it
always crashes when I click "Cancel" but work everytime I hit "OK". 

I assume this is related, but I cannot figure out the Cancel crasher. I have
researched this problem in great length. It's especially strange because it
happens when I hit Cancel. Shouldn't cancel be a no-op?

See my comments about Purify in Bug 121524
Attached patch patch (obsolete) — — Splinter Review 
This patch fixes a free memory read and now uses a PL_strdup instead of
PL_strcpy, the arg to GetDefaultPrinter was SUPPOSE to create memory.
Attachment #66100 - Attachment is obsolete: true
Plus, I am now using the GetProfileString to get the default printer instead of
using the PrintDLG ni silent mode.
Attached patch better patch — — Splinter Review 
See comments for 66270
Attachment #66270 - Attachment is obsolete: true
Comment on attachment 66272 [details] [diff] [review]
better patch

r=dcone
Attachment #66272 - Flags: review+
Comment on attachment 66272 [details] [diff] [review]
better patch


>@@ -1306,8 +1303,8 @@
>       newDevMode->dmSize = sizeof(DEVMODE);
> 
>       // get the bytes need for the new DevMode
>-#if 0 // leave this ifdef'ed for now
>-      LONG bytesNeeded = DocumentProperties(NULL, hPrinter, nameCStr, newDevMode, lpDevMode, 0);
>+#if 1 // leave this ifdef'ed for now
>+      LONG bytesNeeded = ::DocumentProperties(NULL, hPrinter, (char*)NS_ConvertUCS2toUTF8(aPrinterName).get(), newDevMode, lpDevMode, 0);

Any reason not to just remove the `#if 0'? If not, nuke it.

sr=waterson
Attachment #66272 - Flags: superreview+
Yes, it is a good idea - removed.
Comment on attachment 66272 [details] [diff] [review]
better patch

a=shaver on behalf of drivers@mozilla.org for 0.9.8 branch landing.
Attachment #66272 - Flags: approval+
checked in on 0.9.8 branch and trunk - fixed
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Not sure I'm using the right build. Build ID 2002012503 still crashes for me in
Windows 98 when I select Lexmark Optra Plus Series PS and go into properties. My
crash has Talkback ID: TB2117696G. 

I noticed that page fault message changed. Here is the new message.

MOZILLA caused an invalid page fault in
module GKGFXWIN.DLL at 0177:6036ee95.
Registers:
EAX=00000000 CS=0177 EIP=6036ee95 EFLGS=00010256
EBX=05e173f0 SS=017f ESP=0064d384 EBP=0064d388
ECX=00000001 DS=017f ESI=00000000 FS=1a37
EDX=60373ff0 ES=017f EDI=0264edd0 GS=0000
Bytes at CS:EIP:
66 89 48 2e 8b 48 28 83 e1 f3 83 c9 02 89 48 28 
Stack dump:
00000000 0064d3cc 6036edf9 00000000 78000000 00000000 40210000 00000000 40260000
0000034c 00000000 00000000 40210000 00000000 40260000 780012d9 


Andrew, Talkback says your latest crash was on 2002012309 (before the fix was
checked in) and it ends at a differnt line in the code
(MapPaperSizeToNativeEnum). 
If you can download a more recent build and try to repro this crash we would
know if it is another issue or if this is indeed fixed. (stack attached)
Just generated a talkback using 2002012503 (what's with this build ID being in
the 2002-01-25-11-trunk directory??  I've noticed that the recent Win32 builds
all have a -03 suffix regardless of the build directory they appear in). 
Exactly the same problem: Mozilla crashes immediately.  Occurring under Win2K
SP2.  Note that I'm running as a restricted user, if that means anything.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Re: comment 38. That's weird. I downloaded mozilla-win32-installer-sea.exe from
ftp.mozilla.org, today. According to Win 98 command.com's "dir," it has a file
size of 10,013,920 bytes. The file has a date and time stamp of 01-25-02 at
11:54a (EST). I installed it. 

Then I generated the crash in comment 37. This crash was generated while using
my usual profile. When using that profile, I get nothing in Help | About
Mozilla. It just has the corporate logo and the copyright information in the bottom.

When using a fresh profile, my Help | About Mozilla says "Mozilla 0.9.7+
Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7+) Gecko/20020125."

Under either profile, the Build ID displayed in the title bar is 2002012503.

I generated two more crashes while using a fresh profile using the same method
as described in comment 37. Those Talkback ID's are TB2121004H and TB2120505Z.
It works on my Lekmark OptraR and win2k!
Keywords: mozilla0.9.8+
This is going to get futured when check in Bug 122530. We will be going back to
native dialogs and this problem doesn't happen with native dialogs.
Status: REOPENED → ASSIGNED
It is now crashing when printing period. It worked once, and then, even after a
restart crashed every time. Win2k, OptraR PS
Target Milestone: mozilla0.9.8 → mozilla0.9.9
0.9.8 will have XP XUL dialogs, but the trunk is now back to using native
dialogs so I am going to makr this won't fix.
see previous comment
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Eirk, is this fixed for you ? please verify....
Hi all,

yes - the problem doesn't occur any longer with #2002020908... 

cheers, erik
verified.
Status: RESOLVED → VERIFIED
Crash Signature: [@ ntdll.dll - nsPrinterEnumeratorWin::DisplayPropertiesDlg]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: