121524 - ABW: Doing 'File->Print Preview'

Status: VERIFIED WONTFIX

(Core :: Print Preview, defect)

Description

[John Morrison]

ABW: Doing 'File->Print Preview'

This is essentially the same ABW that was noted on bug 118086, but 
it is reached on a different code path. When I do 'File->Print Preview'
I get one ABW as described in this bug, and a second ABW which is the 
same as what is described in the Purify attachment to bug 118086.

You can DUP this bug if you want. I just didn't want to muddy the waters
for the top crash bug by adding more conditions to it.

Steps to Reproduce:
1) Start Mozilla and do 'File->Print Preview' (text or html; doesn't matter)

Actual Results: 
  [E] ABW: Array bounds write in WideCharToMultiByte {1 occurrence}
    - called from nsDeviceContextSpecWin::ShowNativePrintDialog
and
  [E] ABW: Array bounds write in WideCharToMultiByte {1 occurrence}
    - called from GlobalPrinters::GetDefaultPrinterName
      (this one is the one already reported in bug 118086)

See attached Purify details for the first ABW (ShowNativePrintDialog)

Comment 1

[John Morrison]

Attachment: ABW: in WideCharToMultiByte {1 occurrence} called from nsDeviceContextSpecWin::ShowNativePrintDialog

this is on of two ABW that shows up doing 'File->Print Preview'. The other 
is described in bug 118086

Comment 2

[rods (gone)]

From the Purify info I understand the the problem is heppening inside PrintDlg?
If so, that is a native Windows toolkit call. Not much I can do for that.

If not, please explain where it is happening.

Comment 3

[John Morrison]

I had presumed (ass-u-me-d) that this might have been occuring due to not 
allocating something in the struct that was to be passed to PrintDlg. But 
even sample code for PrintDlg seems to throw this ABW. So, I suppose (unless
anyone has a better idea), this may be (a) Purify is confused, or (b) a bug
in the version of the DLLs that I have on win2k.

Comment 4

[rods (gone)]

I changed how we get the default printer. So it is no longer using the PrintDlg
call. It does a GetProfileString, which gets it from the registry.

Plus, I checked in a fix for the Bug 118086, so this may be fixed now. I can
only hope.

Comment 5

[John Morrison]

With trunk bits pulled ~9pm PST Jan27, I don't get the purify error when 
bringing up the Print dialog (File->Print...). I do get this same ABW when 
I do 'File->Print Preview' since that code path still uses PrintDlg. 

Not sure what to do with this bug, or if the error is real.

Comment 6

[rods (gone)]

I'll mark this Won't Fix, because it is really "Can't FIX" I think the overwrite
is happen in the OS code.

Comment 7

[sujay]

verified.