1181944 - (Gaia RTL 2.5) Support RTL for System App

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Ahmed Nefzaoui [:Nefzaoui]]

RTL Support for the System App in Firefox OS 2.5

Comment 1

[Josh Cheng [:josh]]

Hi Loic, Hi Kaze,
Will RTL for system able to be review soon?
Thanks

Comment 2

[Loïc Cuguen]

(In reply to Josh Cheng [:josh] from comment #1)
> Hi Loic, Hi Kaze,
> Will RTL for system able to be review soon?
> Thanks

We are on it, the team is opening the bugs to push the shared component code asap, and we need that part before pushing any code on System app.

Plus we are on a bug with the rtl + taskswitcher. that should be tackle before pushing any code to you.

Comment 3

[Sam Foster [:sfoster] (he/him) out until 2024-05-26]

(In reply to Loïc Cuguen from comment #2)
> (In reply to Josh Cheng [:josh] from comment #1)
> > Hi Loic, Hi Kaze,
> > Will RTL for system able to be review soon?
> > Thanks
> 
> We are on it, the team is opening the bugs to push the shared component code
> asap, and we need that part before pushing any code on System app.
> 
> Plus we are on a bug with the rtl + taskswitcher. that should be tackle
> before pushing any code to you.

I thought we were going to land the CSS refactoring before diving into the RTL navigation stuff? For the task switcher, we should coordinate with :mcav as he has patches in-flight to add new sheet/window buttons and improve performance that will likely conflict.

Comment 4

[Loïc Cuguen]

css + rtl navigation in one PR per app with the associated shared components that is the plan we proposed last week.

easier for qa to test easier for reviewer to get a whole picture aswell.

Comment 5

[Sam Foster [:sfoster] (he/him) out until 2024-05-26]

(In reply to Loïc Cuguen from comment #4)
> css + rtl navigation in one PR per app with the associated shared components
> that is the plan we proposed last week.
> 
> easier for qa to test easier for reviewer to get a whole picture aswell.

Yeah I can see the sense in that, but it will make for a big PR for system at least. Lets see how it plays out - we can split the PR if necessary.

Comment 6

[BMO Automation]

Firefox OS is not being worked on