121381 - Remove unnecessary if block in sidebarOverlay.js

Status: RESOLVED WONTFIX

(SeaMonkey :: Sidebar, defect, P5)

Description

[Ben Bucksch (:BenB)]

Just before the block I will remove, there is:
        if (!panel.is_persistent()) {
          iframe.setAttribute('src', 'about:blank');
          load_state = content.getAttribute('loadstate');
          if (load_state == 'loading') {
            iframe.removeEventListener("load", panel_loader, true);
            content.setAttribute('hidden','true');
            iframe.setAttribute('loadstate', 'never loaded');
          }
        }
This does
          iframe.setAttribute('src', 'about:blank');
already, if !panel.is_persistent(). No need to check and do it again.

Comment 1

[Ben Bucksch (:BenB)]

Another example of dry-coding.

Will add patch (below) to bug 93651.

Can I have r/sr?

Index: sidebarOverlay.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/sidebar/resources/sidebarOverlay.js,v
retrieving revision 1.91
diff -u -r1.91 sidebarOverlay.js
--- sidebarOverlay.js	9 Jan 2002 02:07:59 -0000	1.91
+++ sidebarOverlay.js	23 Jan 2002 13:43:49 -0000
@@ -349,10 +349,6 @@
             iframe.setAttribute('loadstate', 'never loaded');
           }
         }
-        if (panel.is_sandboxed()) {
-          if (!panel.is_persistent())
-            iframe.setAttribute('src', 'about:blank');
-        }
       }
     }
   }

Comment 2

[Samir Gehani]

Looks innocuous to me.  Has this been tested thoroughly with chrome and web
tabs?  It is important that the ``What's Related'' tab is not loaded when not
open.  And that the ``Search'' tab is not building results when not open.  You
get the gist of it.  r=sgehani

Comment 3

[Ben Bucksch (:BenB)]

> Has this been tested thoroughly with

No. With "dry-coding", I mean that I didn't test at all. But logic dictates that
this code was redundant.

Comment 4

[sujay]

Ben please test fix thoroughly before checking in please....

Comment 5

[Vidar Haarr (not reading bugmail)]

This will be fixed as part of bug 93651.

Comment 6

[Ben Bucksch (:BenB)]

I'd be surprised, if that code  would still be alive, and even if so, I don't care.