93651 - Sidebar broken, if certain prefs not set

Status: RESOLVED WORKSFORME

(SeaMonkey :: Sidebar, defect)

Description

[Ben Bucksch (:BenB)]

If neither intl.content.langcode nor general.useragent.locale are sat, the
sidebar won't have any panels, and you can't get any.

That's mostly due to a bad exception handling in sidebarOverlay.js. We have
something like

var locale
try {
  locale = prefs.CopyCharPref("intl.content.langcode");
}
catch(ex) {
  debug ("error");
}
locale = locale.toLowerCase();

The last line will fail, because locale is not sat. |locale| must be set in the
catch block.
In this particular case, there are 2 nested try blocks, so I chose a longer
solution. Will attach patch.

Comment 1

[Ben Bucksch (:BenB)]

Attachment: Fix, version 1

Comment 2

[Ben Bucksch (:BenB)]

That was most dry-coding - I didn't test all cases I try to catch. It did fix
the problem for me, though.

Please review.

Comment 3

[Ben Bucksch (:BenB)]

-> me for tracking.

Comment 4

[Ben Bucksch (:BenB)]

matt, can you review?

Comment 5

[matt]

Great bug.   I this might be a bug that people in the international teams have
been seeing that i have never been able to reproduce.

Comment 6

[Ben Bucksch (:BenB)]

matt, was that a r=?

Comment 7

[Michele Carlson]

Is this bug still valid in Netscape 6.2?

Comment 8

[Samir Gehani]

Comment on attachment 44683 [details] [diff] [review]
Fix, version 1

r=sgehani

Comment 9

[Ben Bucksch (:BenB)]

Attachment: Fix, version 2. Updated to trunk. Contains fix for bug 121381.

Comment 10

[Vidar Haarr (not reading bugmail)]

if we are sure this is desired behavior, the patch looks good.
could anyone review it ?

Comment 11

[[not reading bugmail]]

need to ask [e-mail] for a review, thanks.  pretty standard
proceedure, if we got a patch needing review.

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

Ben, what's the current status of this patch? is it still needed, does it still
apply?

Comment 13

[Ben Bucksch (:BenB)]

Attachment: Fix, version 3.

Contains fix for bug 121381 again (should I mark it a dup?).

This is the version shipped with Beonex Communicator 0.8/0.9. That's all I can
say about the patch.

Comment 14

[Michael Gabriel]

HONK !

Comment 15

[Samir Gehani]

Comment on attachment 97394 [details] [diff] [review]
Fix, version 3.

This contains the fix for bug 121381 which has not been thoroughly tested for
web and *chrome* tabs.	Please attach a patch for just this bug.  In the future
please request reviews for sidebar from Shuehan ([e-mail]) since
she now works on sidebar.  Thanks.

Comment 16

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Ben, are you still working on this?  Does the bug still occur?

Comment 17

[Ben Bucksch (:BenB)]

-> default owner

Comment 18

[WADA:World Anti-bad-Duping Agency]

To bug opener, do you still see problem you state by bug summary?

Comment 19

[Ben Bucksch (:BenB)]

Please test yourself and stop asking that in all my bugs.

Comment 20

[Ben Bucksch (:BenB)]

Offending code no longer exists.
WORKSFORME