12924 - [DOGFOOD][FEATURE] support password authenticated news servers

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

and leverage mscott's GetPassword() work in nsMsgIncomingServer().

Comment 1

[(not reading, please use [e-mail] instead)]

accepting, adding a dependency, marking m11

Comment 2

[Phil Peterson]

Triage to M15

Comment 3

[Scott MacGregor]

Shaver's taking a look at implementing this for us today. Thank you shaver!

Comment 4

[(not reading, please use [e-mail] instead)]

marking dogfood.

Comment 5

[daver]

We don't think is is needed for CPD dogfood.  Feel free to educate PDT on why
it's needed?

Comment 6

[Mike Shaver (:shaver emeritus)]

I need it for _my_ dogfood, along with @-in-username, so I'm doing it.  I also
think that solving NNTP auth will make it easier for Alec to define a good
auth-data mechanism that can be shared by all of mailnews, but that's a separate
argument.  I'm told that piles of ISPs use authentication to protect their news
servers as well, but don't have personal experience with more than one or two.

Anyway, it's pretty much fait accompli: I'll send patches to seth/alec for
review when I fix the RDF-URI-escaping bug.

Comment 7

[lchiang]

Will this make it into M11?  If not, pls change the target milestone to M12 so
this bug doesn't show up on the M11 stopper list. Thanks

Comment 8

[chris hofmann]

m12

Comment 9

[Mike Shaver (:shaver emeritus)]

I'm going to restart work on this soon, now that alecf has tweaked the generic
authentication code.

No, really.  (I'll even leave it M12, to add to the excitement!)

Comment 10

[Mike Shaver (:shaver emeritus)]

I suck. =(

Comment 11

[lchiang]

*** Bug 22087 has been marked as a duplicate of this bug. ***

Comment 12

[Mike Shaver (:shaver emeritus)]

OK, I've started to reconstitute my patches, now that alecf has made the world a
happier place for authentication, but it'll be close for M13.  alecf/seth, if
you can answer questions and stuff in IRC, it'll make life easier.

Comment 13

[Mike Shaver (:shaver emeritus)]

Missed it.  M14 should be cake, but then, M13 should have been cake. =/

Comment 14

[(not reading, please use [e-mail] instead)]

taking this from mike, he's overloaded.

I got the fix in my tree.  checking in early m14.

Comment 15

[(not reading, please use [e-mail] instead)]

authenticated news is working.  there are a few features left, and I'll log
those as bugs now.

right now, the username / password is cached on a per folder basis for the
session.

Comment 16

[(not reading, please use [e-mail] instead)]

reopening, I'm having a lot of problems with auth news in today's build.
(bug I thought I fixed are not fixed.)

re-opening until it is ready for testing.

rats.

Comment 17

[leger]

Clearing FIXED resolution due to reopen.

Comment 18

[Phil Peterson]

Will leave this alone for a couple of days, but will push beyond B1 if it gets
close.

Comment 19

[(not reading, please use [e-mail] instead)]

I believe this to be fixed, except that we don't use single signon yet, but we
will.

phil (or someone) can you try news://poisonivy/xrated with (u=olive,p=popeye)
and see if it works for you on windows?  it works for me on linux.

Comment 20

[Karen Huang]

I am going to try that!!

Comment 21

[Karen Huang]

Yes. It works for me on the WinNT new profile for today's 1-28-09-M14 commercial 
build. I may need to try Mac later.

Comment 22

[Karen Huang]

There was bug#25904 logged for Mac only...need to wait for bug#25904 fixed in 
order to verify this bug.

Comment 23

[Karen Huang]

I am still waiting for the Mac to verify this bug since it has been blocked by 
bug#26308....

Comment 24

[Karen Huang]

Seth, does the password authenticated dialog suppose to display one time or two 
times? It seems it is displaying two times now... the first time is when I am 
selecting the newsgroup after subscribe, the second time is when you selecting 
for viewing/reading newsgroup msg, is that right?
I remember it used to display one time only, and it displayed just after you 
select that newsgroup (xrated), can you tell me which way it suppose to work?

Comment 25

[(not reading, please use [e-mail] instead)]

it works for me.  here is what I am seeing

for news://poisonivy/xrated

start up, select the xrated newsgroup on poisonivy

get the news username dialog, enter olive (check remember checkbox)

if this is the first time I've used wallet, I get the wallet password dialog,
enter my wallet key twice.

get the news password dialog, enter popeye (check remember checkbox)

click on a message, it displays, no more prompts.

Comment 26

[(not reading, please use [e-mail] instead)]

then, if I exit and start up, and try to read a message in xrated, I should only
get one prompt, the wallet database password prompt

Comment 27

[laurel]

It is indeed behaving differently than 4.x in that it will ask for user/password
when downloading headers and again when trying to read a new message.  (I am not
using remember password).

I'm sure these and other issues would be spinoffs as separate bugs.

Comment 28

[(not reading, please use [e-mail] instead)]

with 4.x, we had some tricks for remembering your password per session and we
always remembered your password per session, once you logged on.  but as soon as
you quit, and came back, you had to log in again.)  

in 5.0, we currently have two states:

1) rememeber my username / password in the current session and across sessions
2) never remember my password, even in the same session

it sounds like we need that to be:

1) remember my username / password in the current session and across sessions
2) remember my username / password in the current session, but not across
sessions.

I think this is what imap / and pop does.

I'll log that as a new bug against me.

Comment 29

[Karen Huang]

Since Seth logged another bug#27726...
Marking as verified for this bug since it is working for all the platforms for 
this specific newsgroup(news://poisonivy/xrated) now....