132557 - input[type="file"] button should show tab focus

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[James Lariviere]

This is spun off from bug 52815.

After the fix for bug 52815, the file input no longer shows a dotted border
focus for its botton like a submit button does.

See attachment 17693 [details] for a testcase.

Current rendering (winXP build 3-20-2002):

After the second tab, the file button shows no form of focus.  I tabbed again in
the testcase, I could see that the submit button now had focus.  There is no
indication that the file button ever had focus.

Expected results:

On the 2nd tab through the file input, button should show a dotted border inside
the button that is the same as a submit button (show focus so I know I can hit
enter to trigger a browse window to open).

Comment 1

[James Lariviere]

Adding Pete Zha to cc: list because in bug 52815 the instruction was given file
this new bug.

Pete are you grabbing this one?

Comment 2

[James Lariviere]

One other quick comment.

On the 2nd tab, the current rendering still shows a blinking cursor in the text
input part of the file input.  It leads someone (me) to think that the text
input still has focus.  On the 2nd tab there should be no blink in the text
input and only show the dotted border in the button. :-)

Comment 3

[Pete Zha]

OK, I will take this. :-)

Comment 4

[Pete Zha]

Attachment: patch

forms.css forget to define the focus border of fileControl's button
need r= 
thanks

Comment 5

[Pete Zha]

Attachment: patch(remove "{")

Ignore last one.

Comment 6

[John Keiser (jkeiser)]

Comment on attachment 76707 [details] [diff] [review]
patch(remove "{")

r=jkeiser

Comment 7

[Pete Zha]

jst: please give me sr= if you have time
Thanks:-)

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 76707 [details] [diff] [review]
patch(remove "{")

sr=jst

Comment 9

[Pete Zha]

asa: Please give me approval to check in it. Thanks

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 76707 [details] [diff] [review]
patch(remove "{")

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[Aaron Leventhal]

fix checked in

Comment 12

[James Lariviere]

verf fixed win/linux build 04-01 build.

Comment 13

[michael wendell]

I am still seeing this problem in the 04-09 trunk.

I am reopening this bug.

Comment 14

[Pete Zha]

Michael, You mean you can't see the focus border on file control's "Browse..."?
But it works for me on trunk_0409...

Comment 15

[James Lariviere]

Attachment: WinXP 04-10-2002 03 — screenshot

What OS are you running? Under XP this is fixed see this screenshot.  I'll
check linux but I swear I checked it out when I verified...

Comment 16

[michael wendell]

Sorry I didn't responded earlier. 

Yes, that is what I meant.  But I am not seeing the problem anymore.  I must
have done something wrong.  This is working now, except that the focus appears
to remain on the browse button after you tab away from it.

I am going to re-resolve this fixed, and I filed bug 141310 for the new issue.

Comment 17

[James Lariviere]

Something caused the focus to continue to display eventhough it no longer has
focus.  As michael said the regression is now bug 141310.  I'll add Pete to the
cc list to see if its a quick regression fix.

Verf.

Comment 18

[Pete Zha]

->myself for tracking

Comment 19

[michael wendell]

I am seeing this bug again on the 08-15 1.0 builds on Mac and Win.  

I am reopening this bug.

Comment 20

[Aaron Leventhal]

This is solved by my patch in bug 176100.

Comment 21

[Aaron Leventhal]

i've got a fix for this.

Comment 22

[Aaron Leventhal]

fix checked in, as part of fix for bug 176100.