141310 - input[type="file"] button should release tab focus

Status: VERIFIED WORKSFORME

(Core :: Layout: Form Controls, defect, P1)

Description

[michael wendell]

See attachment 17693 [details] for a testcase.

If you tab through the testcase, the "Browse..." button recieves focus, but if
you continue to tab through the testcase, the "Browse..." button still appears
to have focus.

Steps to reproduce:
1. Load the testcase in a browser window
2. Hit the tab key 3 times until the "Browse..." button has visual focus
3. Hit the tab key one more time

Actual results:
Both the "Browse..." and "Submit Query" buttons appear to have focus.

Expected results:
I would expect that only the "Submit Query" button appear to have focus.

This was originally found as part of bug 132557.

Comment 1

[James Lariviere]

I still swear that the unreleased focus is a regression but can't find a nightly
to prove it.

Since Pete was the one to add the tab :focus event, I'd suggest that this be
assigned to him not rod.  Cc him.  Sorry Pete if I'm mistaken.

Comment 2

[Brian Ryner (not reading)]

I'm not seeing this -- in fact, I see no focus indication on the Browse button,
ever.

Comment 3

[michael wendell]

Brian, what OS and build are you on?  

I am seeing the no focus on tab on Mac OS9.2 with the 05-12 7.0PR1 build.

Comment 4

[Pete Zha]

I can see this problem.
The border of the Browse button will not disappear when it lost the focus.

Comment 5

[rods (gone)]

-->

Comment 6

[Aaron Leventhal]

This is solved by my patch in bug 176100.

Comment 7

[Aaron Leventhal]

have a fix

Comment 8

[Aaron Leventhal]

fix checked in, as part of fix for bug 176100.

Comment 9

[Prashant Desale]

Reopening this bug.

When you have disabled "File Input" after regular one, then "Browse" button DOES
NOT release Tab focus.

Note: reverse Tab navigation with Shift/Tab keys works perfect.
Regular Tab navigation with Tab key just stops at "Browse" button.

Attaching a testcase.

Comment 10

[Prashant Desale]

Attachment: New Testcase

Steps to reproduce:
1. Load the testcase in a browser window
2. Hit the tab key until the first "Browse..." button has visual focus
3. Hit the tab key any number of times.

Actual results:
Nothing happens.

Expected results:
Next "File Input" is disabled hence URL bar should get focus.

Comment 11

[Madhur Bhatia]

this is working fine on 1.4 final branch build on the linux platform.

Comment 12

[John Keiser (jkeiser)]

WFM on Windows Firebird 20030611 too.  Prashant, does it work for you?

Comment 13

[Boris Zbarsky [:bzbarsky]]

Worksforme too (today's trunk build); marking so.

Comment 14

[michael wendell]

Verified on moz 1.6 and firebird 0.7.