Closed Bug 134853 Opened 22 years ago Closed 22 years ago

Bookmark groups displayed as folders within personal toolbar (nested)

Categories

(SeaMonkey :: Bookmarks & History, defect)

Product:
SeaMonkey
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: david, Assigned: bugs)

References

Details

(Keywords: polish, Whiteboard: [Need Impact] [Needs a= for 1.0 branch] [ETA 05/31])

Attachments

(2 files)

Image showing bookmark groups as nested folders
11.55 KB, image/gif
Details
Proposed Patch
1001 bytes, patch
bugs
: review+
alecf
: superreview+
jud
: approval+
Details | Diff | Splinter Review 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:0.9.9+) Gecko/20020401
BuildID:    2002040103

A group of pages in tabs can be saved as one bookmark through Bookmarks>File
(tick file as "group"). This works great in the bookmarks  dropdown heirarchy,
bookmarks sidebar and the top level of personal toolbar, but when the group is
put in a folder within personal toolbar, it is shown as another directory.

Reproducible: Always
Steps to Reproduce:
1. Open several tabs.
2. Go Bookmarks>File.
3. Tick "File as group".
4. Add to a folder within personal toolbar, e.g.:
   - Personal Toolbar Folder
       > News   <-- here -->
          - Bookmark group

5. Try it.

Actual Results:  Bookmark group shown as a nested folder

Expected Results:  Bookmark group shown as a bookmark group.

Component set as bookmarks, may have something to do with tabs, but don't think
so...

Will attach a screenshot for clarity.
Blocks: bm-group-tracker
Confirming, and ->All/All, since I see it on Linux.  This breaks the only place
I would ever use (and want to use) bookmark groups.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows NT → All
Hardware: PC → All
Keywords: patch, polish, review, ui
Comment on attachment 78172 [details] [diff] [review]
Proposed Patch

sr=alecf
Attachment #78172 - Flags: superreview+
Fix was checked in by timeless.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
*** Bug 139137 has been marked as a duplicate of this bug. ***
*** Bug 140292 has been marked as a duplicate of this bug. ***
Nominating to get this into the branch post-beta.
Keywords: nsbeta1
Nominating for adt to take this on the branch (mail must be sent to drivers as
well).
Keywords: nsbeta1 → adt1.0.0
Blocks: 143047
Keywords: approval
Whiteboard: [Need Impact] [Needs a= for 1.0 branch]
claudius - Can you verify this one, and make sure there are no regressions
associated with the checkin?
*** Bug 143811 has been marked as a duplicate of this bug. ***
Please get an nsbeta1+ from the nav-triage team before seeking ADT approval.
*** Bug 137194 has been marked as a duplicate of this bug. ***
Removing adt1.0.0 noimination, as this has not been nsbeta1+, nor given an ADT
impact by the Nav triage team. Pls work with the Nav Triage team to get this
plussed, and approved for submission to the 1.0 branch. thanks!
Keywords: adt1.0.0 → nsbeta1
Whiteboard: [Need Impact] [Needs a= for 1.0 branch] → [Need Impact] [Needs a= for 1.0 branch] [ETA 05/31]
*** Bug 146744 has been marked as a duplicate of this bug. ***
*** Bug 149491 has been marked as a duplicate of this bug. ***
not sure if this regressed or was just never fixed. Reopening as the bug as
originally described is still in evidence in branch and trunk builds as of
20020611 on all platforms.

note the key here is we're looking at BG's that are nested in a folder that is
itself on/in the Personal Toolbar Folder.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Bookmark groups displayed as folders within personal toolbar → Bookmark groups displayed as folders within personal toolbar (nested)
*** Bug 146706 has been marked as a duplicate of this bug. ***
This wfm on the branch 06/12 the personal toolbar. There are still some problem
with the copy function (bug 144238)
Thought, neil's patch has never ben checked into the branch. I think it should
be nominated.
Nav triage team: nsbeta1-
Keywords: nsbeta1 → nsbeta1-
Doesn't work for me on a current branch Linux build.
I'm going to request approval for this patch for 1.0.1, since this bug really
annoys me...
Keywords: mozilla1.0.1
This is certainly fixed for me on current trunk builds.  Marking fixed again. 
(It shouldn't yet be fixed on the branch.)
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Attachment #78172 - Flags: approval+
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.
Keywords: mozilla1.0.1 → mozilla1.0.1+
VERIFIED Fixed on 20020626 trunk builds
Status: RESOLVED → VERIFIED
VERIFIED Fixed on 20020626 branch builds, marking verified1.0.1.
Keywords: fixed1.0.1 → verified1.0.1
*** Bug 165426 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: