Closed Bug 145807 Opened 22 years ago Closed 22 years ago

Implement External Protocol Support

Categories

(Camino Graveyard :: Drag & Drop, defect)

Product:
Camino Graveyard
Component:
Drag & Drop
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: winnie, Assigned: sdagley)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch to back out front end hack for dispatching protocols
1.41 KB, patch
Details | Diff | Splinter Review 
Implement External Protocol Support.
Blocks: 145820
QA Contact: petersen → winnie
*** Bug 147717 has been marked as a duplicate of this bug. ***
*** Bug 150858 has been marked as a duplicate of this bug. ***
I might be good too look at:

http://www.mozilla.org/quality/networking/testing/coretests.html

I've got a couple other lists of URL that I want to turn into tests, the top
section is a good working list.

Most notably not working: mailto:, aim:, and telnet.

*** Bug 151046 has been marked as a duplicate of this bug. ***
As an FYI for folks that haven't been involved in discussions on this, as part
of this work the nsInternetConfigService is being relocated from appshell to
uriloader.  Which happens to be something Embedding has been asking for for a while.
Added dependency on bug #152231 which is the bug for moving
nsInternetConfigService from appshell to uriloader
Depends on: 152231
Well I'm beating my head against the wall for a 'real' fix so here's a hack in
the meantime.  Credit to Dominik Westner for the original idea in bug #150858
pink/bryner - I attached the patch for the rather hacky method of dispatching
external protocols so we can get it into the next milestone build
*** Bug 152499 has been marked as a duplicate of this bug. ***
Keywords: patch
-> pinkerton to land the hack patch.  re-assign to sdagley after hack landed for
eventual 'proper' fix
Assignee: sdagley → pinkerton
hack of ages checked in. ick ick ick ick. this better be backed out when conrad
lands his changes.
Assignee: pinkerton → sdagley
Confirming mailto: links are functional in NB 2002-06-21-05. Clicking mailto:
link launches default mail app and opens a new window with correct email
address. Tested with Mail.app.
Also confirmed mailto working using Chimera/20020621 and Mozilla MailNews.

Oddly, the gopher test works, but duplicates the access in OmniWeb.
gopher was always handled inline, in fact there were some bugs filed against it.

Handling gopher inline is okay, but then gopher links shouldn't launch OmniWeb
and also display there.
Per pink's comment #11, now that Conrad's file rewrite code has been checked in
(bug 145804), do we need to revisit this patch?
We'll the current patch is much less skanky than the one checked in last week. 
The 'true' fix still relies on 152231 which Conrad and I discovered last week
isn't quite ready for prime time due to some dependency issues with moving the
InternetConfig service into uriloader.
July 1st.
maito: and aim: seem to work now
What is probably needed is a list of URL schemes that must work or stop ship...

I've made a Chimerea-only branch of my testcases. I suggest that we keep this
list here:

http://www.mozilla.org/quality/networking/testing/results/chimera0.3/coretests.html
Comment on attachment 88013 [details] [diff] [review]
Hack to dispatch unknown protocols from the Chimera FE

Actually this patch was obsoleted by the fix in bug 154538 which basically asks
Necko if it can handle a protocol before dispatching it externally.  This bug
is still open because that determination is supposed to happen in the backend
code.
Attachment #88013 - Attachment is obsolete: true
Blocks: 147975
The back end code _does_ now dispatch external protocols so the hack in the
front end should be removed.  This patch does that.
Comment on attachment 95212 [details] [diff] [review]
Patch to back out front end hack for dispatching protocols

r=sfraser

Please state how QA can verify this bug once fixed.
Attachment #95212 - Flags: review+
The only verification I can think of is testing mailto: and news: links once
this lands to verify they still work (that's what I did).

Speaking of landing, who's gonna check this in for me?
Component: General → Drag & Drop
done
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Verified in the 2002-08-21-05 NB.
Status: RESOLVED → VERIFIED
note: in Mac OS X, iChat does not seem to be registered as the AIM URL handler.
I installed AIM for Mac OS X, and then aim: URL's work. Please see bug 167116.
No longer blocks: 147975
Mailtos are busted in Build ID: 2002092304 on my TiBook running 10.1.5.
spun off bug 170586 for the mailto: issue.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: