154932 - Mozilla will not start on MacOS 8.6 if filesharing is on

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Joe Francis]

First reported in bug 4201, quoted below:

------ Additional Comment #39 From Bob Reite  2002-06-24 23:41 -------

Ver 1.1a will hang on startup on my machine (Biege G3, >50meg unused memory) if
file sharing is enabled.  Disable file sharing and this bug goes away.


------- Additional Comment #40 From Bob Reite 2002-06-24 23:43 -------

Followup to #39.  OS is 8.6

Comment 1

[Joe Francis]

Attachment: patch for nsDirectoryService.cpp

Fixing how we create the FSSpec for the mozilla application directory.

Comment 2

[Joe Francis]

keyword soup.  This is an easy fix that lets us work on macos 8.6 again.  Do we
want it for the branch?

Comment 3

[Kevin McCluskey (gone)]

nsbeta1+

Comment 4

[Conrad Carlen (not reading bugmail)]

Comment on attachment 89659 [details] [diff] [review]
patch for nsDirectoryService.cpp

>+        // create an FSSpec from the volume and dirid of the app.
>+        FSSpec appFSSpec;
>+        ::FSMakeFSSpec(pInfo.processAppSpec->vRefNum, pInfo.processAppSpec->parID, 0, &appFSSpec);
>         

That's the way it should be done. r=ccarlen
Nit - I'd rather you use nsnull instead of 0 as the 3rd param to FSMakeFSSpec.

Comment 5

[Joe Francis]

Kevin asked me to assess risks.  The only thing that can go wrong is that the 
fsspec call fails.  If that happens at this point in the app, you're screwed.  I 
didn't bother to check for the error because there was little point.  As a 
practical matter it should never happen unless someone has a horked machine that 
needs rebooting anyway.  

Number of users affected will be a lot.  It happens whenever filesharing is on, 
and a lot of users run with filesharing on with 8.6.  If I had to guess I'd say 
1/3rd of the 8.6 users, but that's just a guess.

I should point out that there is a bug 143543 that also affects 8.6.  sfraser has 
looked t that one.  You may want to only take this one if you can get a fix for 
that one as well.

Comment 6

[Jaime Rodriguez, Jr.]

pls get sr= before nominating for adt1.0.1. thanks!

is this bug dependent on bug 143543, or is it just a suggestion that we take the
other bug (if fixed)?

Comment 7

[scottputterman]

We're currently looking into the feasibility of fixing 143543.  Can you proceed
with the reviews?

Comment 8

[Kevin Daniels]

*** Bug 156208 has been marked as a duplicate of this bug. ***

Comment 9

[Joe Francis]

Comment on attachment 89659 [details] [diff] [review]
patch for nsDirectoryService.cpp

sr=sfraser (on joe's machine)

Comment 10

[Joe Francis]

sorry for delays here: bug owner was on vacation til now.

Comment 11

[Jaime Rodriguez, Jr.]

pls check this into the trunk asap. who can QA this one? scc is a driver, not
QA, right?

Comment 12

[Paul Wyskoczka]

addimg sarah for qa

Comment 13

[sairuh (rarely reading bugmail)]

i'll check this later on today in the lab...

Comment 14

[sairuh (rarely reading bugmail)]

i guess this has not yet been checked into the trunk, since the 2002.07.15.08
comm trunk bits still crash on launch (when file sharing is on).

Comment 15

[Paul Wyskoczka]

This fix has been checked into trunk on 7/15.  Sarah, this is ready to verify on
the trunk

Comment 16

[sairuh (rarely reading bugmail)]

still no go using 2002.07.16.08 trunk comm bits on OS 8.6.

either this has still not been checked in (i don't think i see checkins to this
effect by jfrancis or other macdev folx in the last 12-18hrs), or if it was,
it's still broken.

Comment 17

[sairuh (rarely reading bugmail)]

looked at the tboxen again, and noticed that this was actually checked in on the
branch (20:31 yesterday), not on the trunk.

i'll grab a branch build and test there in a bit...

Comment 18

[sairuh (rarely reading bugmail)]

looks good --verified fixed on the branch using 2002.07.16.05-1.0 (comm branch)
bits on OS 8.6. tested with both file sharing ON and OFF.

could we check this into the trunk, please? thanks!

Comment 19

[Joe Francis]

what drugs was i on and can i please have some more?

I have landed on trunk now.  I never had permisiion to go on branch.  I'll leave
it there though unless asked to remove it.

Comment 20

[Paul Wyskoczka]

Marking adt1.0.1+.  Checked into the branch by mistake.

Comment 21

[sairuh (rarely reading bugmail)]

vrfy'd fixed on the TRUNK, using 2002.07.17.08 (trunk) commercial bits on OS 8.6.

Comment 22

[Greg K.]

*** Bug 143454 has been marked as a duplicate of this bug. ***