179736 - References: headers with Horizontal TABs are leading to wrong threading

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Jun MUTO]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3a) Gecko/20021112
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3a) Gecko/20021112

References: headers with horizontal tabs (ex. folded references: 
headers) in messages are leading to wrong threading.

Patch from bug 167305 saw cr, lf and space characters, but it missed 
tab character.


Reproducible: Always

Steps to Reproduce:
[mail a]
Message-ID: <msg-id-a>

[mail b]
Message-ID: <msg-id-b>
References: <msg-id-a>

[mail c]
Message-ID: <msg-id-c>
References: <msg-id-a>
	<msg-id-b>

(mail c's references: header is folded with "cr lf tab.")

Actual Results:  
threaded view:
  [mail a]
   +- [mail b]
   +- [mail c]


Expected Results:  
threaded view:
  [mail a]
   +- [mail b]
       +- [mail c]

Comment 1

[David :Bienvenu]

Attachment: proposed fix

add check for tab. I tried to use nsCRT::TAB, but it doesn't compile!

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 105972 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 3

[David :Bienvenu]

fix checked in - thx for diagnosing the problem!

Comment 4

[Koike Kazuhiko]

I think you should use nsCRT::TAB instead of "\t".

Comment 5

[David :Bienvenu]

I tried that, as I said before. It didn't compile. And since there are no
instances of it in the whole mozilla tree, I suspect I'm not the only person for
whom it didn't compile.

Comment 6

[Jun MUTO]

This bug and bug 167305 are reproduced on 1.0 branch also. (tested 
2002-11-12-13-1.0 nightly build)
Can these fixes come into 1.0 branch?

Comment 7

[David :Bienvenu]

I don't know what the policy for getting this kind of thing into the 1.0 branch
is. I can see about getting it into the 1.2 branch, and ask about the 1.0 branch.

Comment 8

[Jun MUTO]

Thank you, bienvenu.
May I ask you to do it?

Comment 9

[David :Bienvenu]

I've asked about both - I was told it wouldn't be allowed into the 1.0 branch,
and I'm still waiting to hear about the 1.2 branch.

Comment 10

[Jun MUTO]

Now I've verified this bug was fixed on 2002-11-13-08-trunk nightly 
build, Windows98SE.
To refresh .msf file, though, it is necessary to run "conpact folders" 
after moved each latest mail in folders to anothor and back.
(I don't know more easy way to refresh.)

Comment 11

[Christopher Blizzard (:blizzard)]

Comment on attachment 105972 [details] [diff] [review]
proposed fix

a=blizzard on behalf of drivers for 1.2

Comment 12

[Christopher Blizzard (:blizzard)]

This has been checked into the 1.2 branch.