180029 - running junk mail controls manually should respect preferences-Move to Junk folder

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[(not reading, please use [e-mail] instead)]

from granrose:

"I run "Run Junk Controls on selected messages" that it marks spams as junk, but
it doesn't move them to my junk folder even though I have that pref set."

Comment 1

[Andrew Perry]

I wasn't aware that junkmail.js had included the lines for MOVING to be allowed
yet ... But, I fully agree that "running junk mail controls" should apply ALL
settings (Move, Priority Change, or whatever other features are incorporated
into the Junk Mail UI)

Comment 2

[(not reading, please use [e-mail] instead)]

*** Bug 188950 has been marked as a duplicate of this bug. ***

Comment 3

[(not reading, please use [e-mail] instead)]

taking

Comment 4

[jglick]

>I fully agree that "running junk mail controls" should apply ALL settings 

I agree as well.

Comment 5

[Samir Gehani]

Mail triage team: nsbeta1+/adt2

Comment 6

[Peter Lairo]

related/equal to bug 194273?

Comment 7

[(not reading, please use [e-mail] instead)]

I'm not so sure about this anymore.

think about whitelisting and local folders (which don't have jmc controls).

Comment 8

[jglick]

If users specifically ask for JMCs to be run, I think they expect it to obey
their settings. 

For Local (non acct) folders, we can either disable the menu item or identify
only (since there is no pref to auto move them).

If a Sender is in a user's AB, we still need to follow the settings the user has
setup. If  the user has "Msgs from people in my AB are not junk" enabled, we
need to obey that. This shouldn't be any different than auto analyzing msgs on
incoming mail.

Comment 9

[Jon Granrose]

right.  you have to assume that if someone is running the JMC manually that they
want to do that.  For Local Folders people can do the manual JMC and move the
marked messages by hand if they have to, or we just disable it since only msgs
that people want to save get put into the Local Folders (right?).

Comment 10

[(not reading, please use [e-mail] instead)]

see also bug #191042, which needs to be fix for manual running of jmc to be
usable on imap.

Comment 11

[esther]

I to test with a current build to see which preferences are being respected and
which are not when running JMC on IMAP or POP Folders. 
I think it' already respecting the Address book preference, still checking all
scenarios.
It's not automatically moving the message after analyzing.
Regarding Comment 8 paragraph 2, I just logged a bug 204517, for purge (which is
one of the preferences) to work on a designated Junk in Local Folders so we need
to be careful not to disable functionality for that. 

Comment 12

[esther]

Running junk mail controls does not respect the Address Book whitelist. 
splitting that out to a new bug so it can be fixed first. bug 204679

Comment 13

[esther]

updated this bug to be specific to moving to junk folder after manually marking
messages as junk or after running JMC on folder.   

Comment 14

[(not reading, please use [e-mail] instead)]

aiming for 1.4 final

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: patch

re-use the existing code for this, in nsMsgDBView.cpp

testing now, to see if it has a problem with moving / deleting messages that
aren't selected.

Comment 16

[(not reading, please use [e-mail] instead)]

hmm, this isn't the right approach.

that will heed the "move / delete" on manual code.

I think this has to work differently.

re-working....

Comment 17

[(not reading, please use [e-mail] instead)]

Attachment: new approach

Comment 18

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

Comment 19

[(not reading, please use [e-mail] instead)]

Attachment: new patch

Comment 20

[(not reading, please use [e-mail] instead)]

Comment on attachment 123856 [details] [diff] [review]
new patch

seeking review from david.

it's similar in spirit to the fix for bug #194273, except that at the end, we
select and move.

and we only care about the "move on spam" pref, not the "move when manually
marking as spam".

(and there is no delete option.)

Comment 21

[David :Bienvenu]

Comment on attachment 123856 [details] [diff] [review]
new patch

nit - combine these into one || if clause:

+  if (!spamSettings.level)
+    return;   
+  // if the move functionality is turned off, bail out.
+  if (!spamSettings.moveOnSpam)
+    return;

Comment 22

[(not reading, please use [e-mail] instead)]

Attachment: patch, with david's nit fixed

Comment 23

[(not reading, please use [e-mail] instead)]

Comment on attachment 123881 [details] [diff] [review]
patch, with david's nit fixed

this has r/sr=bienvenu

I'll check with asa for a=.

Comment 24

[(not reading, please use [e-mail] instead)]

Comment on attachment 123881 [details] [diff] [review]
patch, with david's nit fixed

a=sspitzer,asa (asa over aim earlier today)

Comment 25

[(not reading, please use [e-mail] instead)]

fixed for 1.4 final.

Comment 26

[Asa Dotzler [:asa]]

Comment on attachment 123881 [details] [diff] [review]
patch, with david's nit fixed

a=asa (on behalf of drivers) for checkin to 1.4.

Comment 27

[esther]

Using trunk build 20030523 on winxp, linux and macosx this is fixed. verified