204679 - [junk] Run Junk Mail Control on Folder doesn't respect Address Book white list

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[esther]

Using trunk builds 20030502 on winxp, macos and linux the menu item to "Run Junk
Mail Control on Folder" does not respect the address book white list.
Note, this was part of bug180029 but that bug may not get fixed this time around.

1. Launch app, open a profile with a good Junk Mail Control training file
2. Open an IMAP mail account add a name to your name to your Personal Address book
3. Disable Junk Mail Controls for that IMAP account. 
4. Select a piece of mail that had been analyzed as Junk Mail and move it to a
Local Folder.  
5. Open that Mail message and Edit it as New (option under Message menu), change
the From to your IMAP account and Send the message to yourself.
6. Get message for that IMAP account- The message should arrive in Inbox and not
be marked as Junk since you disabled JMC. 
7. Select the IMAP folder, then "Run Junk Mail Control on Folder"  

Result:  That message is analyzed as Junk 
Expected: That message should not be analyzed as Junk because the sender is in
your address book.

Comment 1

[esther]

nsbeta1 nominating

Comment 2

[Samir Gehani]

adt: nsbeta1+/adt2

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 123376 [details] [diff] [review]
updated patch

this has r/sr=bienvenu, a=sspitzer

Comment 6

[(not reading, please use [e-mail] instead)]

fixed.

Comment 7

[(not reading, please use [e-mail] instead)]

david pointed something out that I need to fix.

instead of classifying whitelisted messages as "Good", we should be skipping them

say a message (from someone in your PAb) is marked as junk, you did that manually.
when you marked it, it updated the training data.
now, you do "Run JMC on folder"
if we don't skip it, we'd mark it as good.  (which would be annoying if a
spammer was in your PAB, because we collected it)
and them if you marked it junk again, we'd update the training data again.

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: patch, skip over instead of mark as good.

Comment 9

[David :Bienvenu]

Comment on attachment 123456 [details] [diff] [review]
patch, skip over instead of mark as good.

r/sr=bienvenu

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 123456 [details] [diff] [review]
patch, skip over instead of mark as good.

this was checked in.

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 123376 [details] [diff] [review]
updated patch

this was checked in, so un-obsoleting.

but I also checked in a supplimental patch.

Comment 12

[esther]

using trunk build 20030519 on winxp, macosx and linux this is fixed and verified.