183878 - implement GetBindingParent on genericDOMDataNode

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[James Turner]

Since we added text support to SVG, we're having a problem that we frequently
get event's whose originalTarget is a text node, not an element. Calling
GetBindingParent on these fails, so we're reduced to:

if (event.originalTarget.nodeType != Node.ELEMENT_NODE)
  target = event.originalTarget.parentNode;
else
  target = event.originalTarget

Which is ugly. The method exists in nsIContent, and is trivial to implement (by
calling it recursively on the node's parent). So can this get applied please?
(Patch to follow in a second).

There are a plethora of other nsIContent APIs unimplemented on
genericDOMDataNode, but this is the only one that matters to us.

Comment 1

[James Turner]

Attachment: Implement GetBindingParent on genericDOMDataNode

Comment 2

[Alex Fritze]

I've just had a discussion with James, and it's quite possible that this is an 
SVG bug. I'm not sure data nodes should ever be event targets. Probably the 
enclosing <svg:text> or <svg:tspan> element should be the actual originalTarget.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fixed by patch in bug 97634