97634 - [FIXr]Event.target.parentNode of the Text element passed to a DOMCharacterDataModified/DOMNodeInserted listener is incorrect for a <textarea>'s contents.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[David Emmerson]

I've been trying out DOM2's mutation events, specifically to see when a textarea
is modified by handling DOMCharacterDataModified and DOMNodeInserted.
I am using Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.3+) Gecko/20010827 on
win98se.

What happens:
The events work fine, and the parameter passed to my handler is an event with a
target of the modified (or new) Text node.
The problem occurs when I try to check if the text node was the one in the
<textarea>. event.target.parentNode is returning HTMLDivElement,
event.parentNode.parentNode is the HTMLTextAreaElement. 

What I expect to happen:
As a textarea is meant to contain PCDATA in HTML and my document has no <div>s,
I expect event.target.parentNode to be the textarea.

To reproduce:
Go to the url, type something into the box and see the alerted information.

Comment 1

[Vladimir Ermakov]

confirming... where does the DIV come from!? 

Comment 2

[Boris Zbarsky [:bzbarsky]]

ccing jst.... seems like a weird dom issue

Comment 3

[Johnny Stenback (:jst)]

Smells like anonymous content is leaking out to the DOM here, not good.

Comment 4

[Boris Zbarsky [:bzbarsky]]

*** Bug 101197 has been marked as a duplicate of this bug. ***

Comment 5

[Boris Zbarsky [:bzbarsky]]

Over to DOM HTML.  This is definitely anonymous content leaking.  See testcase
in bug 101197

Comment 6

[Johnny Stenback (:jst)]

Future.

Comment 7

[Kurt Weinschenker]

Still here with Mozilla trunk build 200211208 running under Mac OS 9.2.2.

Comment 8

[Johnny Stenback (:jst)]

Mass-reassigning bugs.

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 225462 has been marked as a duplicate of this bug. ***

Comment 10

[Boris Zbarsky [:bzbarsky]]

The problem here is that the event target is a Text node such never have a
bindingParent... as a result, event retargeting does not happen.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

This makes Text nodes and other GenericDOMDataNodes implement
GetBindingParent() in the only sane way they can -- by looking at their parent.


The other option is to retarget for native anonymous content (something I think
I may prefer, actually, since the content inside a text control really
shouldn't have a binding parent set).

The patch also removes the code added to fix bug 29517 since that was obsoleted
by the bindingParent-based retargeting (I did test to make sure I didn't
regress that bug).

Comment 12

[Boris Zbarsky [:bzbarsky]]

Taking, I guess.

Note that with this patch the DOMCharacterDataModified is targeted at the
_textarea_, not a Text node.  There is no Text node to target it at, really,
since the actual Text node in the DOM is not modified when you type in a
textarea.  Perhaps the textarea should simply suppress mutation events targeted
at its kids?

Or perhaps our retargeting should generally suppress mutation events, since they
don't make very much sense on the new target, usually...

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 135381 [details] [diff] [review]
Proposed patch

bryner?  jst?  What do you think?

Comment 14

[jsp]

Does this patch have any effect on bug 101197?

Comment 15

[Boris Zbarsky [:bzbarsky]]

No, which is why I reopened that bug.

Comment 16

[Johnny Stenback (:jst)]

Comment on attachment 135381 [details] [diff] [review]
Proposed patch

sr=jst for this patch, but I think supressing mutation events for things inside
text inputs is the way to go.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Will land for 1.7a when tree opens.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Checked in for 1.7a.