188245 - can't undo delete mesgs for pop mail acnts

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[grylchan]

Using commercial trunk
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030106 Xp
and 1/7 trunk on linux 2.2

If you delete mesg(s) on a pop account and then try to undo via
 menu: edit|undo
 control keys: ctrl-z
It won't work. Worked in 7.01.

I've tried with the following prefs checked/unchecked and undo delete
doesn't work for any of these:
  - leave mesgs on server
  - delete mesgs on server when they are deleted or moved to inbox

tried with nscp mesg server 6.0, 6.1

reproducable: always

steps:
1.Login to pop mail acnt
2.select a mesg or mesgs
3.Delete them via toolbar, keyboard or file menu
4.try to undo via menu or control keys

result: can't
expected: to have deleted mesgs reappear

Comment 1

[grylchan]

nominating for next release. Didn't find any other open/simlar
bugs but this could be a dupe.

Comment 2

[grylchan]

also tried on nscp mesg srver 4.15 and doesn't work either.

No problem 'undoing' for imap accounts

Comment 3

[Ian Nartowicz]

WFM.  Win98, build ID 2003010304.  POP server, download messages, don't leave
messages on server.  I'll check other options and the latest nightly if you
think this would be helpful.

Comment 4

[grylchan]

linux 2.2: 2003-01-03-08-trunk/. didn't work for me. Deleted mesg,
went to Edit|undo and it was grayed out.

Comment 5

[Ian Nartowicz]

WFM build ID 2003010808, Win98.  Anyone else, working or not?

Comment 6

[esther]

I tried this with ther 1-8 builds on linux, I did see it on my winxp and will
investigate

Comment 7

[esther]

Sorry about the incomplete comment.  I do not see the problem on linux and mac
osx with the 1-8 trunk builds but I do see it on my winxp system with a new
profile and existing profile.  

Comment 8

[esther]

reassigning to cavin since navin is not working on this area now

Comment 9

[esther]

assigning this back to navin, reassinging will be done on triage team

Comment 10

[esther]

I tested this more to find out why the flakieness in seeing this bug. I found a
criteria that is missing.  If you have done a drag n drop within that mail
account then the the undo delete will now work.  I now see this on all
platforms, it is still a regression because I tested again with the missing
criteria to see if 7.01 was OK, and it only happens to POP accounts and local
folders (however it's hard to see it in local folders because to get messages in
those folders you have to copy or move them there and doing that will set the
undo functionality to work).

To reproduce.
1. Create a new profile adding a POP mail account. (For simplicity, have only
that POP account in the profile.
2. Get the message for the POP account.
3. Select a message and click the Delete button.
4. Go to the Edit menu to undo the delete, notice it's disabled. 
It will stay disabled no matter how many messages you delete.
5. Move any message from one folder to another
Now you will see Undo move and from this point on Undo Delete will work too.
*Initiating a move within that mail account will fix the undo delete being
disabled for that account.
You can also reproduce this in existing POP accounts with a profile by removing
the .msf file for Inbox and Trash forcing a rebuild of a new summary file.  Once
rebuilt you will see the problem as described above.  

Comment 11

[(not reading, please use [e-mail] instead)]

taking.

I can reproduce this.

also, I think brendan sent me email about this a while ago.

we should fix this for beta.

Comment 12

[Samir Gehani]

Mail triage team: nsbeta1+/adt1

Comment 13

[(not reading, please use [e-mail] instead)]

sliding to 1.3 final

I have to see if I just fixed this with my checkin for bug #179856

Comment 14

[Brendan Eich [:brendan]]

I mentioned that when Trash.msf has to be rebuilt, but I haven't yet selected
the Trash folder, I can't undo a Delete.  Is that bug still around?  I saw it
with 1.2b at least.

/be

Comment 15

[(not reading, please use [e-mail] instead)]

> I mentioned that when Trash.msf has to be rebuilt, but I haven't yet selected
> the Trash folder, I can't undo a Delete.  Is that bug still around?  I saw it
> with 1.2b at least.

that's bug #198909, working on a fix for it.

Comment 16

[(not reading, please use [e-mail] instead)]

over to david

Comment 17

[David :Bienvenu]

I've got a fix for this. I had an initial patch from Seth which worked the first
time you did an undo of a delete by kicking off a reparse of the dest folder on
undo, but did not work the second time you tried to undo the delete of the same
message (not through any fault of the patch, but because of the fact that local
undo of delete was somewhat broken). I tracked down that problem, and will
attach a patch that addresses both.

Comment 18

[David :Bienvenu]

Attachment: proposed fix

Comment 19

[David :Bienvenu]

Comment on attachment 122931 [details] [diff] [review]
proposed fix

this has r/sr/a=sspitzer

Comment 20

[David :Bienvenu]

fixed

Comment 21

[esther]

using trunk build 20030516 on winxp, macosx and linux this is fixed. Verified