188246 - Build NSPR with GCC 3.x

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[jhp (no longer active)]

Derived from Meta bug 177789.  This bug deals specifically with patches to make
NSPR build on OS/2 using GCC 3.0.3

Comment 1

[jhp (no longer active)]

Attachment: preliminary patch

First patch.  Still to do:
1) Write RAMSEM code.
2) Write atomic ops code.
3) Any other TODO or anything that looks odd in the patch.

Comment 2

[sobotka]

Don't remember what the RAMSEM code is about, but a trivially tweaked Linux i386
atomic ops code has been working fine here for many moons. I sent Mike the file
way back then.

Comment 3

[jhp (no longer active)]

Attachment: patch w/ atomic ops asm

Patch contains assembly code for atomic ops.  Also, got pr/tests building. 
Many tests fail.

Comment 4

[jhp (no longer active)]

Attachment: patch v3

General code cleanup.  Still TODO:
   1) Write RAMSEM code.
   2) Figure out SIGFPE crash (either here or in JS)

Comment 5

[jhp (no longer active)]

Attachment: patch v3.1

Define BSD_SELECT in the correct place (fixes startup crash).

Comment 6

[jhp (no longer active)]

Attachment: patch v3.2

More cleanup.

Comment 7

[jhp (no longer active)]

Attachment: patch v3.3

Thread & tests fixes

Comment 8

[jhp (no longer active)]

Attachment: patch v3.4

Fix Visual Age bustage

Comment 9

[Wan-Teh Chang]

Comment on attachment 118079 [details] [diff] [review]
patch v3.4

Javier,

Is it possible for you to generate a new patch that
does NOT have the DEF_FILE related changes?  The
reason is that we will need to change them again
when we check in the patch in bug 190538.  Also,
DEF_FILE is the same as the existing MAPFILE.

Comment 10

[Wan-Teh Chang]

In other words, is it possible to do a GCC 3.x build
without a DEF_FILE?

Comment 11

[jhp (no longer active)]

wtc:  Yes, we do need DEF files for the GCC build.  The changes here are just to
clean up the code the generates the DEF file.

Comment 12

[Andy Willis (abwillis)]

PRThread*                                                                      
                               
_MD_CURRENT_THREAD(void)                                                       
                               
{                                                                              
                               
    PRThread *thread;                                                          
                               
                                                                               
                               
    thread = _MD_GET_ATTACHED_THREAD();                                        
                               
                                                                               
                               
    if (NULL == thread) {                                                      
                               
        thread = _PRI_AttachThread(PR_USER_THREAD, PR_PRIORITY_NORMAL, NULL, 0);
                              
    }                                                                          
                               
                                                                               
                               
    PR_ASSERT(thread != NULL);                                                 
                               
    return thread;                                                             
                               
}                                                                              
                               

Is in os2tred.c twice after the patch.  

Comment 13

[jhp (no longer active)]

Attachment: patch v3.5

Cleaned up rules.mk to use existing MAPFILE macro.

Comment 14

[Wan-Teh Chang]

Attachment: wtc's patch

Javier, could you test this patch?  Thanks.

Comment 15

[jhp (no longer active)]

wtc:  Yes, that patch works, except that it is missing the os2emx.s file from
the previous patch.  Put that in also, and this patch works for me.

Comment 16

[Wan-Teh Chang]

Attachment: wtc's patch v2

Sorry, I missed os2emx.s.  This patch includes it.
I also removed your changes to nsprpub/pr/tests/dll/Makefile.in
from this patch.  Can you build in that directory without these
changes?  In any case, these changes are not required for the
Mozilla client.

Turns out your patch v3.5 is essentially the same as my patch.
We were working on and attaching our patches at pretty much the
same time :-)

I've checked in this patch on the NSPRPUB_PRE_4_2_CLIENT_BRANCH
for mozilla 1.4alpha.

Comment 17

[jhp (no longer active)]

Attachment: nsprpub/pr/tests/dll/Makefile.in changes

Changes necessary for NSPR tests to build.  Also, removed $(TARGETS) define
(now handled by rules.mk) so *.lib would get deleted by 'make clean'.

Comment 18

[Wan-Teh Chang]

Comment on attachment 118557 [details] [diff] [review]
nsprpub/pr/tests/dll/Makefile.in changes

You deleted
    else
    TARGETS		= $(SHARED_LIBRARY) $(IMPORT_LIBRARY)
which is used by WINNT.  This should be restored.

It seems that for OS/2, TARGETS must include $(LIBRARY) because
$(MAPFILE) is generated from $(LIBRARY), right?

Comment 19

[Wan-Teh Chang]

For the purpose of building Mozilla with GCC 3.x (meta bug 177789),
this bug is fixed.  The necessary changes for building NSPR as part
of Mozilla will appear in mozilla 1.4alpha.

Javier, please use bug 126932 (NSPR tests don't run on OS/2) for
the remaining changes for nsprpub/pr/tests/dll/Makefile.in.