Closed
Bug 192555
Opened 23 years ago
Closed 23 years ago
nsProfileDirServiceProvider should send profile shutdown notifications
Categories
(Core Graveyard :: Profile: BackEnd, defect)
Core Graveyard
Profile: BackEnd
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: ccarlen, Assigned: ccarlen)
References
Details
(Keywords: embed, Whiteboard: fixed1.3)
Attachments
(1 file)
|
4.64 KB,
patch
|
dougt
:
review+
blizzard
:
superreview+
asa
:
approval1.3+
|
Details | Diff | Splinter Review |
See bug 188214. Notification that the profile is shutting down
(profile-before-change) should be sent out by nsProfileDirServiceProvider
instead of requiring the embedding app to do it.
| Assignee | ||
Comment 1•23 years ago
|
||
Adds a Shutdown() method so that, if the requirements of shutting down this
directory service provider change, embedding apps don't break. Compiles on
Linux but not tested - my environment is wacked right now.
| Assignee | ||
Updated•23 years ago
|
Attachment #114071 -
Flags: superreview?(blizzard)
Attachment #114071 -
Flags: review?(dougt)
Comment 2•23 years ago
|
||
Comment on attachment 114071 [details] [diff] [review]
patch to add Shutdown()
assuming that is the right notification topic, the patch looks fine. r=dougt
Attachment #114071 -
Flags: review?(dougt) → review+
Updated•23 years ago
|
Flags: blocking1.3?
Attachment #114071 -
Flags: superreview?(blizzard) → superreview?(blizzard)
Comment 3•23 years ago
|
||
Comment on attachment 114071 [details] [diff] [review]
patch to add Shutdown()
sr=blizzard
Looks good.
Attachment #114071 -
Flags: superreview?(blizzard) → superreview+
Comment 5•23 years ago
|
||
*** Bug 188214 has been marked as a duplicate of this bug. ***
| Assignee | ||
Comment 6•23 years ago
|
||
Checked in - though with comment citing the wrong bug :-/
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 7•23 years ago
|
||
Comment on attachment 114071 [details] [diff] [review]
patch to add Shutdown()
a=asa (on behalf of drivers) for checkin to 1.3 branch.
Attachment #114071 -
Flags: approval1.3+
Comment 8•23 years ago
|
||
Checked into the 1.3 branch.
Updated•23 years ago
|
Whiteboard: fixed1.3
Updated•23 years ago
|
Flags: blocking1.3?
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•