195733 - In <chrome://messenger/content/commandglue.js>, "Error: redeclaration of const MSG_FOLDER_FLAG_TRASH"; (when opening Mail & Newsgroups)

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Bjarne D Mathiesen]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; da-DK; rv:1.4a; MultiZilla v1.3.1 (e)) Gecko/20030228
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; da-DK; rv:1.4a; MultiZilla v1.3.1 (e)) Gecko/20030228

Error: redeclaration of const MSG_FOLDER_FLAG_TRASH
Source File: chrome://messenger/content/commandglue.js
Line: 1

Error: popup has no properties
Source File: chrome://messenger/content/mailNavigatorOverlay.xul
Line: 89

Reproducible: Always

Steps to Reproduce:
1. Open the javascript console
2. Open mail/news


Actual Results:  
I'm getting those two javascript errors every time
The first one is also present in 2003-28/2-03
The last one is new to 2003-28/2-11

Comment 1

[Matthias Versen [:Matti]]

*** Bug 197703 has been marked as a duplicate of this bug. ***

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3) Gecko/20030312]

I suggest to add at least the name of the two involved files in the Summary:
I would not have filed a dupe :-(

"Confirmation" of 'Actual Results' from the Description:
I had only the redeclaration error. (see my duped bug 197703)

Comment 3

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3) Gecko/20030312]

Update to my duped bug 197703, and confirmation of the current bug:

*Reproductible: Allways

*Steps to reproduce:
1. Open Mail & Newsgroups

Comment 4

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4a) Gecko/20030401]

Bug (see comment 2 and 3) still there. (with v1.3 profile, at least)

Reporter: Can you check if the second error still appears for you with v1.4a final ?

Comment 5

[Serge Gautherie (:sgautherie)]

I suggest to change the summary to:

In <chrome://messenger/content/commandglue.js>, "Error: redeclaration of const
MSG_FOLDER_FLAG_TRASH"

And to add the second error when it is confirmed.

Comment 6

[Bjarne D Mathiesen]

using : Mozilla/5.0  Gecko/20030401
(Macintosh; U; PPC Mac OS X Mach-O; da-DK; rv:1.4a; MultiZilla v1.4.0.4A) 

the command.glue error is still present
the mailNavigatorOverlay.xul error is gone

sorry being a little late in answering - I've been awaiting a release of
MultiZilla for 1.4a before testing ;-)

Comment 7

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4b) Gecko/20030507]

Bug still there. (with v1.3 profile, at least)

Comment 8

[Karsten Düsterloh]

const MSG_FOLDER_FLAG_TRASH is defined in commandglue.js.
commandglue.js is used in several XUL files, which are all window/page/dialog -
except mailWindowOverlay.xul, which is an overlay.
mailWindowOverlay.xul OTOH is only included by several of the above XULs, hence
the error.
I'll attach a patch.

Comment 9

[Karsten Düsterloh]

Attachment: small patch to get rid of the MSG_FOLDER_FLAG_TRASH error

This patch removes the inclusion of commandglue.js in mailWindowOverlay.xul,
because each xul using mailWindowOverlay.xul does already include
commandglue.js.

(mailWindowOverlay.xul's license is still NPL, should/could that be changed to
the MPL-Tri-license?)

Seth, shall I look for reviews? By you, actually? ;-)

Comment 10

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4) Gecko/20030529]

Bug still there (v1.4rc1).

***

Re comment 9:

After 10 days of inactivity,
Can anyone try again to push/help a little harder to review/land this patch
(before v1.4) !?

Thanks.

Comment 11

[Matthias Versen [:Matti]]

*** Bug 209757 has been marked as a duplicate of this bug. ***

Comment 12

[Karsten Düsterloh]

A clarification to comment 8:

commandglue.js is included by
+- ABSearchDialog.xul            (=window)
+- mail3PaneWindowVertLayout.xul (=window)
+- messageWindow.xul             (=window)
+- messenger.xul                 (=window)
+- SearchDialog.xul              (=window)
+- msgAccountCentral.xul         (=page)
+- msgSelectOffline.xul          (=dialog)
+- mailWindowOverlay.xul         (=overlay) is included by 
   +- ABSearchDialog.xul
   +- mail3PaneWindowVertLayout.xul
   +- messageWindow.xul
   +- messenger.xul

So the inclusion of commandglue.js in mailWindowOverlay.xul is superfluous and
causing the error.

Comment 13

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 124614 [details] [diff] [review]
small patch to get rid of the MSG_FOLDER_FLAG_TRASH error

sr=dmose

Comment 14

[Serge Gautherie (:sgautherie)]

Not this bug exactly,
but there is 2 other very similar bugs: bug 162432 and bug 195241.

Could someone check them (like comment 12) and possibly come up with a similar
solution ?

(Thanks.)

Comment 15

[Karsten Düsterloh]

stealing bug to make visible who's to blame

Comment 16

[Karsten Düsterloh]

stealing bug to make visible who's to blame

Comment 17

[[e-mail]]

Fixed checked in.

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 124614 [details] [diff] [review]
small patch to get rid of the MSG_FOLDER_FLAG_TRASH error

moving approval request forward.

Comment 19

[Mike Kaply [:mkaply]]

Comment on attachment 124614 [details] [diff] [review]
small patch to get rid of the MSG_FOLDER_FLAG_TRASH error

a=mkaply for 1.4.1

Comment 20

[Mike Kaply [:mkaply]]

Please add fixed1.4.1 keyword when checked in.

Comment 21

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030] (BuildId=0...0,
bug 224340#c9) (W98SE)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20031007] (W98SE)

(as a user) Verified fixed on Trunk (for both).