162432 - In <chrome://help/content/contextHelp.js>, "Error: redeclaration of const MOZILLA_CONTENT_PACK" (in multiple MailNews places)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Greg K.]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.1b) Gecko/20020722
BuildID:    2002072203

Clicking on a mailto: link on a page resulted in an error message being
generated on the JavaScript Console.

Reproducible: Couldn't Reproduce
Steps to Reproduce:
1. Access a page containing a mailto: URL link
2. Click the link.

Actual Results:  MailNews opened a new Compose window correctly addressed, but
an error message was generated on the JavaScript Console:

 Error: redeclaration of const MOZ_HELP_URI
 Source File: chrome://help/content/contextHelp.js
 Line: 1

Expected Results:  MailNews should open a new Compose window without error.

I have not included the URL because it is private. I examined the source and it
was a simple link, of the type <a href="mailto:[e-mail]">[e-mail]</a>.

Comment 1

[Boris Zbarsky [:bzbarsky]]

To help.

Comment 2

[Terri Preston]

WFM using http://people.netscape.com/tpreston/ and clicking on Ms Terri Preston
(a simple mailto link) Mac OS X branch build 2002081305

Comment 3

[Benjamin Smedberg]

Confirming on Win2k: built from the trunk 20020926.  When I hit "reply group"
from a news message, a dialog pops up "An error occurred while creating a
message compose window. Please try again. R"  and the javascript console
displays the "redeclaration" message.  I'm going to update my tree and see if
this helps.

Comment 4

[Greg K.]

Benjamin, that's a different bug. In fact, it greatly resembles bug 135576.

Comment 5

[Greg K.]

...or, the more recent bug 170745.

Comment 6

[Benjamin Smedberg]

OK.  The "redeclaration" message was appearing, but only as a side-affect of my
real bug, which was 170745.  So this bug is only about the
chrome://help/content/contextHelp.js error... but it is still a cross-platform
issue.

This is the only declaration of this variable in the source tree.

Comment 7

[Brant Gurganus]

Confirmed on WinXP SP1

Error: redeclaration of const MOZ_HELP_URI
Source File: chrome://help/content/contextHelp.js
Line: 1

Comment 8

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3a) Gecko/20021212]

I got this JS error, but I don't know how to reproduce.

Comment 9

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3) Gecko/20030312]

Bug still there.

Comment 10

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4a) Gecko/20030401]

Bug still there. (with v1.3 profile, at least)

Comment 11

[Serge Gautherie (:sgautherie)]

I suggest to change the summary to:

In <chrome://help/content/contextHelp.js>, "Error: redeclaration of const
MOZ_HELP_URI"

Comment 12

[jay garcia]

Win98SE Build 20030625

Seeing this error also, don't know what triggers it at the moment.

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.4) Gecko/20030624] (v1.4rc3)

Re comment 12:

This error happens the first time, after each Mozilla start, '(message) Compose'
is opened.

This is *very much* like bug 195733 comment 14 !
Could someone come up with a similar solution ?

Changing:
 *Summary: Adding back the filename (Why did you remove it ?), and updating with
the actual trigger event.
 *Severity: trivial -> normal. (useless clutter of the JS console.)
 *Should this be done too: "Product: Browser -> MailNews" ?

PS: I tried to send you a message, but got
[
<[e-mail]>:
Connected to 192.220.109.252 but sender was rejected.
Remote host said: 550 5.0.0 <[e-mail]>... Access Denied To Chicken Shit
France
];
which I certainly does not like !

Comment 14

[Serge Gautherie (:sgautherie)]

Addition to comment 13:

Asking for 'blocking1.4.x' flag,
hoping to build on bug 195733 comment 19 momentum...

Comment 15

[Ian Oeschger (gone)]

moving stuff over to an outside-the-firewall email for the time being, looking
for people to pick these Help and doc bugs up for me.

Comment 16

[R.J. Keller]

mass reassign of all of Ian Oeschger's bugs to me (R.J. Keller).

Comment 17

[R.J. Keller]

Brant, didn't you fix this in Firebird Help? Could you fix this in seamonkey?

Comment 18

[R.J. Keller]

Accepting.

Brant, do you know the checkin revision on the MozDev tree?

Comment 19

[R.J. Keller]

I can't reproduce this.

Daniel: Can you reproduce?

Comment 20

[Serge Gautherie (:sgautherie)]

Re comment 19:

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20031007] (W98SE)

Bug still there (as in comment 13).
(I don't check nighlies...)

Comment 21

[R.J. Keller]

-> 1.6beta

Comment 22

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6a) Gecko/20031030]
(BuildId=2003110115, bug 224340#c19) (W98SE)

Variable name changed from MOZ_HELP_URI to MOZILLA_HELP:

{
Error: redeclaration of const MOZILLA_HELP
Source File: chrome://help/content/contextHelp.js
Line: 21
}


[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20031007] (W98SE)

(I did not notice it before, like in comment 20, but:)
Line number changed from 1 to 21:

{
Error: redeclaration of const MOZ_HELP_URI
Source File: chrome://help/content/contextHelp.js
Line: 21
}

Comment 23

[Patrick]

Confirming comment 22.

The way i triggered it: in browser do FILE - SEND LINK.

However it won't reproduce in this session, xp pro sp1 20031028

Comment 24

[Serge Gautherie (:sgautherie)]

Re comment 23:

[However it won't reproduce in this session, xp pro sp1 20031028]

_Mozilla_ session ??
Then it behaves as expected:
[(when opening 'Compose' for the _first_ time in the "session")].

_WXP_ session ?? 
Then, that's odd indeed...

Comment 25

[Patrick]

as to comment 24...it reproduces now.
My mistake :$

Comment 26

[R.J. Keller]

Attachment: (Av1) <contextHelp.js>

This fixes the problem, and looks cleaner.

Comment 27

[[e-mail]]

Comment on attachment 135142 [details] [diff] [review]
(Av1) <contextHelp.js>

Unfortunately this the the wrong idea. The error occurs because the file gets
executed twice; you can use either the JavaScript Debugger or the DOM Inspector
to confirm this. You can use lxr to find out which xul files include
contextHelp.js; at this point you could do some more digging or you could guess
at which file is executing contextHelp.js unnecessarily.

Comment 28

[Serge Gautherie (:sgautherie)]

Re comment 26: (attachment 135142 [details] [diff] [review])

LXR says that this is the only place where 'MOZILLA_HELP' is defined/used :-)

I'm no expert at coding style,
still, I was expecting a patch more like the one for bug 195733 :-(

...
Well, Neil has already replied ... while I started to write this comment and
search LXR :-))
--> contextHelp.js is included in nearly 40 (.xul) files: standby...

Comment 29

[Serge Gautherie (:sgautherie)]

Addition to comment 28:

I did not find out the cause through LXR:
(not as easy as bug 195733 case :-()

{
<contextHelp.js> is included by:

/extensions/help/resources/content/helpMenuOverlay.xul, line 10
/extensions/help/resources/content/test.xul, line 8
/xpfe/browser/resources/content/pageInfo.xul, line 51
/xpfe/components/prefwindow/resources/content/pref.xul, line 58
/mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.xul, line 33

only "window.openDialog(" (or "OpenOrFocusWindow("):

/editor/ui/dialogs/content/EdAdvancedEdit.xul, line 55
/editor/ui/dialogs/content/EdImageMap.xul, line 45
/editor/ui/dialogs/content/EdImageProps.xul, line 51
/editor/ui/dialogs/content/EdLinkProps.xul, line 44
/editor/ui/dialogs/content/EdTableProps.xul, line 46
/editor/ui/dialogs/content/EditorPublish.xul, line 46
/editor/ui/dialogs/content/EditorPublishProgress.xul, line 44
/editor/ui/dialogs/content/EditorPublishSettings.xul, line 46
/extensions/cookie/resources/content/p3p.xul, line 55
/extensions/cookie/resources/content/p3pDialog.xul, line 61
/extensions/wallet/cookieviewer/resources/content/CookieViewer.xul, line 45
/extensions/wallet/editor/resources/content/WalletViewer.xul, line 44
/extensions/wallet/signonviewer/resources/content/SignonViewer.xul, line 44
/extensions/wallet/walletpreview/resources/content/WalletPreview.xul, line 39
/xpfe/communicator/resources/content/aboutPopups.xul, line 56
/xpfe/communicator/resources/content/popupManager.xul, line 54
/mailnews/addrbook/prefs/resources/content/pref-directory-add.xul, line 42
/mailnews/addrbook/prefs/resources/content/pref-editdirectories.xul, line 35
/mailnews/base/prefs/resources/content/AccountManager.xul, line 22
/mailnews/base/resources/content/junkMail.xul, line 61
/mailnews/base/resources/content/junkMailInfo.xul, line 58
/mailnews/base/resources/content/msgSelectOffline.xul, line 52
/mailnews/base/resources/content/subscribe.xul, line 43
/mailnews/base/search/resources/content/ABSearchDialog.xul, line 64
/mailnews/base/search/resources/content/FilterEditor.xul, line 57
/mailnews/base/search/resources/content/FilterListDialog.xul, line 42
/mailnews/base/search/resources/content/SearchDialog.xul, line 58
/mailnews/extensions/mailviews/resources/content/mailViewList.xul, line 46
/mailnews/extensions/mailviews/resources/content/mailViewSetup.xul, line 51
/mailnews/extensions/smime/resources/content/msgCompSecurityInfo.xul, line 51
/mailnews/extensions/smime/resources/content/msgReadSecurityInfo.xul, line 49

not by:

/extensions/help/resources/content/help.js, line 80
/extensions/help/resources/content/help.js, line 248
/extensions/help/resources/jar.mn, line 3
}

helpwanted ;->

Comment 30

[Serge Gautherie (:sgautherie)]

I don't know how it happened, but when I opened the JS.C and I found this error
twice !
I'll see if it ever happens again...

Comment 31

[R.J. Keller]

> Unfortunately this the the wrong idea. The error occurs because the file gets
> executed twice; you can use either the JavaScript Debugger or the DOM Inspector

should be happening a lot more than that :). Got an idea on how to prevent this?
The file is executed many times throughout mozilla, but I didn't know that they
would collide because of that.

Comment 32

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113] (W98SE)

Bug still there. (for the record)

Updating:
+(K) helpwanted

Comment 33

[Daniel Wang]

/mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.xul is one
suspect. It puts a Security toolbar button on the Mail Compose window. It
shouldn't have reference to contextHelp.js

Comment 34

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) <msgCompSMIMEOverlay.xul> [Checked in: Comment 56]

Re comment 33:

Nice catch !

I guess that it was added because of
{
<http://landfill.bugzilla.org/mxr-test/seamonkey/source/mailnews/extensions/smime/resources/content/msgCompSMIMEOverlay.js#152>


151	if (0 == buttonPressed) {
152	  openHelp("sign-encrypt");
153	}
}
But I verified that, having no certificate, the help still opens after
answering 'Yes', for both 'Encrypt This Message' and 'Digitally Sign This
Message' :-)
(as it should, since we are solving a 'redeclaration' ;->)

Then, safe to remove, as the overlay is used here only:

{
<http://landfill.bugzilla.org/mxr-test/seamonkey/search?string=msgCompSMIMEOverlay.xul>


/mailnews/extensions/smime/jar.mn, line 5 --
content/messenger-smime/msgCompSMIMEOverlay.xul
(resources/content/msgCompSMIMEOverlay.xul)
/mailnews/extensions/smime/resources/content/contents.rdf.in, line 30 --
<RDF:li>chrome://messenger-smime/content/msgCompSMIMEOverlay.xul</RDF:li>
}

{
<http://landfill.bugzilla.org/mxr-test/seamonkey/source/mailnews/extensions/smime/resources/content/contents.rdf.in#30>


 29   <RDF:Seq
about="chrome://messenger/content/messengercompose/messengercompose.xul">
 30    
<RDF:li>chrome://messenger-smime/content/msgCompSMIMEOverlay.xul</RDF:li>
 31   </RDF:Seq>
}

Comment 35

[Serge Gautherie (:sgautherie)]

Updating:
*(P) Browser -> MailNews
*(C) Help -> Mail Window Front End
*(T.M.) Future -> v1.7a
-(K) helpwanted

Comment 36

[[e-mail]]

Comment on attachment 139340 [details] [diff] [review]
(Bv1) <msgCompSMIMEOverlay.xul>
[Checked in: Comment 56]

Thanks also to Daniel for tracking down the problem.

Comment 37

[R.J. Keller]

I'm a little confused. Is the problem only in this JS file, or others? I've seen
this problem when loading Composer and other apps, not just MailNews. Are you
100% sure that this is the correct fix? I don't see all the Mozilla apps linking
to MailNews like this (since MailNews might not be built).

Comment 38

[Serge Gautherie (:sgautherie)]

Re comment 37:

> I'm a little confused. Is the problem only in this JS file, or others?

This bug is about { "Error: redeclaration of const MOZILLA_CONTENT_PACK" } (3rd
const name since it was filed).
May be you think about some other "Error: redeclaration of const {...}" !?

> I've seen this problem when loading Composer and other apps, not just MailNews.

Well, could you provide testcase(s) ?
If exact same error message, add a comment here;
if different error(s), search/file separate bug(s).

> Are you 100% sure that this is the correct fix?

I'm quite positive that this will fix this bug report, with its one and only
testcase: { when opening 'Compose' for the first time in the "session" }.
Then I could be wrong: let's wait for r & sr.

> I don't see all the Mozilla apps linking to MailNews like this (since MailNews
might not be built).

Sure...

Comment 39

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113] (W98SE)

Well, well: I just found another/different testcase :->>

From bug 228502 comment 1
{
Reproductible testcase:
1. Open MailNews
2. Select a folder
3. Tools > Search Messages...    <-- Each time !
}

Need to investigate this one too... (same as Bv1 ??)

Comment 40

[Serge Gautherie (:sgautherie)]

Addition to comment 39 (second testcase):

From bug 228502 comment 3
{
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6b) Gecko/20031208] (W98SE)

Bug was already there in v1.6b
}

It happens, even with Bv1 patch. (as expected)
Needs more investigation...

Comment 41

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1) <SearchDialog.xul> [Checked in: Comment 54]

Must have been added for
{
	   <button label="&helpButton.label;" align="end"
oncommand="openHelp('search_messages');" accesskey="&helpButton.accesskey;"/> 
}
but works "better" without it.

Comment 42

[Serge Gautherie (:sgautherie)]

Re comment 37: (additional)

I'm beginning to see what you meant:
stay tuned for more patches :->>

NB: I'll continue to post one patch for each file, == for each testcase; easier
to make, easier to review ... some files have multiple warnings/errors :-(

Comment 43

[[e-mail]]

Comment on attachment 139619 [details] [diff] [review]
(Cv1) <SearchDialog.xul>
[Checked in: Comment 54]

OK, so SearchDialog.xul overlays utilityOverlay.xul (for the offline indicator)
which is overlaid by helpMenuOverlay.xul which includes contextHelp.js

Comment 44

[Serge Gautherie (:sgautherie)]

Comment on attachment 139340 [details] [diff] [review]
(Bv1) <msgCompSMIMEOverlay.xul>
[Checked in: Comment 56]

Explanation: (with neil's help :-))

--> messengercompose.xul
    -> utilityOverlay.xul <- contents.rdf.in <- helpMenuOverlay.xul ->
contextHelp.js !
    <- contents.rdf.in <- msgCompSMIMEOverlay.xul -> contextHelp.js // removed

OK, because <msgCompSMIMEOverlay.xul> is only used once:
{
/mailnews/extensions/smime/resources/content/contents.rdf.in, line 30 --
<RDF:li>chrome://messenger-smime/content/msgCompSMIMEOverlay.xul</RDF:li>
}

Comment 45

[Serge Gautherie (:sgautherie)]

Comment on attachment 139619 [details] [diff] [review]
(Cv1) <SearchDialog.xul>
[Checked in: Comment 54]

Addition to comment 43:

And because <SearchDialog.xul> is only used once:
{
/mailnews/base/resources/content/mailWindowOverlay.js, line 2161 --
OpenOrFocusWindow(args, "mailnews:search",
"chrome://messenger/content/SearchDialog.xul");
}

Comment 46

[Serge Gautherie (:sgautherie)]

Forget comment 45:
<SearchDialog.xul> is not an overlay, and we don't care how many times it's
_called_ :-<

Comment 47

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1) <ABSearchDialog.xul ++>

Fixes
{{
Error: redeclaration of const NS_BAYESIANFILTER_CONTRACTID
Source File: chrome://messenger/content/mailCommands.js
Line: 423
--> ABSearchDialog.xul
    -> mailWindowOverlay.xul -> mailCommands.js !
    -> mailCommands.js // removed

Error: redeclaration of const MSG_FLAG_IMAP_DELETED
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 28
--> ABSearchDialog.xul
    -> mailWindowOverlay.xul -> mailWindowOverlay.js !
    -> mailWindowOverlay.js // removed

Error: redeclaration of const kPersonalAddressbookURI
Source File: chrome://messenger/content/msgViewPickerOverlay.js
Line: 23
--> ABSearchDialog.xul
    -> mailWindowOverlay.xul <- contents.rdf.in <- msgViewPickerOverlay.xul ->
msgViewPickerOverlay.js -> kPersonalAddressbookURI  // removed (useless !!)
    -> abCommon.js -> kPersonalAddressbookURI ! (used)
{
/mailnews/extensions/mailviews/resources/content/msgViewPickerOverlay.xul, line
31 -- <script src="chrome://messenger/content/msgViewPickerOverlay.js"/>

/mailnews/extensions/mailviews/resources/content/contents.rdf.in, line 26 --
<RDF:li>chrome://messenger/content/msgViewPickerOverlay.xul</RDF:li>

Question: <mailWindowOverlay.xul> "used" in many places...
http://landfill.bugzilla.org/mxr-test/seamonkey/search?string=mailWindowOverlay.xul&find=&filter=


Answer: Safe to remove, after cross-checking:
http://landfill.bugzilla.org/mxr-test/seamonkey/search?string=kPersonalAddressbookURI&find=&filter=

http://landfill.bugzilla.org/mxr-test/seamonkey/search?string=abCommon.js&find=&filter=

}

Error: redeclaration of const MOZILLA_HELP
Source File: chrome://help/content/contextHelp.js
Line: 21
--> ABSearchDialog.xul
    -> utilityOverlay.xul <- contents.rdf.in <- helpMenuOverlay.xul ->
contextHelp.js !
    -> contextHelp.js // removed
}}
When opening "Tools > Search Adresses...".

(See bug 232123 for another remaining error !)

Comment 48

[Serge Gautherie (:sgautherie)]

Comment on attachment 139842 [details] [diff] [review]
(Dv1) <ABSearchDialog.xul ++>


'r=?': (see comment 47)

Comment 49

[[e-mail]]

Comment on attachment 139842 [details] [diff] [review]
(Dv1) <ABSearchDialog.xul ++>

In the light of bug 232123 I'm not sure this is the right change for
ABSearchDialog.xul; however I do agree with the patch to
msgViewPickerOverlay.js

Comment 50

[Serge Gautherie (:sgautherie)]

Comment on attachment 139842 [details] [diff] [review]
(Dv1) <ABSearchDialog.xul ++>

Then, I'll break this patch into 3 pieces: this bug, bug 232123, and a new
one...

Comment 51

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1b) <ABSearchDialog.xul> [Checked in: Comment 57]

Fixes
{{
Error: redeclaration of const MOZILLA_HELP
Source File: chrome://help/content/contextHelp.js
Line: 21
--> ABSearchDialog.xul
    -> utilityOverlay.xul <- contents.rdf.in <- helpMenuOverlay.xul ->
contextHelp.js !
    -> contextHelp.js // removed
}}
When opening "Tools > Search Adresses...".

Comment 52

[[e-mail]]

Comment on attachment 140199 [details] [diff] [review]
(Dv1b) <ABSearchDialog.xul>
[Checked in: Comment 57]

Oh right, this loads via utilityOverlay.xul, so it's safe to remove here.

Comment 53

[Scott MacGregor]

Comment on attachment 139340 [details] [diff] [review]
(Bv1) <msgCompSMIMEOverlay.xul>
[Checked in: Comment 56]

this is really getting quite silly :). Next time, let's wrap up all these one
line JS error fixes into just a single bug so one only has to put in one r/sr? 

:)

Comment 54

[Serge Gautherie (:sgautherie)]

Comment on attachment 139619 [details] [diff] [review]
(Cv1) <SearchDialog.xul>
[Checked in: Comment 54]


Check in: { 02/06/2004 09:29	neil%parkwaycc.co.uk	mozilla/ mailnews/
base/ search/ resources/ content/ SearchDialog.xul   1.76 }

Comment 55

[[e-mail]]

Is that the lot for this bug now?

Comment 56

[Serge Gautherie (:sgautherie)]

Comment on attachment 139340 [details] [diff] [review]
(Bv1) <msgCompSMIMEOverlay.xul>
[Checked in: Comment 56]


Check in: { 02/07/2004 05:04	neil%parkwaycc.co.uk	mozilla/ mailnews/
extensions/ smime/ resources/ content/ msgCompSMIMEOverlay.xul	     1.8 }

Comment 57

[Serge Gautherie (:sgautherie)]

Comment on attachment 140199 [details] [diff] [review]
(Dv1b) <ABSearchDialog.xul>
[Checked in: Comment 57]


Check in: { 02/07/2004 05:05	neil%parkwaycc.co.uk	mozilla/ mailnews/
base/ search/ resources/ content/ ABSearchDialog.xul	     1.10 }

Comment 58

[Serge Gautherie (:sgautherie)]

(In reply to comment #50)
> (From update of attachment 139842 [details] [diff] [review])
> Then, I'll break this patch into 3 pieces: this bug, bug 232123, and a new
> one...

New bug was bug 232597.