Closed
Bug 197086
Opened 22 years ago
Closed 22 years ago
XUL / Mozilla Interface (esp. tabs) not repainting properly - Modern Theme
Categories
(Core Graveyard :: GFX, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: wd, Assigned: kmcclusk)
References
Details
(Keywords: regression)
Attachments
(3 files, 1 obsolete file)
8.35 KB,
image/gif
|
Details | |
788 bytes,
text/html
|
Details | |
1.46 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030312 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030312 When an area of Mozilla's user interface is invalidated, it doesn't seem to be repainting properly. Reproducible: Always Steps to Reproduce: 1.open some tabs 2.drag a window around over top of the tabs 3. Actual Results: the UI isn't repainting itself properly Expected Results: Repaint properly Clicking on the tab will have it re-draw itself correctly.
Comment 2•22 years ago
|
||
I was just about to try to report this (but had no idea how to do so), so am glad I found it.
Comment 3•22 years ago
|
||
It depends of the theme : Modern is affected but Classic isn't.
*** Bug 197216 has been marked as a duplicate of this bug. ***
Summary: XUL / Mozilla Interface (esp. tabs) not repainting properly → XUL / Mozilla Interface (esp. tabs) not repainting properly - Modern Theme
Comment 5•22 years ago
|
||
Note from my reported dup bug http://bugzilla.mozilla.org/show_bug.cgi?id=197216 that the 1.3 branch doesn't have this issue (with any theme I've tried). Therefore something changed from the branch since 1.3b left the trunk. (Thx wd for the dup note.)
Comment 6•22 years ago
|
||
I've seen problems with the borders of tabs not repainting since before 1.2... it's always been trivial, so I never worried about it. Modern theme/win32. Testcase for me: open a browser with tabs open another window (my xchat window in this case) over the browser minimize the (xchat) other window Expected: no change in the UI Actual: the "text" portion of tabs, the URL bar, and the menu bar displays properly. The borders repaint with background colors/images, but not with border lines.
*** Bug 197690 has been marked as a duplicate of this bug. ***
Keywords: regression
This isn't only a Windows problem. I see it on Linux too: tabs sometime have glitches after a dialog has been open. Button borders in dialog boxes suddenly crack up slightly.
Assignee | ||
Updated•22 years ago
|
Priority: -- → P2
Target Milestone: --- → Future
Comment 9•22 years ago
|
||
Seeing it on linux too. os -> all, component -> GFX
Component: GFX: Win32 → GFX
OS: Windows 2000 → All
Comment 10•22 years ago
|
||
Testing by some people in #mozillazine showed that this has been introduced between 2003031004 and 2003031108. Looking through the checkins, my guess is the checkin for bug 86249
Comment 11•22 years ago
|
||
Michiel: your guess is right backing out my checkin fixes the border drawing issue. I believe the patch is correct, but the tab overflow area is wrong.
Comment 12•22 years ago
|
||
Attachment #118181 -
Flags: superreview?(dbaron)
Attachment #118181 -
Flags: review?(dbaron)
I would rather fix the underlying issue than back out correct code. We're still in alpha.
Comment 14•22 years ago
|
||
Comment 15•22 years ago
|
||
I think we should not manipulate the rectangles of composite borders
Attachment #118181 -
Attachment is obsolete: true
Attachment #118207 -
Flags: review?(roc+moz)
Comment on attachment 118207 [details] [diff] [review] patch Looks good, but add a comment about why composite borders can't use the trimmed coordinates.
Attachment #118207 -
Flags: superreview+
Attachment #118207 -
Flags: review?(roc+moz)
Attachment #118207 -
Flags: review+
Attachment #118181 -
Flags: superreview?(dbaron)
Attachment #118181 -
Flags: review?(dbaron)
Comment 17•22 years ago
|
||
fix checked in
Comment 18•22 years ago
|
||
seems to work ok in 2003032404/win2k. marking resolved... thanks.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•