198898 - Rename Time Remaining to Time Left in Download Manager

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, enhancement)

Description

[Pham]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030323
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030323

Download Manager says Time Remaining.
Download Dialog says Time Left.

Advantage of this is that it'll reduce Download Manager's window size.

This is not bug 134157
134157 is about the 2 having different speeds and info.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Pham]

Changed summary to make shorter.

Comment 2

[Andreas Kunz]

This is only an enhancement, but a valid one:
Column header title is much longer than typical column content, so either space
is wasted in the column or the the title is not fully displayed.
-> Confirming.
Patch coming shortly.

Comment 3

[Andreas Kunz]

Attachment: Patch

Replace the Download Manager "Time Remaining" column header by "Time Left",
making it consistent with regular download windows and saving space.
Not requesting review at the moment...

Comment 4

[Andreas Kunz]

Comment on attachment 118901 [details] [diff] [review]
Patch

Requesting review from Neil.
Can you tell me if sr= is needed? And check it in for me if not?
Thanks!

Comment 5

[[e-mail]]

Comment on attachment 118901 [details] [diff] [review]
Patch

1. Yes, you will need some sort of sr, but as it's only a string change many
srs will give it on request assuming the patch has module owner approval
2. So you should get the module owner to review, if you can find one, or anyone
that your favourite sr will accept.
3. Also, if you're fixing the timeremaining label to match the dialog why not
fix the timeelapsed label to match too?

Comment 6

[Andreas Kunz]

Attachment: Patch that also changes "Time Elapsed" to "Elapsed Time"

Well, this patch addresses 3) of comment #5.
However, I don't think this is the best solution:
it makes the download manager consistent with the progress window, but it also
makes the download manager a bit inconsistent in itself. "Time Elapsed" fits
"Time Left" better than "Elapsed Time" does. Yes, the progress window has the
same problem, but that's a thing this bug report is really not about. It was
mainly about size.

So I'd propose to go with the first patch and I post this one only for the sake
of completeness.

Comment 7

[Pham]

Since attachment 2 [details] [diff] [review] changes Time Elapsed to Elasped Time in the dialog, does that
mean I have to rename bug 201046?

Comment 8

[Andreas Kunz]

Comment on attachment 118901 [details] [diff] [review]
Patch

Requesting review from default owner and module peer Blake.
(Not sure how actively reviewing he is, though...)

Comment 9

[Andreas Kunz]

Re comment #7:
No, you may leave that bug because I requested review for the *first* patch for
the reasons given in comment #6.
So that bug is kind of valid (although it is really a *very* unimportant problem).

Comment 10

[Simon Paquet [:sipaq]]

Andreas, Blake is not actively reviewing at the moment. If you want this patch
to go in, try to find somebody else.

Comment 11

[Andreas Kunz]

Comment on attachment 118901 [details] [diff] [review]
Patch

Well, trying [e-mail] as next reviewer now. Poor jag has 34 items in
his queue and I'd choose him as superreviewer, so this is the best choice I
know of (since I also requested review from Bill Law for bug 201046).

Comment 12

[Ian Neal]

Comment on attachment 118901 [details] [diff] [review]
Patch

Obsoleting and cancelling review request

Comment 13

[Ian Neal]

Comment on attachment 120073 [details] [diff] [review]
Patch that also changes "Time Elapsed" to "Elapsed Time"

Adding review request to the new patch

Comment 14

[Andreas Kunz]

Ian, did you read comment #6 before obsoleting the first patch?
As far as I am concerned (and I was the one writing both patches) the first one
is the better way to go.
If you don't think so it would be nice if you at least stated a reason why.

cc'ing [e-mail] so he gets this comment...

Comment 15

[Ian Neal]

Hmmm, very strange, I did initially think about doing what appears to have
happened but in the end I decided to added myself to the CC and put a comment in
about maybe including a patch that made the download progress but that seems to
have got lost :-S

Comment 16

[Ian Neal]

Attachment: Makes Time Left / Time Elapsed labels consistent between download manager and progress boxes

Comment 17

[Ian Neal]

And here's the patch I'd intended to post as well

Apologies

Comment 18

[Ian Neal]

I'll leave you to decide which patch should be put forward for review - also see
comment in bug 201046

Comment 19

[Andreas Kunz]

Comment on attachment 120073 [details] [diff] [review]
Patch that also changes "Time Elapsed" to "Elapsed Time"

Ok, obsoleting the second attachment to avoid further confusion. It should be
"Time Elapsed" everywhere.

Comment 20

[Andreas Kunz]

Comment on attachment 124322 [details] [diff] [review]
Makes Time Left / Time Elapsed labels consistent between download manager and progress boxes

Ian, that file you additionally modified has been removed today because it was
not used. So I'll obsolete your patch now.
The actually used file has been modified in your sense with bug 201046.

I'll get review...

Comment 21

[Andreas Kunz]

Attachment: up-to-date patch

Patches current trunk.

Comment 22

[Andreas Kunz]

Comment on attachment 128274 [details] [diff] [review]
up-to-date patch

bz, could you please sr= this?
I chose you because you willingly sr'd related bug 201046.
(And I don't think this small patch steals much of your precious time...)
If you have the time, please check it in - if not I'll get biesi to do it.
Thanks.

Comment 23

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 128274 [details] [diff] [review]
up-to-date patch

Hey, my "precious time" is well-spent on this.	;)

Comment 24

[Boris Zbarsky [:bzbarsky]]

Checked in.