203846 - 'Web search' context menu item for selection doesn't

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[sairuh (rarely reading bugmail)]

tested with 2003.04.29 comm builds (also occurs with mozilla).

1. open the Help window.
2. select (highlight) some text in the right content panel.
3. bring up context menu and select the "Web Search for "[selection]"' item.

results: nothing happens. just get the following in the js console:

  Error: OpenSearch is not defined

what would be the expected behavior --should another browser window open showing
the web search results for the selection?

or, should this item be removed from the selection context menu for the Help window?

Comment 1

[Ian Oeschger (gone)]

moving stuff over to an outside-the-firewall email for the time being, looking
for people to pick these Help and doc bugs up for me.

Comment 2

[R.J. Keller]

--> me

Yes, and we get a nice JS error (OpenSearch is not defined). If we import
navigator.js, this will be fixed, but I doubt we want to do that. In fact, Web
Search shouldn't even appear in the help menu.

http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator.js#968

Comment 3

[R.J. Keller]

FIXED with bug 214678. This item was removed from help, which looks like it
covers the reporter's report.

Comment 4

[Daniel Wang]

reopen. Still getting error in today's (1.6a) build. Was the patch applied to
1.5 only?

Comment 5

[R.J. Keller]

Attachment: Patch

Removes the item. Surprised I didn't delete this before!

Comment 6

[R.J. Keller]

Comment on attachment 132268 [details] [diff] [review]
Patch

dveditz, since you super reviewed the bug that added this file, can you
super-review this change to it?

Comment 7

[[e-mail]]

Comment on attachment 132268 [details] [diff] [review]
Patch

It looks to me that having removed this you're not using gContextMenu or its
scripts any more.

Comment 8

[R.J. Keller]

Attachment: Patch

Takes in Neil's comments + the typo the Neil found in bug 214678.

Comment 9

[R.J. Keller]

Attachment: Patch 2.0

The last patch didn't apply, so maybe this one will ;)

Comment 10

[[e-mail]]

Comment on attachment 132272 [details] [diff] [review]
Patch

Had to apply this manually, and I noticed that you hadn't removed the
onpopupshowing/hiding.

Comment 11

[R.J. Keller]

Attachment: Patch 2.01

Comment 12

[[e-mail]]

Comment on attachment 132276 [details] [diff] [review]
Patch 2.01

Applies without patch or run-time error - what more can I ask ;-)

Comment 13

[Daniel Wang]

but I like "Web search"... can you make it work instead of deleting it?

Comment 14

[R.J. Keller]

Daniel: I don't think that web search is for help. Why would a user want to use
it? They should be searching using the help search if there's something they
don't understand in help.

Comment 15

[R.J. Keller]

Comment on attachment 132276 [details] [diff] [review]
Patch 2.01

next on the sr list...

Comment 16

[Alec Flett]

Comment on attachment 132276 [details] [diff] [review]
Patch 2.01

sr=alecf

Comment 17

[R.J. Keller]

Fix checked in!

Comment 18

[Daniel Wang]

v