214678 - right-click menus in Help window has useless items.

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[R.J. Keller]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030729
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030729

When you right-click in the Help window, a menu appears with options like Page
Info, View Source, Bookmark this Page, Save Page As, and other things that
shouldn't appear in the Help window.

A more appropriate menu would be the following:
Back
Forward
Home
Print
-
Select All

It seems to inherit the right-click menu from the <browser> xul element. (When
Bug 76948 is checked in, this bug should be easy to fix, I would think, but I
don't know much about programming XUL elements).

Reproducible: Always

Steps to Reproduce:

Comment 1

[R.J. Keller]

--> me

Comment 2

[R.J. Keller]

Fixed this in the 1.6a Firebird/Thunderbird help that's in development. You
won't see this until the new help menu is checked in.

Comment 3

[R.J. Keller]

Attachment: Patch

Comment 4

[R.J. Keller]

Attachment: helpContextOverlay.xul

Comment 5

[R.J. Keller]

Comment on attachment 131362 [details] [diff] [review]
Patch

neil, jag said that you review help code, so could you review this?

Comment 6

[[e-mail]]

Comment on attachment 131362 [details] [diff] [review]
Patch

This part of the patch is OK if you fix the tab on line 8 of jar.mn; but I
don't understand your new XUL, it seems to have may useless elements.

Comment 7

[[e-mail]]

I meant /many/ useless elements :-[

Comment 8

[R.J. Keller]

Attachment: helpContextOverlay.xul v2

hmm. I don't know what my logic was for keeping some of those items but they're
gone now!

Comment 9

[R.J. Keller]

Comment on attachment 131362 [details] [diff] [review]
Patch

jag, can you sr?

Comment 10

[[e-mail]]

The only items that I can see any use for are back, forward, copy, select all
... unless you know different?

Comment 11

[R.J. Keller]

Attachment: helpContextOverlay.xul v3

This patch removes some other buttons I thought was useless. Also, made sure
that goBack() was used instead of BrowserBack(), and the same for the forward
menu item.

Comment 12

[Daniel Veditz [:dveditz]]

When you have a new (non-binary) file it's best to "cvs add" it and then do a
"cvs diff" with the -N option so it's part of the diff. Makes reviews and
applying the patch easier

Comment 13

[Daniel Veditz [:dveditz]]

Comment on attachment 131362 [details] [diff] [review]
Patch

sr=dveditz

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 131433 [details]
helpContextOverlay.xul v3

sr=dveditz

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Full patch for reference

This is what I'll be landing shortly.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Fixed.

Comment 17

[[e-mail]]

Attachment: Make context Back/Forward disable properly

The back and forward context items used to enable/disable as per the buttons.

Comment 18

[R.J. Keller]

Comment on attachment 132186 [details] [diff] [review]
Make context Back/Forward disable properly

r=rlk

ah dang. How did I forget this? Now I have to find super-review again! this
stinks!

Thank you Neil for catching this

Comment 19

[Daniel Wang]

v

Comment 20

[[e-mail]]

Attachment: Fixed typo

Typo'd in previous patch, sorry.

Comment 21

[R.J. Keller]

Comment on attachment 132269 [details] [diff] [review]
Fixed typo

r=[e-mail]

Thanks a lot for catching this! It would be a good idea!

Comment 22

[R.J. Keller]

Comment on attachment 132269 [details] [diff] [review]
Fixed typo

Moved this to bug 203846