207166 - warning box for caret browsing should give yes/no

Status: VERIFIED FIXED

(Firefox :: General, enhancement)

Description

[Az]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030426 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030426 Mozilla Firebird/0.6

When using caret browsing for the first time (press [f7]) a warning box appears.
 It give 2 options: yes/cancel.

The options should be yes/no as relevant answers to the given question.

The question for your reference reads:
===
Do you want to turn caret browsing on ?
===

Reproducible: Always

Steps to Reproduce:
1. Press [f7]
2. Read notice
3. Observe choice of buttons

Actual Results:  
Buttons offered are:
Yes/Cancel

Expected Results:  
Buttons offered should be:
Yes/No

Comment 1

[Mike Connor [:mconnor]]

Confirming, this one is easily enough fixed, I believe

Comment 2

[Mike Connor [:mconnor]]

Confirming this for real this time, based on my understanding that the toolkits
in Firebird and SeaMonkey are separate at the present time.  If the toolkit was
shared this would be a dupe of 128025.

Comment 3

[Mike Connor [:mconnor]]

Attachment: patch for changing dialog to Yes/No

Change cancel to no

Also replaced BUTTON_TITLE_IS_STRING where the string is "Yes" to
BUTTON_TITLE_YES to clean up that section (the string was originally "Use Caret
Browsing" when feature was implemented).  The string from tabbrowser.properties
is removed to complete the cleanup.

question for the reviewer: the change was made in
toolkit/content/global/widgets/browser.xml, and has no effect in Firebird when
changed in toolkit/content/global/bindings/browser.xml.  Should the same change
be made in the bindings version of the function or is that version of
browser.xml used for something separate?  If required I can make the needed
changes and submit a new patch.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 126687 [details] [diff] [review]
patch for changing dialog to Yes/No

changing review request

Comment 5

[noririty]

Comment on attachment 126687 [details] [diff] [review]
patch for changing dialog to Yes/No

r=me

Comment 6

[noririty]

checked in

Comment 7

[Mike Connor [:mconnor]]

.

Comment 8

[Mike Connor [:mconnor]]

I guess this is vanity

Comment 9

[Andreas Kunz]

Mike, noririty:
after fixing this bug the right dialog button still does not change the pref
while the right does. When the right was still labelled "Cancel" this was by
intention, but now I don't think there is a reason why "Yes" should look at the
checkbox and change the pref, but "No" shouldn't.

The patch is trivial, but note that clicking the dialog close box in its title
bar then also sets the pref, which might not be desirable.
Seamonkey bug 232512 chose "Ok - Cancel" because of this, but it's up to you
what to do...