232512 - Caret browser dialogue box is potentially confusing to new users

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Chris]

User-Agent:       
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031114

When you press F7 and the caret browser dialogue box comes up, it says:

"Pressing F7 turns Caret Browsing on or off. This feature places a moveable
cursor in web pages, allowing you to select text with the keyboard. Do you want
to turn Caret Browsing on?"

etc

The buttons are "Yes" and "Cancel". 

Bad. That Cancel button should be "No"! 

Reproducible: Always
Steps to Reproduce:
Press F7 :)

Comment 1

[Andreas Kunz]

Oh my... how difficult is it for a newbie to understand "Cancel"???

Comment 2

[Chris]

Gee, thanks for the sarcasm. Now go read a book on UI design. 

Comment 3

[Andreas Kunz]

Attachment: patch

Gee, thanks for the advice. Now take this patch and try to get review and
superreview and I'll find someone to check it in.

Comment 4

[Chris]

No longer care, if this is how suggestions are taken in bugzilla then can't see
the point. 

Comment 5

[Andreas Kunz]

Well, I delivered a patch the same day this bug report was filed.
Don't be demoralized because of one single person sick of tiny improvement
requests when there are more than enough big issues. :-)

[e-mail] or [e-mail] are both good possible reviewers.
Please tell me if you cannot set the review? flag, then I'll do it for you. But
you have to convince them this should be done (if neccessary).

Comment 6

[[e-mail]]

One problem: what should happen if you tick the checkbox and select No?
(the current Cancel button also cancels the tick of the checkbox...)

Comment 7

[Andreas Kunz]

Attachment: patch "Ok - Cancel"

Neil: Firebird did this in bug bug 207166: when clicking "No" the checkbox is
ignored. Surely not a sign of improved UI...

This patch now uses "Ok" and "Cancel" so the checkbox behaviour stays the same.


Of course behaviour could be changed when using "Yes - No" to always look at
the checkbox, but there's still a close box on the upper right (at least on
Windows) that is expected to cancel everything changed in the dialog (I think).


Now the question is, if "Ok - Cancel" are the correct answers for the text in
the box.

Bug 128025 also discusses the wording and comment #27 caused me to remove the
period at the end of the checkbox label.

Comment 8

[Andreas Kunz]

Comment on attachment 140207 [details] [diff] [review]
patch "Ok - Cancel"

So Neil, please decide if it should be like this...

Comment 9

[[e-mail]]

Comment on attachment 140207 [details] [diff] [review]
patch "Ok - Cancel"

Since the close box cancels the dialog, I think OK/Cancel is slightly less
confusing than Yes/No.

Comment 10

[Andreas Kunz]

Comment on attachment 140207 [details] [diff] [review]
patch "Ok - Cancel"

Requesting sr= from alecf.

Comment 11

[Alec Flett]

Comment on attachment 140207 [details] [diff] [review]
patch "Ok - Cancel"

I'm not sure I see the value in removing the period. MPT's ancient comment is
not relevant here.

sr=alecf with the period still intact.

Comment 12

[Andreas Kunz]

Attachment: final patch "Ok - Cancel" with r=/sr= from above (period intact)

Final patch for checkin, r=/sr= from last patch.

Comment 13

[Andreas Kunz]

Comment on attachment 140189 [details] [diff] [review]
patch

removing obsolete review request

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in

Comment 15

[Chris]

Fantastic :) Sorry for the harsh comments, Andreas! I do appreciate the effort
you've put into this patch. Keep up the good work, it's good to see how
responsive open source developers are! 

Another reason I choose Mozilla over other browsers.