208461 - MSVC++ .net 2003: midl semantics changed (ISimpleDOMNode_p.c(86) compile error)

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Hixie (not reading bugmail)]

When I build I now hit:
--------------------------------------------------------------------------------
ISimpleDOMNode_p.c
e:/Trees\Mozilla.1\mozilla\accessible\public\msaa\ISimpleDOMNode_p.c(86) : fatal
 error C1189: #error :  You need a Windows 2000 or later to run this stub becaus
e it uses these features:
make[5]: *** [ISimpleDOMNode_p.obj] Error 2
--------------------------------------------------------------------------------

This file is autogenerated by midl. The source around the error says:
--------------------------------------------------------------------------------
#if !(TARGET_IS_NT50_OR_LATER)
#error You need a Windows 2000 or later to run this stub because it uses these 
       features:
#error   /robust command line switch.
#error However, your C/C++ compilation flags indicate you intend to run this app 
       on earlier systems.
#error This app will die there with the RPC_X_WRONG_STUB_VERSION error.
#endif
--------------------------------------------------------------------------------

Comment 1

[Hixie (not reading bugmail)]

This is presumably due to changes in midl. See:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/midl/midl/targeting_stubs_for_specific_32_bit_or_64_bit_platforms.asp

Comment 2

[Hixie (not reading bugmail)]

Ok. Starting with MIDL version 6.0.359, the default command line option for the
MIDL compiler is /Oicf /robust. So now we need to either specify

   CFLAGS = $(CFLAGS) -D_WIN32_WINNT=0x500

...in the Makefile, or, if we want to continue supporting versions prior to
Win2k, then we need to pass /no_robust to midl.

Comment 3

[Hixie (not reading bugmail)]

Attachment: Possible patch

This adds the /no_robust flag to midl calls for versions past 6.0.359. I don't
really know if it is the right solution though.

At the moment it is untested.

Comment 4

[Hixie (not reading bugmail)]

Note: The patch also contains the proposed patches to bug 208320 and bug 208314.

Comment 5

[Hixie (not reading bugmail)]

...and it doesn't work. ho hum.

Comment 6

[David Bradley]

Reassigning to default component owner

Comment 7

[Hixie (not reading bugmail)]

Attachment: Mark II: Let's try this again with some help from dbaron

They say you learn something new every day. For me it's about AC_SUBST.

Comment 8

[Hixie (not reading bugmail)]

That last patch seems to have done the trick. (Note that it still contains the
proposed patches to bug 208320 and bug 208314.)

Comment 9

[Phil Schwartau]

Setting default QA -

Comment 10

[Pauli "suokko" Nieminen]

Mark II: Let's try this again with some help from dbaron  	 patch   	2003-06-05
18:17:23  	 none   	 None
This patch is what works well for me. I build mozilla with VC++ 6.0 with MIDL
6.00.0359 (1st with /robust as default), OS: WIN XP. I hope this can be added to
mozilla project files in cvs. I made it work with following changes which is
same as in patch:

mozilla\accessible\public\msaa\Makefile(97): "$(MIDL)" /no_robust
$(srcdir)/ISimpleDOMNode.idl
mozilla\accessible\public\msaa\Makefile(98): "$(MIDL)" /no_robust
$(srcdir)/ISimpleDOMDocument.idl
mozilla\accessible\public\msaa\Makefile(99): "$(MIDL)" /no_robust
$(srcdir)/ISimpleDOMText.idl
mozilla\embedding\browser\activex\src\control\Makefile(116): "$(MIDL)"
/no_robust /Oicf /h MozillaControl.h /iid MozillaControl_i.c
$(srcdir)/MozillaControl.idl
mozilla\mailnews\mapi\mapihook\build\Makefile(64): "$(MIDL)" /no_robust
$(UNICODE_FLAGS) $(srcdir)/msgMapi.idl

(only added /no_robust to every of these lines)

Also one more change is needed if want to build only
mozilla\mailnews\mapi\mapihook\build\

mozilla\mailnews\mapi\mapihook\build\Makefile(line 58)
Current: DEFINES += -DREGISTER_PROXY_DLL -DUNICODE -D_UNICODE
To make part build work: DEFINES += -DREGISTER_PROXY_DLL -DUNICODE -D_UNICODE
-D_WIN32_WINNT=0x400

This isn't problem when build whole mozilla.

This is only minor problem: If someone want to build only this part then he can
pass parameter for make.

Comment 11

[Stephen Walker]

Attachment: Updated version of Hixie's bitrotted patch

The patch also contains the configure/autoconf changes for bug 208320.

Comment 12

[Stephen Walker]

The palmsync/build Makefile will most likely need to have -D_WIN32_WINNT=0x400
added to its DEFINES list as the mapihook/build Makefile did but I didn't build
the palmsync component to be certain.

Comment 13

[tor]

Attachment: remerge to tip

Comment 14

[Ali Ebrahim]

Shouldn't [e-mail]'s patch also make a similar change to the following file?

/cvsroot/mozilla/embedding/browser/activex/src/control/Makefile.in

That also uses midl and breaks when building Firebird on VS.NET 2003 unless the
/no_robust flag is specified.

Comment 15

[tor]

Checked in with the activex makefile.in change that was omitted when I
split the patch.  Thanks for pointing that out.

Comment 16

[Stephen Walker]

While trying to build the palmsync for thunderbird, I've verified that the
palmsync/build Makefile does need -D_WIN32_WINNT=0x400 added.

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

palmsync is now bug 301489