211360 - add contract ids for commonly used components (so cid usage can be removed)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Kathleen :Brade]

We need some contract IDs added for various components so we can avoid using
CIDs in editor.

Comment 1

[Kathleen :Brade]

Attachment: widget contract ID changes

Comment 2

[Kathleen :Brade]

Attachment: layout contract ID additions

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 126879 [details] [diff] [review]
layout contract ID additions

r=kaie provided you get a layout person to superreview this

Comment 4

[Kathleen :Brade]

Comment on attachment 126878 [details] [diff] [review]
widget contract ID changes

blizzard--can you suggest a reviewer for this patch?

Comment 5

[kinmoz]

Comment on attachment 126879 [details] [diff] [review]
layout contract ID additions

sr=[e-mail], but can we change the contract IDs to the following?


NS_CONTENTITERATOR_CID:

  "@mozilla.org/content/post-content-iterator;1"

NS_PRECONTENTITERATOR_CID:

  "@mozilla.org/content/pre-content-iterator;1"

NS_GENERATEDCONTENTITERATOR_CID:

  "@mozilla.org/content/generated-content-iterator;1"

NS_GENERATEDSUBTREEITERATOR_CID:

  "@mozilla.org/content/generated-subtree-content-iterator;1"

NS_SUBTREEITERATOR_CID:

  "@mozilla.org/content/subtree-content-iterator;1"

Comment 6

[Christopher Blizzard (:blizzard)]

Comment on attachment 126878 [details] [diff] [review]
widget contract ID changes

rs=blizzard on this mechanical change

Comment 7

[Simon Montagu :smontagu]

Comment on attachment 126878 [details] [diff] [review]
widget contract ID changes

r=smontagu

Comment 8

[Kathleen :Brade]

fix checked in

Comment 9

[Boris Zbarsky [:bzbarsky]]

Just as a note, creating a CSS parser via CID or contractid is almost certainly
wrong; you really want to be getting CSS parsers from the CSSLoader associated
with the document... (Just saying this because I saw that you added a contractid
for CSS parsers...)