211852 - Tab enters iframes but does not leave them

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Timwi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

Take http://bugzilla.mozilla.org/enter_bug.cgi?product=Browser&format=guided for
example. Pressing Tab repeatedly will have it go through the entire list of bugs
in that iframe, but it will stay inside that iframe forever. Once you're in there,
you're stuck.

Reproducible: Always

Steps to Reproduce:
1. Find page with iframe.
2. Press Tab until you're in it.
3. Try to escape.

Comment 1

[Aaron Leventhal]

Not good. When did this break?

Comment 2

[Aaron Leventhal]

I notice that Tabbing does leave the iframe -- but only to the search button and
then cycles back to the iframe again.

Comment 3

[Aaron Leventhal]

Attachment: Iframe part of test case -- use other test case file

Comment 4

[Aaron Leventhal]

Attachment: Shows similar problem, but only with Shift+Tabbing -- does not reach all links in outer doc before going back into iframe

Comment 5

[Aaron Leventhal]

Sarah says this worked in the 2/6 builds, but was broken somewhere between then
and 3/13.

Comment 6

[Aaron Leventhal]

Argh, I broke it in nsEventStateManager.cpp
1.422	aaronl%netscape.com	Mar 7 17:09	 	Bug 170921, bug 174163, bug 172329.
Image selection occuring when image buttons, linked images or image map areas
focused. r=mjudge, sr=bryner

Comment 7

[Aaron Leventhal]

Attachment: Change if() line back. MoveCaretToFocus() still needs to wipe out slection if focus is null. Otherwise tabbing in outer document keeps moving relative to last selection.

Comment 8

[Aaron Leventhal]

Also has same problem if you use overflow: scroll

Comment 9

[Aaron Leventhal]

Please ignore my last comment

Comment 10

[Aaron Leventhal]

checked in