Closed
Bug 212683
Opened 22 years ago
Closed 22 years ago
cleanup usage of Is* utility methods; add new methods
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla1.5beta
People
(Reporter: Brade, Assigned: Brade)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
21.26 KB,
patch
|
glazou
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
We could better factor some code by having a few more Is* utility methods.
One example is "IsInlineStyle"
We should also check where NodeIsType is called (or other Is* utilities) and
make sure that we are calling the appropriate ones. Sometimes we are checking
for all but one or two obscure tags which may really be a bug rather than
intentionally leaving them out.
|
Assignee | |
Comment 1•22 years ago
|
||
Comment on attachment 128732 [details] [diff] [review]
patch v1
The very little code increase generated by this patch is probably
counter-balanced by the little perf improvement. Worth doing it, IMHO.
r=glazman
Attachment #128732 -
Flags: review+
|
||
Updated•22 years ago
|
Attachment #128732 -
Flags: superreview+
|
|
Assignee | |
Comment 3•22 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.5beta
You need to log in
before you can comment on or make changes to this bug.
Description
•