213639 - Browser crashes when attempting to download on Mac OS 10.1.5

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Joel Craig]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5a) Gecko/20030721

Was attempting to download tournament brackets for my daughter's softball
league, Mozilla crashed as soon as download started. It also crashed when I
tried to d/l Mozilla 1.4.

Reproducible: Always

Steps to Reproduce:
1.Find any link to d/l
2.Click to d/l
3.Browser quits

Actual Results:  
Mozilla crashed

Expected Results:  
Mozilla should have d/l the files. No problem when reverting back to ver. 1.4

Comment 1

[Joel Craig]

I probably should have added that I'm using OSX 10.1.5, in case this makes a
difference.

Comment 2

[Stefan [:stefanh]]

Hmm, kind of hard to reproduce without any URL...

Comment 3

[Joel Craig]

I guess I could have been more specific. It crashed every time I attempted a
download from numerous sites, and also when attempting to re-d/l version 1.4:

http://ftp.mozilla.org/pub/mozilla/releases/mozilla1.4/mozilla-mac-MachO-1.4.dmg.gz

Comment 4

[Stefan [:stefanh]]

Joel, do you crash after the downloading is completed or when it starts? Do you
see any error messages? Can you post a Talkback ID or a OS x crash log?

Comment 5

[Joel Craig]

Stefan, it would crash immediately upon beginning a d/l. I had Talkback disabled
and don't currently have 1.5a installed. I suppose I could re-d/l 1.5a, enable
Talkback, and see what happens.

Comment 6

[Joel Craig]

I can now tell you this seems to be a bug in the Download Manager, as the
browser does not crash when I use a Progress Dialog. Also, I re-enabled Talkback
but it wouldn't open upon crashing. One other thing, I got this from Console at
crashing (not sure if this means anything):

dyld: /Applications/Mozilla.app/Contents/MacOS/mozilla-bin Undefined symbols:

/Applications/Mozilla.app/Contents/MacOS/components/libimgicon.dylib undefined
reference to _ReleaseIconRef expected to be defined in ApplicationServices

Comment 7

[Stefan [:stefanh]]

Confirming with Mozilla build 2003072403 and 2003072803 on OS 10.1.5. 

I can't download anything. For instance, attempting to download a file by
clicking any of the links at http://ftp.mozilla.org/pub/mozilla/nightly/latest/
will cause a crash. Creating a new profile doesn't help. After every attempt to
download there's a 4K large file on the desktop. 

Using "Save link target as..." from the contextual menu works fine.

No talkback or crashreporter log, Mozilla exits with the message (translated
from Swedish): "The application Mozilla have unexpectedly quit. This hasn't
effected the system or any other programs". However, I do have the same message
in the Console as Joel after I crashed.

My settings in the download manager (Preferences... --> Navigator --> Downloads)
doesn't seem to matter, I never checked that with the earlier build though.

This is probably unrelated, but everytime I start Mozilla I get a message in the
Console (this is with build 2003072803, didn't check with the other build):
*** malloc[Different number]: Deallocation of a pointer not malloced: 0x1cee0;
This could be a double free(), or free() called with the middle of an allocated
block; Try setting environment variable MallocHelp to see tools to help debug

Comment 8

[Vidar Haarr (not reading bugmail)]

*** Bug 216268 has been marked as a duplicate of this bug. ***

Comment 9

[Boris Zbarsky [:bzbarsky]]

Stefan, do you get that message about malloc if you use the progress dialog
instead of the download manager?

Would it be at all possible to produce a stack from a debug build or from macsbug?

Comment 10

[Stefan [:stefanh]]

I get this message everytime I start Mozilla:

*** malloc[275]: Deallocation of a pointer not malloced: 0x1cee0; This could be
a double free(), or free() called with the middle of an allocated block; Try
setting environment variable MallocHelp to see tools to help debug

When clicking on a download link Mozilla quits with this message in the console:

dyld: /Applications/Mozilla.app/Contents/MacOS/mozilla-bin Undefined symbols:
/Applications/Mozilla.app/Contents/MacOS/components/libimgicon.dylib undefined
reference to _ReleaseIconRef expected to be defined in ApplicationServices

I get this message regardless of my settings in "Preferences..." --> "Navigator"
--> "Downloads"

I'm currently on Mozilla build 2003072803, I'll see if I manage to download a
later Mozilla build with Camino (I'm on a 56K connection...) This must be a OS
10.1.x issue, haven't seen any reports from 10.2+ users.

BTW, I think MacsBug is Classic-only.

Comment 11

[Stefan [:stefanh]]

OK, did some more testing on build 2003082903:

The key to trigger a crash/exit when clicking on a download link seems to be
related to Mozilla asking you what to do with the file.

I'll crash if I click on a link (tested with pdf) if:

1. No helper application for that file is specified (ie, Mozilla will ask what
to do with the file)

2. If I specify a file type (in this case pdf) in "Preferences..." -->
"Navigator" --> "Helper applications" *and* have the box "Always ask me before
handling files of this type" checked. This is mentioned by the reporter of bug
216268 (http://bugzilla.mozilla.org/show_bug.cgi?id=216268#c5)

My settings in "Preferences..." --> "Navigator" --> "Downloads" doesn't seem to
matter.

This is probably a separate bug, but as the reporter of bug 216268 mention,
trying to edit the entry in "Helper applications" (by selecting it) will also
trigger a crash/exit.

Comment 12

[Boris Zbarsky [:bzbarsky]]

ccing some mac people... maybe some sort of bizarre linking issue?

Stefan, is this a clean install?  Or an install over an older build?

Comment 13

[Stefan [:stefanh]]

Boris:

As clean as it can be... Fresh profile and deleting the old app. Following the
instructions at
http://www.mozilla.org/releases/mozilla1.5b/installation.html#mac, except for
the file "Mozilla Registry" (doesn't exists in
/Users/yourusername/Library/Preferences, it's in my OS 9 system folder and not
deleted, since I'm running 1.2.1 in classic mode. But this shouldn't matter AFAIK.

There are some more possible related bugs: bug 215657, the reporter is on OS
10.1.5: http://bugzilla.mozilla.org/show_bug.cgi?id=215657#c4.

Bug 213991 could also be related

Could this have some thing to do with the fact that Mozilla probably is builded
on 10.2?

Comment 14

[Simon Fraser [no longer active]]

This is the key: 
dyld: /Applications/Mozilla.app/Contents/MacOS/mozilla-bin Undefined symbols:
/Applications/Mozilla.app/Contents/MacOS/components/libimgicon.dylib undefined
reference to _ReleaseIconRef expected to be defined in ApplicationServices

We have some linkage issues on 10.1.5, apparently.

Comment 15

[Stefan [:stefanh]]

Just found bug 218029. Looks related, but now it's _GetIconRefFromFile...

Comment 16

[Simon Fraser [no longer active]]

*** Bug 218029 has been marked as a duplicate of this bug. ***

Comment 17

[Paul Bergsagel]

Hi. I am experiencing this bug, but am not sure it is a download manager issue
since I went into the download preferences and  set it to:

-open download manager
-open a progress dialogue
-don't open anything

Trying each of the settings in turn with a download had no effect. The browser
still unexpectedly quit about a second after clicking on the download before the
download manager or progress dialogue window appeared.

My setup:
MacOS X
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030908

Here is the console log (I cleaned the log before launching Mozilla):

Mac OS X Version 10.1.5 (Build 5S66)
*** malloc[344]: Deallocation of a pointer not malloced: 0x1d140; This could be
a double free(), or free() called with the middle of an allocated block; Try
setting environment variable MallocHelp to see tools to help debug
/Volumes/NewDrive15/Mozilla 1.5 beta/Mozilla.app/Contents/MacOS/mozilla-bin:
can't map file: /Volumes/NewDrive15/Mach-oNightly/Internet
Plug-Ins/MRJPluginCarbon.plugin ((os/kern) invalid argument)
dyld: /Volumes/NewDrive15/Mozilla 1.5
beta/Mozilla.app/Contents/MacOS/mozilla-bin Undefined symbols:
/Volumes/NewDrive15/Mozilla 1.5
beta/Mozilla.app/Contents/MacOS/components/libimgicon.dylib undefined reference
to _ReleaseIconRef expected to be defined in ApplicationServices
2003-09-08 15:23:49.746 loginwindow[293] Can't connect to pbs object
"RulebookServer"
2003-09-08 15:23:49.746 loginwindow[293] Can't connect to pbs object
"RulebookServer"
*** malloc[345]: Deallocation of a pointer not malloced: 0x1d170; This could be
a double free(), or free() called with the middle of an allocated block; Try
setting environment variable MallocHelp to see tools to help debug
/Volumes/NewDrive15/Mozilla 1.4a final/Mozilla
1.4.app/Contents/MacOS/mozilla-bin: can't map file:
/Volumes/NewDrive15/Mach-oNightly/Internet Plug-Ins/MRJPluginCarbon.plugin
((os/kern) invalid argument)
Sep  8 15:27:43 h24-79-64-65 /sbin/autodiskmount[106]: disk2s2    ???    hfs   
  no    no    Mozilla          /Volumes/Mozilla 

*** malloc[357]: Deallocation of a pointer not malloced: 0x1d160; This could be
a double free(), or free() called with the middle of an allocated block; Try
setting environment variable MallocHelp to see tools to help debug
/Volumes/NewDrive15/Moz Suite Nightly/Mozilla.app/Contents/MacOS/mozilla-bin:
can't map file: /Volumes/NewDrive15/Moz Suite Nightly/Internet Plug-Ins/PDF
Browser Plugin.plugin ((os/kern) invalid argument)
/Volumes/NewDrive15/Moz Suite Nightly/Mozilla.app/Contents/MacOS/mozilla-bin:
can't map file: /Volumes/NewDrive15/Moz Suite Nightly/Internet
Plug-Ins/QuickTime Plugin.plugin ((os/kern) invalid argument)
/Volumes/NewDrive15/Moz Suite Nightly/Mozilla.app/Contents/MacOS/mozilla-bin:
can't map file: /Volumes/NewDrive15/Moz Suite Nightly/Internet Plug-Ins/DRM
Plugin.bundle ((os/kern) invalid argument)
/Volumes/NewDrive15/Moz Suite Nightly/Mozilla.app/Contents/MacOS/mozilla-bin:
can't map file: /Volumes/NewDrive15/Moz Suite Nightly/Internet Plug-Ins/Windows
Media Plugin ((os/kern) invalid argument)
/Volumes/NewDrive15/Moz Suite Nightly/Mozilla.app/Contents/MacOS/mozilla-bin:
can't map file: /Volumes/NewDrive15/Moz Suite Nightly/Internet
Plug-Ins/MRJPluginCarbon.plugin ((os/kern) invalid argument)
dyld: /Volumes/NewDrive15/Moz Suite
Nightly/Mozilla.app/Contents/MacOS/mozilla-bin Undefined symbols:
/Volumes/NewDrive15/Moz Suite
Nightly/Mozilla.app/Contents/MacOS/components/libimgicon.dylib undefined
reference to _ReleaseIconRef expected to be defined in ApplicationServices
*** malloc[358]: Deallocation of a pointer not malloced: 0x1d160; This could be
a double free(), or free() called with the middle of an allocated block; Try
setting environment variable MallocHelp to see tools to help debug
/Volumes/NewDrive15/Moz Suite Nightly/Mozilla.app/Contents/MacOS/mozilla-bin:
can't map file: /Volumes/NewDrive15/Moz Suite Nightly/Internet
Plug-Ins/MRJPluginCarbon.plugin ((os/kern) invalid argument)
dyld: /Volumes/NewDrive15/Moz Suite
Nightly/Mozilla.app/Contents/MacOS/mozilla-bin Undefined symbols:
/Volumes/NewDrive15/Moz Suite
Nightly/Mozilla.app/Contents/MacOS/components/libimgicon.dylib undefined
reference to _ReleaseIconRef expected to be defined in ApplicationServices
*** malloc[359]: Deallocation of a pointer not malloced: 0x1d160; This could be
a double free(), or free() called with the middle of an allocated block; Try
setting environment variable MallocHelp to see tools to help debug
/Volumes/NewDrive15/Moz Suite Nightly/Mozilla.app/Contents/MacOS/mozilla-bin:
can't map file: /Volumes/NewDrive15/Moz Suite Nightly/Internet
Plug-Ins/MRJPluginCarbon.plugin ((os/kern) invalid argument)
*** malloc[362]: Deallocation of a pointer not malloced: 0x1d160; This could be
a double free(), or free() called with the middle of an allocated block; Try
setting environment variable MallocHelp to see tools to help debug
/Volumes/NewDrive15/Moz Suite Nightly/Mozilla.app/Contents/MacOS/mozilla-bin:
can't map file: /Volumes/NewDrive15/Moz Suite Nightly/Internet
Plug-Ins/MRJPluginCarbon.plugin ((os/kern) invalid argument)
dyld: /Volumes/NewDrive15/Moz Suite
Nightly/Mozilla.app/Contents/MacOS/mozilla-bin Undefined symbols:
/Volumes/NewDrive15/Moz Suite
Nightly/Mozilla.app/Contents/MacOS/components/libimgicon.dylib undefined
reference to _ReleaseIconRef expected to be defined in ApplicationServices

Comment 18

[Stefan [:stefanh]]

There's at least one report from a user that crashes with the same console
message when trying to open certain e-mails. See bug 218740.

Comment 19

[Scott MacGregor]

I bet this is related to:

http://bugzilla.mozilla.org/show_bug.cgi?id=196612

mozicon for the mac used to work back in the mac binary project days. I'm
guessing when we transitioned to the Makefile system for the Mac, we stopped
building this. Then the fix for 196612 went in which started building the mac
decoder again. And then we started seeing the unresolved link error.

This leaves two questions in my mind:

1) Is the link error an issue with the old icon code using something that
doesn't get resolved dynamically in 10.1?

or

2) Is something missing in the new Makefile changes from 196612?

Taking since general-browser is a black hole.

Although I do not own a Mac to test things on. But I can at least help drive a fix.

Comment 20

[Len Laughridge]

Scott - I can provide you with ssh/VNC access to a Dual 1.25 G4, but it's
10.2.6.  Sounds like this is a 10.1.x bug.  If so, that wouldn't help you much.
 Email me privately if interested.

Len

Comment 21

[Stefan [:stefanh]]

Since the same crash also seem to occur when trying to:

1. Add an attachment to a mail (bug 218932)
2. Open a mail message with an attached file (bug 218936)
3. Trying to open certain mail messages (bug 218740)

Could someone please change the summary?

Comment 22

[Stefan [:stefanh]]

*** Bug 216497 has been marked as a duplicate of this bug. ***

Comment 23

[Pat Chee]

Moz 1.5b build 2003082703 ; OS X 10.1

It doesn't crash from all downloads.  Just ones from the nightly build link:
http://ftp.mozilla.org/pub/mozilla/nightly/latest-trunk/mozilla-mac-MachO.dmg.gz

...at least so far.  It has crashed on me every time. No download dialog or
anything.

It's just rather annoying when I'm trying to download the next build.

pat

Comment 24

[Asa Dotzler [:asa]]

Can someone post a talkback ID so we can try to match this up to other crashes
in the talkback database?

Comment 25

[Pat Chee]

I would love to show a talkback ID but for some reason talkback doesn't show up
when Mozilla crashes for me.  Is there some way to turn it on?  I can't find any
documentation to tell me how to turn this feature on for OS X.

Dumb question: I'm new, what's this console everyone is talking about and how do
I see it?

Comment 26

[Paul Bergsagel]

The best information that can be provided will have to be provided from the
Console. This is because when Mozilla fails to download the file no crash.log or
talkback log is generated.

Asking for a talkback ID is useless since the talckback log is never generated
with this bug is experienced.

Comment 27

[Stefan [:stefanh]]

*** Bug 219734 has been marked as a duplicate of this bug. ***

Comment 28

[Boris Zbarsky [:bzbarsky]]

If we aren't getting anywhere on the linking issues, could we at least
re-disable the decoder as a stopgap for 1.5?  Shipping it with this crash would
be very unfortunate -- this makes the browser almost unusable for daily browsing.

Comment 29

[Brian Ryner (not reading)]

Attachment: possible fix

I suspect this will fix the problem, but I have no way of verifying it.  At any
rate, it shouldn't hurt anything, so we could check it in and have someone on
10.1.x verify whether it fixes the problem.

Comment 30

[Brian Ryner (not reading)]

Attachment: better fix

I think it's incorrect for us to link to ApplicationServices/CoreServices
directly here.	The symbols should be accessed through the Carbon umbrella
framework.

Comment 31

[Brian Ryner (not reading)]

I checked in this patch.  Could someone who is seeing this problem please
download a nightly trunk build from 2003-09-30 or later, when they are
available, and test whether this bug is fixed?

Comment 32

[Pat Chee]

Using build 2003093005 on Mac OS 10.1.5

I was able to successfully download the nightly build:
http://ftp.mozilla.org/pub/mozilla/nightly/latest-trunk/mozilla-mac-MachO.dmg.gz

with this build of mozilla. That's the only link I've tested to download yet but
that was one of the links that gave several people trouble in previous 1.5x builds.

Good work.

Comment 33

[Stefan [:stefanh]]

WFM with 2003093005 on Mac OS 10.1.5. :)

No crash when clicking on download links. Have also successfully downloaded
files from Tucows with no problem (hqx, sit & zip). Great! Bug 218932 & 218936
(mentioned in comment #21) are also WFM (haven't been able to check bug 218740). 

 

Comment 34

[Brian Ryner (not reading)]

yep, this would address all of those bugs.  thanks for verifying.

Comment 35

[Stefan [:stefanh]]

I belive this should be mentioned in the release notes if it doesn't get fixed
on the 1.5 branch.

Comment 36

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132395 [details] [diff] [review]
better fix

Could this please be checked in on the 1.5 branch? This fixes a very common
crash on Mac ...

Comment 37

[Boris Zbarsky [:bzbarsky]]

*** Bug 222375 has been marked as a duplicate of this bug. ***

Comment 38

[Olivier Cahagne]

*** Bug 222414 has been marked as a duplicate of this bug. ***

Comment 39

[Bill C]

This bug is not resolved as any attempt to download from either Firebird 0.7 or
Mozilla 1.5 will cause a crash when using Mac OS 10.1.5

Comment 40

[Stefan [:stefanh]]

*** Bug 222444 has been marked as a duplicate of this bug. ***

Comment 41

[Boris Zbarsky [:bzbarsky]]

[e-mail], please note that the patch has the "approval1.5?" flag
set.  This means it was never approved for the 1.5 branch, which is why the bug
is present in 1.5.  The bug is resolved in current trunk builds.

Comment 42

[Boris Zbarsky [:bzbarsky]]

*** Bug 222715 has been marked as a duplicate of this bug. ***

Comment 43

[Boris Zbarsky [:bzbarsky]]

*** Bug 222710 has been marked as a duplicate of this bug. ***

Comment 44

[Stefan [:stefanh]]

*** Bug 222825 has been marked as a duplicate of this bug. ***

Comment 45

[Asa Dotzler [:asa]]

Comment on attachment 132395 [details] [diff] [review]
better fix

1.5 shipped. removing obsolete request.

Comment 46

[Boris Zbarsky [:bzbarsky]]

Could we at least add this to the release notes?

Comment 47

[Brendan Eich [:brendan]]

Don't we use the relnote keyword any more?

/be

Comment 48

[timeless]

sure, i could (anyone have a suggestion about a polite way to indicate that 1.5
is a dud on osx 10.1?). but how about letting us set an approval1.5.1? flag so
that it doesn't miss 1.5.1?

Comment 49

[Brian Ryner (not reading)]

checked in on the 1.5 branch per drivers' request.

Comment 50

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 223755 has been marked as a duplicate of this bug. ***