217300 - Get new Extensions/Themes no longer looks like a link

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Schelstraete Bart]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030825 Mozilla Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030825 Mozilla Firebird/0.6.1+

The 'Get new Extensions' is  not visible as link anymore in the preferences.
This is now just text, this means that the users don't know that they can click
on  that.

Reproducible: Always

Steps to Reproduce:
1.Go to Tools
2. -> Options
3. -> Extensions
Actual Results:  
'Get new Extensions' is not visible as link

Expected Results:  
Should be visible as link (blue, underlined) or as button

It was visible as a link before.

Comment 1

[Bill Mason]

WFM 20030824 PC/WinXP

Are you using the default theme?  This is an item with a history of breaking in
non-default themes.

Comment 2

[Schelstraete Bart]

I'm using the default theme, with a complete new/fresh FireBird installation
(nightly build)
(sorry, forgot to tell this)

Comment 3

[Mike Connor [:mconnor]]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=pref.css&branch=&root=/cvsroot&subdir=mozilla/browser/components/prefwindow/skin&command=DIFF_FRAMESET&rev1=1.7&rev2=1.8

themesLink CSS info removed here, not added to
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/pref/skin/pref.css where
it belongs.

--> Ben

Ben, I don't think this was intended, or you'd have cleaned up the extensions
and themes panels.

Comment 4

[Mike Connor [:mconnor]]

*** Bug 217414 has been marked as a duplicate of this bug. ***

Comment 5

[Simon Paquet [:sipaq]]

Adjusting summary. I can confirm this on 20030826 W2K.

Comment 6

[Reuben Balik]

Yeah, I just noticed this bug in the 20030826 build on Windows 98SE.  I am using
the default theme.  Instead of showing up blue like it used to, it just shows up
as text.
If you click on it, it does still take you to the extensions page, though.

Comment 7

[David P James]

This occurred when the new mozapps dir was added and a few files from browser/
(pref/prefs.css and downloads/unknownContentType.css) were duplicated to
mozapps/ and some changes made to both pref files. The problem [I think] is that
some of what was stripped from browser/pref/pref.css was not added to
mozapps/pref/pref.css. I discovered this when attempting to update Pinball.
Here's the AWOL code:

.themesLink {
  margin-left: 5px;
  text-decoration: underline;
  color: blue;
  cursor: pointer;
}

.themesLink:active {
  color: red;
}

#previewImageContainer {
  height: 93px;
  padding: 1px;
}

#previewImage {
  max-width: 355px;
  min-width: 355px;
  max-height: 85px;
  min-height: 85px;
}

.extensionInfoArea {
  background-color: -moz-Field !important;
  height: 10em;
}

Tellingly, most of it involves theme-related stuff. I'll investigate if a patch
to put this in does the trick. I think it was supposed to go into the mozapps
version since I see no reason it would have been stripped from the browser
version if that wasn't the case. At any rate, it affects more than just the link
- it reports that the default theme is wrong version (this occurred on
2003-08-26, the day *before* the skinVersion checkin and subsequent back-out).
So I'm going to have to adjust the summary again...

Milestone --> 0.7
since really, we can't release with such obvious bustage.

Comment 8

[David P James]

*** Bug 217645 has been marked as a duplicate of this bug. ***

Comment 9

[David P James]

Attachment: Partial fix

This is a bit annoying. I can fix the themes/extension link related stuff but
not the version bustage. I know that bustage occurred late on the 25th and not
on the 27th since my build from the 26th has it but the one from early on the
25th didn't.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

ok. 

Comment 11

[Bill Mason]

*** Bug 217846 has been marked as a duplicate of this bug. ***

Comment 12

[Steffen Wilberg]

*** Bug 217408 has been marked as a duplicate of this bug. ***

Comment 13

[Jesse Ruderman]

Several of the bugs duped to this one sound more like bug 214465 than this bug.

Comment 14

[Simon Paquet [:sipaq]]

*** Bug 217936 has been marked as a duplicate of this bug. ***

Comment 15

[David P James]

> Several of the bugs duped to this one sound more like 
> bug 214465 than this bug.

Yes and no - the problem in bug 214465 has been around for a little while. The
default theme didn't "take" instantly; one would either have to restart Firebird
or launch a new window (and close the old one). There were no incompatibility
issues however.

The bustage all occurred at the same time, which is why I think it should be
kept together. But I'll admit there does seem to be two distinct issues here -
we could reopen one of the dupes (217846 for example) and set a dependency on it
to this one to better catch dupes before they're filed. Mike? What do you think?

Comment 16

[Bill Gianopoulos [:WG9s]]

My opinion (for what it is worth) is that we have 2 defined issues.

1.  The default theme is being diagnosed as being incmpatable with the browser.

2.  The "Get new extension" and "Get new themes" don;t appear as links in the
default theme.

The ONLY thing that appears to make these related is that they all began with
the same nightly build.

Are you trying to say that anything that begins in the same nightly should all
be grouped into one bug?  That hardly seems like it would be condusive to
getting anything fixed.

You should be very careful about lumping things that are not really the same
issue under one bug even itf it appears they might be related. The problem is
that lumping them together makes the developers working on the issue to try to
find a common cause for what might be 2 different problems.

So my opion is that unless you know both of these issues have one common cause,
please make 2 bugs out of this.  You might find that as soon as this is done
both things get solved.  If there really is only one cause it won;t hurt that
much to have 2 seperate bugs since we do have 2 distinct issues.

Comment 17

[Mike Connor [:mconnor]]

The skin bustage is a separate bug from the OK button issue (bug 215707).  I
broke that with my ill-advised patch for 213994, which has been backed out of
the tree.  This should remain focused on the skins bustage issue, which is a
matter of missing CSS.

The theme reversion issue (bug 214465) has been around since the skinVersion
change, I'm trying to hunt that one down today.

Comment 18

[Simon Paquet [:sipaq]]

Ben fixed this a few hours ago.

Comment 19

[David P James]

Simon: the version issue is still around.

William:
The reason I lumped these together is because I thought they were caused by the
same thing, since there is only one large (albeit multi-file) checkin that could
have done this. I have no doubt that this is a mozapps migration issue, but with
hindsight I should have made this a tracking bug instead.

I'm going to reopen bug 217846 since it has the best description of the version
issue.

Verified w/ 20030902

Comment 20

[Mike Connor [:mconnor]]

*** Bug 217415 has been marked as a duplicate of this bug. ***

Comment 21

[Simon Paquet [:sipaq]]

*** Bug 217970 has been marked as a duplicate of this bug. ***

Comment 22

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change