219498 - parent+child no select folders in hierarchy cause grand children not to show up in imap subscribe UI

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Andreas Aardal Hanssen]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021204
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021204

Mozilla's IMAP client does not seem to display hierarchy correctly
when subscribing. This may be related to IMAP servers that do not
support the CHILDREN extension.

No other clients see this problem.


Reproducible: Always

Steps to Reproduce:
Log into the account "imaptest" with password "imaptest" on host
imap.infeline.org. SSL must be switched on to be able to log in,
although this is not related to the bug.

With mozilla mail, subscribe to folders. All folders are shown
with the correct levels of hierarchy. Subscribe to any one folder
at a leaf level. Now press ok, and see that mozilla shows this
folder. Now click subscribe again. Notice how mozilla now does
no longer display the hierarchy levels correctly.

Unsubscribe from the one folder that you subscribed to earlier.
Then click ok, and subscribe again. Now only first (INBOX) and
second level folders are displayed.

Actual Results:  
Mozilla claims that mailboxes have no children, although they
do as correctly reported by the IMAP server.

Expected Results:  
For servers that do not support CHILDREN,
Mozilla IMAP should do a LSUB "" "%" and then a LSUB "" "%/%" to
display all first level mailboxes with a '+' in front of all that
the second LSUB response showed has children.

Then, as a user clicks the '+', Mozilla should submit a new LSUB ""
"mailbox/%/%" do display any third level folders, and so on.

This is the behavior of Evolution.

This IMAP account will be open until this bug has been resolved.

Comment 1

[HIROSHIMA Naoki]

same result with Thunderbird 0.3 (20030923)

Comment 2

[Larry Fields]

I can confirm that this bug also occurs with 

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030624

on our IMAP server at Georgetown University running iPlanet Messaging Server
5.2, which does support CHILDREN.

The real issue appears to be, as Andreas Aardal Hansson (who reported this bug)
notes in http://www.mail-archive.com/[e-mail]/msg01866.html, and I
quote,

"But Mozilla's IMAP client interprets the \NoSelect as an implicit \NoInferiors,
that is - it assumes that Dev has no submailboxes."

Comment 3

[Larry Fields]

This bug is perpetuated in Mozilla 1.6a.

Comment 4

[David :Bienvenu]

can I get a client-side imap protocol log from a 1.6a build of this problem?

http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html#imap

Comment 5

[Andreas Aardal Hanssen]

With Mozilla 1.6a, I am no longer able to reproduce
this problem. I see from the log output that Mozilla
now uses the LIST command correctly. From all I can
see, this bug is fixed.

Good work!

Andreas

Comment 6

[David :Bienvenu]

fix checked in for bug 220375 - it will be in tomorrow's build. The subscribe UI
problem had to do with the subscribe UI persisting the expand/collapse state of
folders, which it's not supposed to do.

Comment 7

[Larry Fields]

This bug is still not fixed in version

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6b) Gecko/20031207

I e-mailed client & server-side logs to [e-mail] on Dec. 8, 2003.

The basic tests done on mozilla as listed here are also wrong:

http://www.mozilla.org/quality/mailnews/tests/sea-mn-imap.html

Looking at Advanced IMAP settings, the part which reads:

(# list "" "%/%" and server responds w/ list of all Second Level Folders) 

should instead read:

(# list "" "%/*" and server responds w/ list of all Second & Lower Level Folders)

Comment 8

[David :Bienvenu]

Re-opening for Larry Field's problem - changing summary to reflect his
particular issue. I believe I see the problem in the code but I'm not sure how
to fix it. Here's the problematic code: 
http://lxr.mozilla.org/seamonkey/source/mailnews/imap/src/nsImapIncomingServer.cpp#1150

We do this so the subscribe UI will know it can't select the folder, but it
causes this bug. Maybe this check can just be removed...

Comment 9

[David :Bienvenu]

Attachment: proposed fix

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 137862 [details] [diff] [review]
proposed fix

r/sr, thanks david.

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 137862 [details] [diff] [review]
proposed fix

a=sspitzer for 1.6 final, for this regression.

Comment 12

[David :Bienvenu]

fixed on trunk.

Comment 13

[David :Bienvenu]

bug 229214 spun off for the UI issue of non-subscribable folders.

Comment 14

[Larry Fields]

I can confirm that this bug is fixed in

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7a) Gecko/20031228

Glad to see it also made 1.6 final.  Thanks for your help!

Comment 15

[Scott MacGregor]

*** Bug 232482 has been marked as a duplicate of this bug. ***