221381 - Add Attach Personal Card (vCard) option to Attach button in compose window toolbar

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Ian Neal]

Under Netscape 4.x, in addition to adding a vCard from the File, Attach menu you
could add one from the Attach button on the compose window toolbar.

Comment 1

[Ian Neal]

Accepting

Comment 2

[Ian Neal]

Attachment: Patch v0.1 that adds attach personal card to Attach button

Fairly simple patch

Comment 3

[[e-mail]]

Comment on attachment 132737 [details] [diff] [review]
Patch v0.1 that adds attach personal card to Attach button

You should set the "checked" attribute on the command, not the menuitems (also
they won't need ids any more). Also the button's menuitem should not have the
word "Attach" in the label.

Comment 4

[[e-mail]]

David, Scott, Seth, I don't know if you're listening or my mail server died, but
I would like to see the Attach menu restored to a File submenu...

Comment 5

[Ian Neal]

Comment on attachment 132737 [details] [diff] [review]
Patch v0.1 that adds attach personal card to Attach button

Cancelling old sr request

Comment 6

[Ian Neal]

Attachment: Patch v0.2 which adds attach personal card to Attach button

This patch takes on board some of the comments from Neil above, but the actual
wording of the menuitems is consistent.

The submenu issue (and presumably the wording issue) is now bug 221472

Comment 7

[Ian Neal]

Comment on attachment 132799 [details] [diff] [review]
Patch v0.2 which adds attach personal card to Attach button

Cancelling old r request

Comment 8

[Ian Neal]

Attachment: Revised Patch v0.2a which adds personal card to Attach button

Revised version that takes into account changes made by bug 45524

Comment 9

[[e-mail]]

Comment on attachment 132812 [details] [diff] [review]
Revised Patch v0.2a which adds personal card to Attach button

>+<!ENTITY attachVCardCmd.accesskey "v">
>+<!--LOCALIZATION NOTE attachVCardButton.label Don't translate the term 'vCard' -->
>+<!ENTITY attachVCardButton.label "Personal Card (vCard)">
I guess you want to save time when fixing bug 221472.
(You could have put this with the attachVCardMenu items and saved yourself an
accesskey, or used the 4.x accesskey "P")

>+  <command id="cmd_attachVCard" type="checkbox" checked="false" oncommand="ToggleAttachVCard(event.target)"/>
Nit: Don't need type="checkbox" here.

Comment 10

[Ian Neal]

Attachment: Revised patch v0.2b that adds Person Card to Attach button

Tweaked as per Neil's comments - removed type="checkbox" and changed accesskey
to P

Comment 11

[Ian Neal]

Comment on attachment 132880 [details] [diff] [review]
Revised patch v0.2b that adds Person Card to Attach button

Carrying r= forward

Comment 12

[David :Bienvenu]

Comment on attachment 132880 [details] [diff] [review]
Revised patch v0.2b that adds Person Card to Attach button

sr=bienvenu - these two menu items stay in sync re checked/unchecked because
they use the same cmd, right?

Comment 13

[Ian Neal]

That's correct

Comment 14

[Ian Neal]

Checked in by timeless, thanks again.

Comment 15

[(not reading, please use [e-mail] instead)]

neil, thanks for doing this.

Comment 16

[(not reading, please use [e-mail] instead)]

this landed in 1.6 alpha

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using 2004-07-25-09 on Windows XP.