221597 - Firebird: remove the references to files packaged as chrome://communicator/* and chrome://navigator/*

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P1)

Description

[Pierre Chanial]

> grep -slr "chrome://communicator" mozilla/browser/
mozilla/browser/mozilla/browser/app/profile/all.js
mozilla/browser/base/content/browser-menubar.inc
mozilla/browser/base/content/contentAreaUtils.js
mozilla/browser/base/content/openLocation.xul
mozilla/browser/base/content/printPreviewBindings.xml
mozilla/browser/components/bookmarks/content/bookmarksManager.xul
mozilla/browser/components/bookmarks/content/bookmarksPanel.xul
mozilla/browser/components/downloads/content/helperApps.js
mozilla/browser/components/history/content/history-panel.xul
mozilla/browser/components/prefwindow/content/overrideHandler.js
mozilla/browser/components/prefwindow/content/pref-calibrate-screen.xul
mozilla/browser/components/prefwindow/content/pref-charset.xul
mozilla/browser/components/prefwindow/content/pref-fonts.xul
mozilla/browser/components/prefwindow/content/pref-images.xul

> grep -slr "chrome://navigator" mozilla/browser/
mozilla/browser/app/profile/all.js
mozilla/browser/base/content/browser.js
mozilla/browser/base/content/openLocation.xul
mozilla/browser/base/skin/browser.css
mozilla/browser/components/downloads/skin/downloadmanager.css
mozilla/browser/components/prefwindow/content/pref-calibrate-screen.xul
mozilla/browser/components/prefwindow/content/pref-themes.xul

Comment 1

[Simon Paquet [:sipaq]]

Pierre, this is essentially what bug 200142 is all about. Shall I mark this bug
a duplicate of bug 200142 or the other way around?

Comment 2

[Pierre Chanial]

Status:
> grep -slr "chrome://communicator" mozilla/browser/
mozilla/browser/app/profile/all.js
mozilla/browser/base/content/browser-menubar.inc
mozilla/browser/base/content/contentAreaUtils.js
mozilla/browser/base/content/printPreviewBindings.xml
mozilla/browser/components/downloads/content/helperApps.js
mozilla/browser/components/history/content/history-panel.xul
mozilla/browser/components/prefwindow/content/overrideHandler.js
mozilla/browser/components/prefwindow/content/pref-charset.xul
mozilla/browser/components/prefwindow/content/pref-images.xul
mozilla/browser/components/sidebar/src/nsSidebar.js

> grep -slr "chrome://navigator" mozilla/browser/
mozilla/browser/app/profile/all.js
mozilla/browser/base/content/browser.js

Comment 3

[Pierre Chanial]

simon: well, this bug is not about removing the files we don't use, but about
not using the files we shouldn't.

Comment 4

[Jonathan Louie]

will fixing this bug fix 210553?  sounds related, but i don't know the mozilla code.

Comment 5

[Pierre Chanial]

Current state:
> grep -slr "chrome://communicator"
mozilla/browser/mozilla/browser/app/profile/all.js
mozilla/browser/base/content/contentAreaUtils.js
mozilla/browser/components/downloads/content/helperApps.js
mozilla/browser/components/history/content/history-panel.xul
mozilla/browser/components/prefwindow/content/overrideHandler.js
mozilla/browser/components/prefwindow/content/pref-images.xul
mozilla/browser/components/sidebar/src/nsSidebar.js

> grep -slr "chrome://navigator"
mozilla/browser/mozilla/browser/app/profile/all.js

Comment 6

[alanjstr]

all.js things

chrome://navigator/locale/navigator.properties
chrome://navigator-region/locale/region.properties
chrome://communicator-region/locale/region.properties

Comment 7

[alanjstr]

missed one.  
chrome://navigator-platform/locale/navigator.properties

Comment 8

[Steffen Wilberg]

Pierre, these files are not part of the build:
mozilla/browser/components/prefwindow/content/pref-images.xul
mozilla/browser/components/prefwindow/locale/pref-images.dtd
mozilla/browser/components/prefwindow/content/overrideHandler.js
mozilla/browser/components/downloads/content/helperApps.js
mozilla/browser/components/sidebar/src/nsSidebar.js

We use other files, e.g. pref-features-images.xul, .js and .dtd.

Comment 9

[Steffen Wilberg]

And if you want to clean up some more, you can also cvs remove these files:
mozilla/browser/components/prefwindow/content/pref-downloads.js
mozilla/browser/components/prefwindow/content/pref-downloads.xul
mozilla/browser/components/prefwindow/content/unknownContentType.xul
mozilla/browser/components/prefwindow/locale/pref-downloads.dtd

They're now in mozilla/toolkit/mozapps/downloads.

Comment 10

[Pierre Chanial]

There was a bunch of unused files (24 to be precise) nsSidebar.js is used
though. And we have now to decide what to do with all these *-region files, as
alanjstr pointed.

We're getting closer...!
Current state:
> grep -slr "chrome://communicator"
mozilla/browser/mozilla/browser/app/profile/all.js
mozilla/browser/components/sidebar/src/nsSidebar.js

> grep -slr "chrome://navigator"
mozilla/browser/mozilla/browser/app/profile/all.js

Comment 11

[Steffen Wilberg]

Thanks so much for cleaning up. I see that we need nsSidebar.js for e.g. adding
search engines. I was confused because it's not packed into browser.jar.

As for the *-region files, we should change the references
from chrome://navigator-region/locale/region.properties
and from chrome://communicator-region/locale/region.properties
to chrome://browser-region/locale/region.properties,

as well as from chrome://navigator/locale/navigator.properties
to chrome://browser/locale/browser.properties.

Make the necessary changes/additions to
mozilla/browser/base/locale/region.properties and browser.properties, and drop
the prefs we don't need.

Comment 12

[Steffen Wilberg]

Attachment: patch

This is an implementation of my plan in comment 11.
It was easier than I thought.

Navigator version: startup.homepage_override_url=http://www.mozilla.org/start/
Browser version:
startup.homepage_override_url=http://www.mozilla.org/projects/firebird/
My suggestion:
startup.homepage_override_url=http://www.mozilla.org/products/firebird/
This setting is commented out by the way.

I added this pref. Don't know if we need it: general.useragent.contentlocale=US


Navigator version: browser.startup.homepage=http://www.mozilla.org/start/
Browser version:
browser.startup.homepage=http://www.mozilla.org/products/firebird/

fix typo that was already fixed in navigator:
intl.menuitems.alwaysappendaccesskeys=

There are two lines left in all.js, I need some help here:
pref("intl.collationOption",		   
"chrome://navigator-platform/locale/navigator.properties");
pref("intl.charset.default",		   
"chrome://navigator-platform/locale/navigator.properties");

The other settings are identical in navigator and browser.
Note that these files are not stored in comm.jar. But why not do it while we're
at it.

Comment 13

[Steffen Wilberg]

Comment on attachment 135522 [details] [diff] [review]
patch

Concerning that typo: The pref is only used in one place:
http://lxr.mozilla.org/mozilla/source/layout/xul/base/src/nsTextBoxFrame.cpp#20
9
It's "access", not "acces". So it's a good thing to correct that.

Comment 14

[Steffen Wilberg]

Comment on attachment 135522 [details] [diff] [review]
patch

Pierre was faster.

Comment 15

[Steffen Wilberg]

Attachment: patch v.2: navigator-region and communicator-region

This is my first patch minus the issues Pierre already fixed.
It changes navigator-region and communicator-region to browser-region.

Comment 16

[Pierre Chanial]

thanks for help, Steffen.
Marking fixed !!!