221602 - Don't ship comm.jar

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Pierre Chanial]

Lot of work needed here. There are three steps: clean up the GRE, the toolkit
and Phoenix.

Comment 1

[Simon Paquet [:sipaq]]

*** Bug 200142 has been marked as a duplicate of this bug. ***

Comment 2

[Simon Paquet [:sipaq]]

Pierre, you might want to take a look at attachment 127363 [details] a chrome
trace-report, which should yield some interesting information. Also take a look
at attachment 127430 [details] and attachment 127431 [details] (the script and the header file,
which generated the report).

Comment 3

[Phil Ringnalda (:philor)]

Thanks to the passage of time, this is now just xbl-marquee, and the cookie accept dialog.

Comment 4

[Phil Ringnalda (:philor)]

And, while the cookie accept dialog can be utterly painlessly moved to toolkit.jar, xbl-marquee is a little more tangled up in the tree, and, at this point this bug is pointless: we need both of the remaining things in there, and moving them both to toolkit.jar looks like it would pick us up a mighty 400 *bytes* of .jar overhead. Uncompressed.

Comment 5

[Steffen Wilberg]

Attachment: patch

Bug 468011 is trying to consolidate the jars.
This is finally removing comm.jar.
Tested that the cookie accept dialog and <marquee> still work.

Comment 6

[(dormant account)]

(In reply to comment #4)
> And, while the cookie accept dialog can be utterly painlessly moved to
> toolkit.jar, xbl-marquee is a little more tangled up in the tree, and, at this
> point this bug is pointless: we need both of the remaining things in there, and
> moving them both to toolkit.jar looks like it would pick us up a mighty 400
> *bytes* of .jar overhead. Uncompressed.

what do you mean by tangled up?

Comment 7

[Phil Ringnalda (:philor)]

Wrong tense: the right tense for "mean (in February 2007) by tangled up?" is "did." Without an mxr indexing 1.9a2, dunno, probably something a bit like http://mxr.mozilla.org/mozilla1.8/search?string=xbl-marquee since SeaMonkey would have still been using the old installer, and embedding wouldn't have looked quite so abandoned back then.

Comment 8

[Steffen Wilberg]

http://hg.mozilla.org/mozilla-central/rev/3000a028e2e5