224538 - print preview: settings doesn't take effect immediately

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Steffen Wilberg]

This is the follow-up to bug 224450. I don't want anyone else to file bug for
something I discovered. ;-)
On the print preview toolbar, changes to Page Setup, switching
portrait/landscape, and modifying scale doesn't take effect until you close and
reopen print preview.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6a) Gecko/20031103
Firebird/0.7+ (Steffen)

Pierre said in bug 224450 comment 11: "...the settings are not really saved...".

Comment 1

[Pierre Chanial]

that should be fixed, now. I trashed nearly 200 lines of codes, so please test
well and report bugs! :)

Comment 2

[Steffen Wilberg]

Thanks Pierre, works fine!
Changes to Page Setup, switching Portrait/Landscape, and modifying scale now
take immediate effect. And I can't find a regression. Yet. :)

But I noticed with every theme I tried (Bluemonkey 0820, Orbit Blue, Pinball
0.7.5, Phly Warm 0.1.1, Walnut) that the arrows and portrait/landscape images
are not displayed. But that's an old problem. It works in 0.7, and it's broken
in 10/26 (don't have older builds lying around). I'll post a note in the
mozillazine forums.

Comment 3

[Steffen Wilberg]

It's because the changes in printing.css:
http://forums.mozillazine.org/viewtopic.php?p=254690#254690

Comment 4

[Simon Paquet [:sipaq]]

verified fixed 2003-11-09