Closed Bug 22558 Opened 25 years ago Closed 25 years ago

Need key bindings in mail window

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED WONTFIX

People

(Reporter: akkzilla, Assigned: scottputterman)

References

Details

(Whiteboard: [nsbeta2-])

The key binding architecture is working pretty well just about everywhere except in the mail window. I really miss having bindings like n (next unread message), spacebar paging down or else going to next message if you're at the bottom already, alt-d or delete to delete messages, etc. We need a mailWindowBindings.xul (and platform binding files) with some basic bindings set up.
OS: other → All
QA Contact: lchiang → nbaca
Hardware: Other → All
These can even just be added directly to threadPane.xul or folderPane.xul.
Status: NEW → ASSIGNED
Target Milestone: M13
Target Milestone: M13 → M14
Moving to M14.
Having any enabled accelerator keys work is on the beta1 criteria document, so marking beta1.
Keywords: beta1
Unable to get key bindings to work. Added depends on bug 26484.
Depends on: 26484
Whiteboard: [PDT+]
Adding depends 26484 to whiteboard because I cannot pick a date until 26484 is fixed. Will need 1-2 days after 26484 is fixed.
Whiteboard: [PDT+] → [PDT+] depends 26484
Partial fix checked in. Both delete keys (forward and back) now activate the delete menu item. Changed this for navigator, mail, mail compose, and address book. Unable to find Editor's usage of standard Edit menu overlays so Editor not changed. I also checked in the "N" for next unread message but for some reason it was not working on my Mac. Will investigate tomorrow.
Another bug preventing us from using "N" as a key binding.
Depends on: 27832
Whiteboard: [PDT+] depends 26484 → [PDT+] depends 27832
Removing PDT+ because the Delete key is fixed and the space and N keys cannot be fixed in time for beta1. We will need to redo the way key events are handled to support these key bindings without breaking text input fields inside of html mail. Marking M15.
Whiteboard: [PDT+] depends 27832
Target Milestone: M14 → M15
Whiteboard: [PDT-]
A related issue which I assume is also covered by this bug: currently, bindings are only registered on certain panes. E.g. spacebar or page down only works if I click in the message pane first; delete only works if I click in the thread or message pane; if I accidentally click in the header area (which looks like part of the message pane, but isn't) then all key bindings stop working. Bindings should be registered on the whole window whenever possible, so the user doesn't wonder why paging with the spacebar works some times and not others.
Mass moving to M17
Target Milestone: M15 → M17
Mass move mailnews bugs to Putterman. Ouch.
Assignee: hangas → putterman
Status: ASSIGNED → NEW
Mail Review recommends beta2 stopper. Adding nsbeta2 keyword.
Keywords: nsbeta2
why is this a beta stopper? Why isn't this the same as all of the other polish bugs we are leaving until after b2? I don't really care, I"m just curious.
Putting on [nsbeta2-] radar.
Whiteboard: [PDT-] → [nsbeta2-]
the bindings I miss a lot are the + and - used to expand/collapse the current thead. Are those covered in another bug? If it's easy, I can add them myself.
David- I don't think +/- are covered in another bug. We have a general bug for mail/news http://bugzilla.mozilla.org/show_bug.cgi?id=38071.
this is a very general bug. I think nbaca filed a bunch of other bugs detailing a lot of the key navigation problems we have. I'm going to mark this WONTFIX and let the other bugs stand as the ones we need to fix.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WONTFIX
Can someone list the other bugs, please, so people who have been following this discussion can make sure there's a bug filed on their particular favorite key binding? Should we really be filing one bug per keybinding? Is there a spec somewhere that says which bindings will be supported and which won't? What about the issue of bindings not working in all panes, e.g. not being able to scroll a message without first clicking in the message pane?
Akkana, not being able to scroll the message without clicking in the message pane is filed: http://bugzilla.mozilla.org/show_bug.cgi?id=33507 As for the other bugs, we organized our bugs according to type and menu/window. What area are you looking for? I can find it for you. We have the specs which jglick authored.
Some bindings I use a lot in 4.x: - spacebar going to next message (if already at the bottom of the current one) - shift-n to go to next message (currently it does the same as n, next unread, though the menu says it should be hooked up to next) - m, u to mark read, unread - Shift-alt-R doing replyall instead of replysender - alt-shift-F for search messages What bug(s) which cover these? I'd also be interested in tracking (in case threaded mode gets working better -- some of these functions aren't implemented yet): +/- to expand/collapse all - t to mark thread unread - g to go to the next group/folder
Most of the issues you keybindings you refer to, Akkana, is now implemented and working. Please verify this.
Verified Wontfix. Individual bugs have been created for open issues.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.